IETF Logo Mail Archive

Re: [Rats] CHARRA module feedback

"Laffey, Tom (HPE Aruba)" <tom.laffey@hpe.com> Fri, 30 April 2021 20:59 UTC

Return-Path: <prvs=0754a077c5=tom.laffey@hpe.com>
X-Original-To: rats@ietfa.amsl.com
Delivered-To: rats@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 48ACA3A26B8; Fri, 30 Apr 2021 13:59:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=hpe.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YdkZumDAfwnJ; Fri, 30 Apr 2021 13:59:09 -0700 (PDT)
Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 833663A26B6; Fri, 30 Apr 2021 13:59:08 -0700 (PDT)
Received: from pps.filterd (m0134423.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13UKs4S4001617; Fri, 30 Apr 2021 20:59:08 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=Bh5ePJ1TyXKdGRLbSDVumkJyx/0ZiiinDBi1j73W8aI=; b=JbtC/WXHc/PcOX8Z6kNOk+THTnYn9kFAV/XCDlxUH8iyhvVWLvov8+w84FGmGYHl/88q UK5fcPHi5G9aAHJk9UzzOIJ57bUXTDTXCrgOXx2KoKJA2jLHAQEv0FkCRypMFTSQ5i4c OGebgNSJTnRs8DyaPLdqp1o7p4F7fc4Q4gA8bZJ0GhYb5072Wobu9ARBJdptYj1I5GQN nQIgJKy/lsDpByHHadawcRHEvyRVbRqMYuGuiQwodxBLeh+/sXiydIv+P1+nUAg6SmuG aeZN67b0cGt6V/UNlJeVbuP+AmsNUHIU7GkKWzfzSkPIDMXzpTWCA7cmWZKHVAHuujgw pQ==
Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 38811pk11d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Apr 2021 20:59:07 +0000
Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id C70D75B; Fri, 30 Apr 2021 20:59:06 +0000 (UTC)
Received: from G4W9336.americas.hpqcorp.net (16.208.33.86) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 30 Apr 2021 20:56:55 +0000
Received: from G1W8106.americas.hpqcorp.net (16.193.72.61) by G4W9336.americas.hpqcorp.net (16.208.33.86) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 30 Apr 2021 20:56:55 +0000
Received: from NAM04-BN8-obe.outbound.protection.outlook.com (15.241.52.10) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 30 Apr 2021 20:56:54 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P6bhnDxSGvcL97DlclfETrfuR7xd6vIv8PAsGOhZzHH8E3+vORyVNxlaD+kMXpT2ub0173fYQSLIw7Jani+oFbdmWHi9GrdNXzmC1W7bhaAo8AYqEGgxuqRKoeOBuf42oXzVn1oaUFma5t1GIeX/vsteytjxb4QiiotdhOf71a9qZXS7qIerPw2sV/IUmj1Td6o7DN+WtAHKBzSz78KTxORhg7A1Ek2xnIhLqBeOhhVSmEzrqYHIc03IGkORUFrjHxTMrf4gWEK6Z0BQEJjMwpH5hBKaONtv+6eId+f4Xc7xuftDoRm2ZmYNe+uvNmpqlKO3A2U1t48D/VjWUwvoMA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bh5ePJ1TyXKdGRLbSDVumkJyx/0ZiiinDBi1j73W8aI=; b=A5SAeO721JNI332AAcSiRdT1q0YoQ4pXpJgtCcPpszDDtNO7nFeyyYJh2pPV8RptX/qKgjVzsBzhWopX7gP8fw1OZZhjlw1RdVCORFoiuqU1zee5X0sZiFOEdAhd2/jAS0+zmXz3md1VLuQI6j9QRbnn8VqTyyhI3muFbG2UcZcXrE9BaSyZgQaG0V/lXpTBqb4/MPw28RNMusv9hlzdrp1rchLNO7HUsKQcQjsdLYE15yKq79IqMKelbTqPcl/zKl9wZk97hZHupQFICrkDn17o5jnnpk9dVwMlPzeRgXvvFvP3g1OB6hInbgs8yLUjoI/NDIGCfL7n53XVR/LnmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none
Received: from CS1PR8401MB1288.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7507::7) by CS1PR8401MB0343.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7507::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25; Fri, 30 Apr 2021 20:56:53 +0000
Received: from CS1PR8401MB1288.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b874:fd31:13dc:3a38]) by CS1PR8401MB1288.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b874:fd31:13dc:3a38%5]) with mapi id 15.20.4087.035; Fri, 30 Apr 2021 20:56:53 +0000
From: "Laffey, Tom (HPE Aruba)" <tom.laffey@hpe.com>
To: William Bellingrath <wbellingrath@juniper.net>, "draft-ietf-rats-yang-tpm-charra@ietf.org" <draft-ietf-rats-yang-tpm-charra@ietf.org>
CC: "rats@ietf.org" <rats@ietf.org>, Guy Fedorkow <gfedorkow@juniper.net>
Thread-Topic: CHARRA module feedback
Thread-Index: AQHXPfdIIb/h9Qojpk27S6HpcdEkq6rNiSLw
Date: Fri, 30 Apr 2021 20:56:53 +0000
Message-ID: <CS1PR8401MB1288D51A0D3820482CF327F6815E9@CS1PR8401MB1288.NAMPRD84.PROD.OUTLOOK.COM>
References: <92EC7C7D-0679-4928-9B52-90ECC1D97701@juniper.net>
In-Reply-To: <92EC7C7D-0679-4928-9B52-90ECC1D97701@juniper.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ActionId=b5077a18-bd46-42b3-bdb7-35af38d777ed; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2021-04-30T19:16:02Z; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Name=Juniper Business Use Only;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true;
authentication-results: juniper.net; dkim=none (message not signed) header.d=none;juniper.net; dmarc=none action=none header.from=hpe.com;
x-originating-ip: [165.225.243.34]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cbfe0ff3-949c-4c28-705a-08d90c1a7bd9
x-ms-traffictypediagnostic: CS1PR8401MB0343:
x-microsoft-antispam-prvs: <CS1PR8401MB034361D7AE69A88E2E85EE29815E9@CS1PR8401MB0343.NAMPRD84.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: w1A9Cga082MsfVP+RKhdbts4UJbGWSa/+N0zMayaOXVnz9VPmvjbkvXBrnZaBwxtgt53YL5x7L4MbeWRLAxsOqr30AIa297YLtpfMQ+7O83nvCe/4DNxVhjRJqemcDs+9CbDdjZFXtfJOCQiyRkzuh8awphzn4xsBaC8cQ2uPehcaMtmpjL0lZUt9txbnwhHB9HBq8junny1y4Ru6hFXQ6IeBtOL8tXmXVudoEoOCUDNN7CdDx+o1wVhvZtfOKLQD18JGAmj37Yw/S38MO6cbqvUXTy5ZQzRFYMajZ8JfYww/WpMy4GusfZFBqUiI8sgFySQWubN8Fq/7NKYBgf7M/U2IyNSLAmRretr9e6QWqNnaNjhwZv5i7Y/5PsPFEyMGm3LVONbaBiK3VC8x+kK7wSAeiBKVS5GuGN0RUf2qfME9k5qiDEHeW7UBtnluX8m8DooV255xaRJCaWQEJKBpAcXfG479AHkmZnAb7uAR/1enKeitX3Ts3x1wYPScOVkCcYNc+DCwok3DJ8om1dBAOHEYv7zDgbaaN/k8wPtNQ8fCP4c3NW/pRy8WGLreMV1weuD63uzh8dUd/n+DoHwFfwGFn5qeT+d52pa+dT3Fp8=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CS1PR8401MB1288.NAMPRD84.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(376002)(366004)(39860400002)(396003)(346002)(136003)(7116003)(83380400001)(8676002)(54906003)(4326008)(53546011)(55236004)(8936002)(110136005)(66556008)(478600001)(122000001)(86362001)(55016002)(66446008)(66476007)(66946007)(33656002)(7696005)(76116006)(2906002)(26005)(5660300002)(71200400001)(316002)(3480700007)(38100700002)(52536014)(9686003)(186003)(6506007)(64756008); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: 2FCOjG067Lv5oG7ZMDN11FGJRbiOtOzjZp2oUZew9159flKLVJrjGfkaY4m/Xzqyty5k9ep7hdEcHcr1OestfE/HS+ZntY/U3f3JF8f0JGuevKmrnZgcMdZkzy4jASriPgzfhxq80AwGk2aWUKii9vdQjvAsSeGDgMlYDNlA1QIUhsVyhCbRFaHtmy/Za7bKJj0uPcAB7xmP6V1UciGzsjTX96KCtnOGZNBuHoR/LmR2kZnYfnova5XwAxesIuBkkp2MsODx4LpCwI5spfiZGF1Kjw7gIju4/11QCui2VaY7qaQ4trGLx84S4yypc/7pXu6msw7RBRH9lUuyikNlCG6zGZMuPVFKlr5OXXus234p2fLGQfaiWwSqPfXYRobCY+PwQIFWN58RmcKvys4pPj6HocnHUBI44HQa0MLcy27NgsTq875XFN2U1r5czZXnrtcQ+bxPqZI8Sn3UubQMqyvtdhq0F8V7ysRQlMNuWL/GfjfLf9jZNv1ojCNlCaO6qQpg4jFxZr7Oy9DcrFsL++mR2+bBzFtAkc8HCETaTfVqJBQPO97Cs4kkwdWx/3jPHnkPlhBDuNubT89B/YdjbH7arKaxuYn6YG8OSsf6JScCC6BevsqKgAfot28NSPWpsUdjAnqARPgZZ/qr4SUzcm3G4C5Hez3FbFo+om/IDFdpvUEk7ooTHC1S3OHNSFLFUULL1hDimaErHlnHfQkFHA7/j5t7drFV6rkiiG6byKu9W2u0p0prHpqXnvzBLs1sMycQG5qx/IvcmeU7YtOYrUbef6ryI1zxY/Hfx7jDAbXNfL1T+02yeynZm8+MIykBBqJPQ4JpWTJ+TfWAy9R8Ad3XW5XG43+4JqGNUhCgEauDqe3WzB57poqVYwaZY3szDPLSbE1L0mNEic+J99j6T6nv/dMjRyOdSu/L0wOKcvJhrwpyEpog+yo5t9+kCttGTqsZ7g31GXyB5qq6K0k837xUS4KQP4XEDpGAPCGlyk0Tm7Hkb4Ugnr6uHLQGcd6YCwTA5i8AMM7Kg4nJaQYAyTgjJ54wbpyHI/3p5bkQW4wMOmaoHtgzdUvzjpjTzMwAioRsi5X1P5TEEPXRNtyytziff2H9qkswbrI5umGXDGHGoOwQUNEwiTlZgzwKnvSI+lRgOHBNBpw1VuWKGhMXjbdF87WojVm4QnEXBOPpQePdHjFf04ustgRD5UnAC+YSPi5tp5skH2/go53NSUw4Hxdvf32uB6MOp9XsmO/QzQDeM5d6Ohw3blfQsC7UKKtx5yD3Coaqdj0NRq2fFES1KI1fTEpEM+OyJtldLMKUapLasx7OtnvgBx19htpUQcTm
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1288.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: cbfe0ff3-949c-4c28-705a-08d90c1a7bd9
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2021 20:56:53.5046 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1xBAJfjxsKN9bx0ertSF8RKGT64pwabDRy4tGkoFBNX1N5eZfFABTN7sXMl6IjINAuE6iiwCGul6SP3CO3u9kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0343
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: uOldBkBvEukbvKrKJAyp2LTFYRgtHNQH
X-Proofpoint-ORIG-GUID: uOldBkBvEukbvKrKJAyp2LTFYRgtHNQH
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-30_12:2021-04-30, 2021-04-30 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 clxscore=1011 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104300147
Archived-At: <https://mailarchive.ietf.org/arch/msg/rats/v5nf4vvVTUqHMZAED4Rw2OHyhAs>
Subject: Re: [Rats] CHARRA module feedback
X-BeenThere: rats@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Remote ATtestation procedureS <rats.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rats>, <mailto:rats-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rats/>
List-Post: <mailto:rats@ietf.org>
List-Help: <mailto:rats-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rats>, <mailto:rats-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Apr 2021 20:59:14 -0000

Hi William,

Re #3: TPMS_QUOTE_INFO Is a TPM structure, so I think this is intentional.

Re #4: Assuming log retrieval is modelled on the SNMP MIB for TPM based attestation, it allows full and incremental log transmission from low-end devices. I believe this is intentional.

Thanks,
Tom



-----Original Message-----
From: William Bellingrath <wbellingrath@juniper.net> 
Sent: Friday, April 30, 2021 12:31 PM
To: draft-ietf-rats-yang-tpm-charra@ietf.org
Cc: rats@ietf.org; Guy Fedorkow <gfedorkow@juniper.net>
Subject: CHARRA module feedback

Hi all,

I have another round of feedback and review on the CHARRA YANG module from some of my colleagues.
Comments are predominately aimed at naming conventions and readability and are only suggestions.


1. Our preference is for "-" vs. "_" in naming conventions in all cases, for example as below.
  feature netequip_boot {
    description
      "The device supports the netequip_boot logs."; ...



2. We would generally say "Netconf server" instead of "YANG server".
"The module defined requires at least one TPM 1.2 or TPM 2.0 and corresponding Trusted Software Stack included in the device components of the composite device the YANG server is running on."



3. Noting the use of upper case and '_' here to check if this is intentional.
       leaf TPMS_QUOTE_INFO {
         type binary;
         mandatory true;
...



4. This RPC name looks very generic and not specific to the particular feature. Is this the intention?
   +---x log-retrieval <<<<<<
      +---w input
...


Thanks,
William Bellingrath


Juniper Business Use Only

v2.23.0 | Report a Bug | By Email