Re: [regext] [OPS-DIR] Opsdir last call review of draft-ietf-regext-epp-fees-16

Warren Kumari <warren@kumari.net> Mon, 09 September 2019 16:51 UTC

Return-Path: <warren@kumari.net>
X-Original-To: regext@ietfa.amsl.com
Delivered-To: regext@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6948A120098 for <regext@ietfa.amsl.com>; Mon, 9 Sep 2019 09:51:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=kumari-net.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ah8j2Xstb-LH for <regext@ietfa.amsl.com>; Mon, 9 Sep 2019 09:51:44 -0700 (PDT)
Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 02865120088 for <regext@ietf.org>; Mon, 9 Sep 2019 09:51:44 -0700 (PDT)
Received: by mail-qk1-x72d.google.com with SMTP id x5so13738111qkh.5 for <regext@ietf.org>; Mon, 09 Sep 2019 09:51:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kumari-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9nJgUvNffRgd/XNgajQbrOjrz8nL4HGEkscGL5dtbq4=; b=tqIMqms/FM8gaCEzqCLXemp5TSrkhWkJswWXQVtj5UGP5NHpiCGEy9D9H4NRdKjAT5 VMi2Or95GHnt9YxLOF74qfYvVhK+h6GjNtPpBcBTVMXLFd+vktQ+QQoS3fjLJkTV3VRk 1yMqquZh6yGb6EVFsNrX68+xmo4MOCfjcFc2k43EKXZ70F9gpOIzARPZxYInBCiKXC9a C3TMRnZjC03onQ+tTNPt3zAzdBOaeh8GY+OPYWG/0/yu1CGNYhwEXnJrWGQ6sWTEQHo4 gC8dL1r0x6kPuZacPkCmkKbii+M6jHs7txKVhVTGRUWsrbbjkktwMXw5WG9g6r6t00eX MTNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9nJgUvNffRgd/XNgajQbrOjrz8nL4HGEkscGL5dtbq4=; b=NqaMM6sdl+TxHwYVlzNuzunZR+tBSaidqyXiVbML9vD4FDZ5BZ2IwQc7F+Uj0Z1OsR 0mQO4XIzehAHcOvr5KIVh4JlCgodqtZ8KDf1ZW5gAUA6k4VL8Oi4gRjH0Cg1gidjpzAu pclIHCO6qZMfC6zS2pMT/e2TH4aTKF5ocLYlQvZwlookwWZL00Eg/vCyhYVyK1Ex+N9t pkXB7zzIZxgdzBlfmLFTZ/7ZvG/BnAVOtUqPuydALI885xJ4cdFhYwRIg/eqDX5NjCOZ 1ui+TZHvI3BKB/JPjmu5ffT7kn8DTVLVxdc5ZpLiPzz15sww21AaDDzGNYE2DYmqkXwd GMNA==
X-Gm-Message-State: APjAAAWHjCzQl1Uu/VZTn+6wNekXBWX8fhpWKcNsYKDN2MWub5oGkubp Ojzn5hxIstww9Ph++A3uuDg12FN16ntay8iak95XmA==
X-Google-Smtp-Source: APXvYqzzlAi4XUxu3TfvduSMiIJh9uPFvu1+I+b5bWxX7elnwCDUyxDZBqx7UkafqBTXXwCenYi5sEGLogcX0nX3lIY=
X-Received: by 2002:a37:6d2:: with SMTP id 201mr23931792qkg.106.1568047901505; Mon, 09 Sep 2019 09:51:41 -0700 (PDT)
MIME-Version: 1.0
References: <156214026874.14820.1075097887450900352@ietfa.amsl.com> <BL0PR02MB54912CA450A52572739D5AD7B1BA0@BL0PR02MB5491.namprd02.prod.outlook.com> <14709484-1B38-4BA7-8305-443859952094@cisco.com>
In-Reply-To: <14709484-1B38-4BA7-8305-443859952094@cisco.com>
From: Warren Kumari <warren@kumari.net>
Date: Mon, 09 Sep 2019 12:51:05 -0400
Message-ID: <CAHw9_iKxrnjJwX6xE0yjD-u0+MCvWD_ZxOmhhoaLCOC6iDmbOg@mail.gmail.com>
To: "Carlos Pignataro (cpignata)" <cpignata@cisco.com>
Cc: Roger D Carney <rcarney@godaddy.com>, "ops-dir@ietf.org" <ops-dir@ietf.org>, "draft-ietf-regext-epp-fees.all@ietf.org" <draft-ietf-regext-epp-fees.all@ietf.org>, "regext@ietf.org" <regext@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/regext/b2jqkfSs4dT5I_YjZw0CGDlC_SA>
Subject: Re: [regext] [OPS-DIR] Opsdir last call review of draft-ietf-regext-epp-fees-16
X-BeenThere: regext@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Registration Protocols Extensions <regext.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/regext>, <mailto:regext-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/regext/>
List-Post: <mailto:regext@ietf.org>
List-Help: <mailto:regext-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/regext>, <mailto:regext-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Sep 2019 16:51:48 -0000

[ - IETF@ for clutter]

On Fri, Sep 6, 2019 at 12:15 PM Carlos Pignataro (cpignata)
<cpignata@cisco.com> wrote:
>
> Many thanks for following up, Roger. Ack on all your responses below!

I wanted to quickly thank Carlos, and the authors for discussing and
working through these issues - it's great when OpsDir is able to
provide useful, substantive improvements to documents like this.

Thanks all,
W

>
> — Carlos.
>
> On Sep 6, 2019, at 10:48 AM, Roger D Carney <rcarney@godaddy.com> wrote:
>
> Good Morning,
>
> Thank you for your comments Carlos, please see my responses below. A new version of the draft will be published shortly and will address all of the review comments that needed edits.
>
>
> Thanks
> Roger
>
>
> -----Original Message-----
> From: Carlos Pignataro via Datatracker <noreply@ietf.org>
> Sent: Wednesday, July 3, 2019 2:51 AM
> To: ops-dir@ietf.org
> Cc: ietf@ietf.org; draft-ietf-regext-epp-fees.all@ietf.org; regext@ietf.org
> Subject: Opsdir last call review of draft-ietf-regext-epp-fees-16
>
> Notice: This email is from an external sender.
>
>
>
> Reviewer: Carlos Pignataro
> Review result: Has Nits
>
> Reviewer: Carlos Pignataro
> Review Result: Has Nits
>
> I have reviewed this document as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written with the intent of improving the operational aspects of the IETF drafts. Comments that are not addressed in last call may be included in AD reviews during the IESG review.  Document editors and WG chairs should treat these comments just like any other last call comments.
>
> I hope these comments are useful and clear.
>
> >From an operational point of view, the document describes protocol
> >interactions
> for dealing with failure conditions, and sets default behaviors. For example, the RFC 2119 language explaining the use of <fee:currency> is super useful.
>
> Minor comments, questions, and nits for your consideration follow:
>
> 1. Section 2 -- Migrating to Newer Versions of This Extension
>
>    (Note to RFC Editor: remove this section before publication as an
>    RFC.)
>
> Since forward compatibility is a key operational consideration, why should this section be removed? Especially when it contains RFC 2119 language.
>
> [RDC] Agree, Note will be removed.
>
> 2. Please do not treat as a pedantic comment, but I did not see an actual definition for what "fee" and "credit" mean. Since these words have specific context, it might not hurt to have a formal definition in Section 1.1
>
> [RDC] Added clarifying text to section 3.4 “A fee will result in subtracting from the Account Balance (described section 3.5) and a credit will result in adding to the Account Balance (described in section 3.5).”
>
> 3. Should the citation / reference for "ISO 4217" be "ISO 4217:2015"?
>
> [RDC] Text updated.
>
> 4. S3.4. Does this text imply there is no zero fee or credit possible? Might be useful to explicitly set guidance for the use of 0/null fee/credit.
>
>    A <fee:fee> element MUST
>    have a non-negative value.  A <fee:credit> element MUST have a
>    negative value.
>
> [RDC] This was discussed in another email but for completeness, this does state fee can be zero (a non-negative value).
>
> 5. S3.6, why "equal to" and not only "exceed"?
>
>    A server MAY reject certain
>    transactions if the absolute value of the <fee:balance> is equal to
>    or exceeds the value of the <fee:creditLimit> element.
>
> [RDC] This allows server policy flexibility, allows a server to deny a transaction when the limit is reached or exceeded.
>
> 6. Section 6.1
>
>   * Should <CODE BEGINS> and <CODE ENDS> markers be used as per the TLP?
>   * Should the (c) year be 2019?
>   * And should the BSD License be part of the code?
>
> [RDC] BEGIN/END is the standard that has been used in EPP RFCs. The copyright information in this section has been removed..
>
> 7. Section 7, Security Considerations.
>
> What are "security services"? Further, this protocol deals with on-the-wire monetary information. I suspect there might be specific such considerations.
>
> [RDC] “Security Services” are any related security features/functions. “on-the-wire” monetary information has been addressed through secdir comments, an additional line of text for clarity was added.
>
> 8. Section 9.  Implementation Status
>
> If this section is removed, the reference to [RFC7942] would result hanging without citations to it. ALthough the RFC Editor would catch, might want to indicate removal of the Normative Reference as well.
>
> [RDC] The removal text also states to remove the reference.
>
> Thanks!
>
> Carlos Pignataro.
>
>
> _______________________________________________
> OPS-DIR mailing list
> OPS-DIR@ietf.org
> https://www.ietf.org/mailman/listinfo/ops-dir



-- 
I don't think the execution is relevant when it was obviously a bad
idea in the first place.
This is like putting rabid weasels in your pants, and later expressing
regret at having chosen those particular rabid weasels and that pair
of pants.
   ---maf