Re: [regext] Genart last call review of draft-ietf-regext-rdap-partial-response-12

Barry Leiba <barryleiba@computer.org> Fri, 24 July 2020 23:26 UTC

Return-Path: <barryleiba@gmail.com>
X-Original-To: regext@ietfa.amsl.com
Delivered-To: regext@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 132703A0B33; Fri, 24 Jul 2020 16:26:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B2ay4akLJGp2; Fri, 24 Jul 2020 16:26:21 -0700 (PDT)
Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3AFD73A0B31; Fri, 24 Jul 2020 16:26:21 -0700 (PDT)
Received: by mail-il1-f173.google.com with SMTP id r12so8559977ilh.4; Fri, 24 Jul 2020 16:26:21 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dDn9U2g+xQ7cKEQtBxZdm5rHswAn3GEyCC6Zq3kHF2Y=; b=nzkpcV4LISl9A73TBReKlrlKZd3wqpwxGjmsihUBR7OlbmPLqxrRcmDvptOfdxboVE hpsIKAW7Cm176CaD6uhrE6/LpH2hZjYIyM0c05i3pB6u6sEoU5jpvvmhBPgMiulGdxFx Q9vnT4UNT4CgZNipqBWkmhj/jcw23y9YIs21S2pcY935rQzV4osPV0647XC8tlSmAVY0 5C8NU2QFXpH1qWEZgCCpjEEDBd27Pr8VdSVsWach8MZZa4lA/T7HDAU/FCfFRSTLl9S0 eAdS2VGAVuKvrqkAbX9py9fLGHdiVoRzBBFdGB8ypZKIJEqUoWqc9/DHj6GnYdZR5WBW ZNjg==
X-Gm-Message-State: AOAM531bqzxqOKETF3rdrE3bEM4ou8nn0Up8N6+Ff5PxDHWAMQuf7FPA sPhhU3PPPbmyr/7GDFFNnUtwXNu8HwFoVzpYESM=
X-Google-Smtp-Source: ABdhPJxM20uVoA2mXNadr5pTw6F9uQWq0D0+PmE9DervsN/7LGuVYVmUnMInHXflx2EFkNgS7XL0vhcW1pqVfZgSnLQ=
X-Received: by 2002:a92:cd48:: with SMTP id v8mr13107774ilq.114.1595633180408; Fri, 24 Jul 2020 16:26:20 -0700 (PDT)
MIME-Version: 1.0
References: <159563087863.9898.3402105673204734293@ietfa.amsl.com>
In-Reply-To: <159563087863.9898.3402105673204734293@ietfa.amsl.com>
From: Barry Leiba <barryleiba@computer.org>
Date: Fri, 24 Jul 2020 19:26:09 -0400
Message-ID: <CALaySJKHjN7=e9w-zFAVjyE5ut=t1FXmfUR_f18qUiN1ZhEimQ@mail.gmail.com>
To: David Schinazi <dschinazi.ietf@gmail.com>
Cc: draft-ietf-regext-rdap-partial-response.all@ietf.org, gen-art@ietf.org, last-call@ietf.org, regext@ietf.org
Content-Type: multipart/alternative; boundary="000000000000e900e305ab384c39"
Archived-At: <https://mailarchive.ietf.org/arch/msg/regext/nLnVTn6oSDtF3GNGAwNPVZ4OIgA>
Subject: Re: [regext] Genart last call review of draft-ietf-regext-rdap-partial-response-12
X-BeenThere: regext@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Registration Protocols Extensions <regext.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/regext>, <mailto:regext-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/regext/>
List-Post: <mailto:regext@ietf.org>
List-Help: <mailto:regext-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/regext>, <mailto:regext-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jul 2020 23:26:23 -0000

Wow, David, thanks for the super-quick review!

Barry

On Fri, Jul 24, 2020 at 6:48 PM David Schinazi via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: David Schinazi
> Review result: Ready with Issues
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-regext-rdap-partial-response-12
> Reviewer: David Schinazi
> Review Date: 2020-07-24
> IETF LC End Date: 2020-08-14
> IESG Telechat date: Not scheduled for a telechat
>
> Summary: Document is clear, well-written, and short. Thank you!
>
> Major issues: None
>
> Minor issues: After reading the document, I was somewhat
> confused as to the definition of fieldSet query parameter.
> I think adding a few sentences to Section 2 explaining that
> a field set is a string that the server generates which maps
> to a set of fields only known to the server would help.
> Additionally, specifying that the string can't be empty and
> which characters are allowed might help avoid interop
> issues down the road.
>
> Nits/editorial comments: None
>
>
>
>