Re: [Roll] Fwd: New Version Notification for draft-ietf-roll-efficient-npdao-18.txt

Rahul Jadhav <rahul.ietf@gmail.com> Sat, 18 April 2020 01:20 UTC

Return-Path: <rahul.ietf@gmail.com>
X-Original-To: roll@ietfa.amsl.com
Delivered-To: roll@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 55CBF3A0CF5 for <roll@ietfa.amsl.com>; Fri, 17 Apr 2020 18:20:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vqAFwydEwTYb for <roll@ietfa.amsl.com>; Fri, 17 Apr 2020 18:20:41 -0700 (PDT)
Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 32FC73A0CF4 for <roll@ietf.org>; Fri, 17 Apr 2020 18:20:41 -0700 (PDT)
Received: by mail-ed1-x52d.google.com with SMTP id j20so2855191edj.0 for <roll@ietf.org>; Fri, 17 Apr 2020 18:20:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7OoFlZvKCwT5Yf3IYQY/cx/Q+AlqLDxOAgXplO7t/dE=; b=dkdhZlknZ2KtbmbR0fM4NwwpqJbicRwSNDp/jHeh/zoF+iGEcF/yep0W7PzR+de5hy gxdOjNVsbNF4r0E9t0G4JqgLVLYB63zJx9FMMnPPzMlqfyITrEZjCCtpvkg8J3rs655O EQAfVaCLSD8h1R73f/9y+tqRvBAm6gqyixhKT/sgaDSJ+7P8WPt2U4g4+f4ulGaChTOo 9h5qiAFvTLy9709QxNTRzna/Th7UjGifMFyTP6R4sfPpyJqk9+nLdeWylbIpUNL6Jjhv j0w1xgmW2ddWXmM6j9Vvm/6I9kP4l4eFMbkhpQlJEL5+ihJIaHkwzU7YK2HWv1hEx9g7 9JqQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7OoFlZvKCwT5Yf3IYQY/cx/Q+AlqLDxOAgXplO7t/dE=; b=CwzxZoEKr3uToUGcOJnmtecMDliLJr46vTdS28Qn5ciQ82CG8MEbSsPsYjIw9iekG/ Ci2ufKrB9Sr8O3l3tLkoQIzZ/kxK7jOTzDjVV5+6SvF3SXA1JJRSbMkXKcEtoSS3R8p8 1ORyYnuydd6Ces5NJzMdkIIgDsfh6BQNaQxlC2potC7HdtXQ2TiLtzJGsbXK5hW5aToF GfCeh+IJrWkR8a1VzAnv236iqVakDcF7wa1p8uCUq85WNk0tmnDt3WKETFsdwm1sdeTE Ug6kQhFG7r51xwwJF6We034tCuqyeyqy4IJcD1rbu4CovN7iXzPSK0ESrE5SUsIBkiDD ORTw==
X-Gm-Message-State: AGi0PubVTEA23Glqz5x6yxiQxR/uui6/jPZpXGmYdxyRCLIWXxaZrV9/ +ABBYHqakJnuLbJPI/1B+8E3hwho4ZH1w9zj4CDKcftv
X-Google-Smtp-Source: APiQypL1yi5W47kBd0MaJxQXDSjIx4BHrYS1Nf9Ac+dfZAdJMNeG/gIzobMnuW2ibXcnx0cXAuJXhqWQJzzSD1Ff3+w=
X-Received: by 2002:a50:8e08:: with SMTP id 8mr5844353edw.153.1587172839545; Fri, 17 Apr 2020 18:20:39 -0700 (PDT)
MIME-Version: 1.0
References: <158700305191.15654.12038821597945409524@ietfa.amsl.com> <CAO0Djp1fYLXO+m65ho10=T9ijCAsVfyE12uP_4nXjdvxoF00Bw@mail.gmail.com> <CAMMESswNbLt6SCtA4zK_iCE95MhERad_ayF0NOpgW2+47-pKcg@mail.gmail.com>
In-Reply-To: <CAMMESswNbLt6SCtA4zK_iCE95MhERad_ayF0NOpgW2+47-pKcg@mail.gmail.com>
From: Rahul Jadhav <rahul.ietf@gmail.com>
Date: Sat, 18 Apr 2020 09:20:28 +0800
Message-ID: <CAO0Djp1nQLS=LJG+c3Fk3sXgaUzLz5TpvjPGQtHeHXwK=M3pfA@mail.gmail.com>
To: Alvaro Retana <aretana.ietf@gmail.com>
Cc: Routing Over Low power and Lossy networks <roll@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000004c60b905a3867916"
Archived-At: <https://mailarchive.ietf.org/arch/msg/roll/C3_p6nLsGczmAqBaOwa7aiDaRX4>
Subject: Re: [Roll] Fwd: New Version Notification for draft-ietf-roll-efficient-npdao-18.txt
X-BeenThere: roll@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Over Low power and Lossy networks <roll.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/roll>, <mailto:roll-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/roll/>
List-Post: <mailto:roll@ietf.org>
List-Help: <mailto:roll-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/roll>, <mailto:roll-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Apr 2020 01:20:43 -0000

Many thanks Alvaro for reviewing the changes.

I have made fixes for all the comments you made. (But I am not sure if I
have handled point 2 properly.)
So as not to push another version to datatracker till we have finalized
changes, I have pushed the changes to roll-wg repo, and hoping you could
please skim through the diff there.
https://htmlpreview.github.io/?https://github.com/roll-wg/efficient-route-invalidation/blob/master/diff-draft-ietf-roll-efficient-npdao.html

Thanks,
Rahul

On Sat, 18 Apr 2020 at 04:30, Alvaro Retana <aretana.ietf@gmail.com> wrote:

> On April 15, 2020 at 10:31:47 PM, Rahul Jadhav wrote:
>
>
> Rahul:
>
> Hi!
>
>
> This change seems ok.  However, please keep in mind that this document
> is already in the RFC Editor's queue...which in general means that we
> shouldn't be changing it too much/often.
>
>
> This is the new text you added:
>
>    Value 195 represents 'E' and 'A' bit in RPL Status to be set as per
>    Figure 3 of [I-D.ietf-roll-unaware-leaves] with the lower 6 bits with
>    value 3 indicating 'Moved' as per Table 1 of [RFC8505].
>
> I have a couple of comments:
>
> 1. [nit/minor] "'E' and 'A' bit in RPL Status to be set as per Figure
> 3"  The figure shows how the fields are placed in the RPL Status, not
> how/when to set the bits.
>
> 2. [minor] "with the lower 6 bits with value 3"  This is technically
> correct, but I had to read it a couple of times because the
> combination of "bits" and "value" makes it sound as if bit 3 may be
> set.
>
> 3. [major] Add a Normative reference to rfc8505.
>
>
> Suggestion>
>    An RPL Status of 195 represents the 'E' and 'A' bits set
>    ([I-D.ietf-roll-unaware-leaves]), and a Value of 3 ('Moved') as per
> Table 1
>    of [RFC8505].
>
>
> One more nit in Figure 3:  s/RPL  Status/RPL Status
>
>
>
> Thanks!
>
> Alvaro.
>
>
>
> > Since unaware-leaves to coming close to closure, I thought now is the
> time to
> > make the update to this draft (it was in cross-ref with unaware-leaves).
> > We have a value for RPL Status Moved in DCO. And it is 195. The update
> > explains this.
> >
> > Any feedback/comment is most appreciated.
> >
> > References:
> > 1. [Roll] Unaware-leaves - ND-Status and RPL-Status linkage
> > 2.
> https://mailarchive.ietf.org/arch/msg/roll/cxyoy9uUtWQoUsHc0ge8VUx-6KY/
> > 3. Why 195?
> https://github.com/roll-wg/efficient-route-invalidation/blob/master/why-RPL-Status-195.png
>