[Roll] [OPS-DIR] OPS-DIR Review of draft-ietf-roll-mpl-parameter-configuration-06

מנחם דודג' <menachemdodge1@gmail.com> Tue, 07 July 2015 06:36 UTC

Return-Path: <menachemdodge1@gmail.com>
X-Original-To: expand-draft-ietf-roll-mpl-parameter-configuration.all@virtual.ietf.org
Delivered-To: roll@ietfa.amsl.com
Received: by ietfa.amsl.com (Postfix, from userid 65534) id 388561A9128; Mon, 6 Jul 2015 23:36:47 -0700 (PDT)
X-Original-To: xfilter-draft-ietf-roll-mpl-parameter-configuration.all@ietfa.amsl.com
Delivered-To: xfilter-draft-ietf-roll-mpl-parameter-configuration.all@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 15FE81A901C for <xfilter-draft-ietf-roll-mpl-parameter-configuration.all@ietfa.amsl.com>; Mon, 6 Jul 2015 23:36:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.783
X-Spam-Level:
X-Spam-Status: No, score=-0.783 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_8BIT_HEADER=0.3, SPF_SOFTFAIL=0.665] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id teiikSxDBaGn for <xfilter-draft-ietf-roll-mpl-parameter-configuration.all@ietfa.amsl.com>; Mon, 6 Jul 2015 23:36:45 -0700 (PDT)
Received: from zinfandel.tools.ietf.org (zinfandel.tools.ietf.org [IPv6:2001:1890:123a::1:2a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 48CDE1A9127 for <draft-ietf-roll-mpl-parameter-configuration.all@ietf.org>; Mon, 6 Jul 2015 23:36:45 -0700 (PDT)
Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:33601) by zinfandel.tools.ietf.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.82_1-5b7a7c0-XX) (envelope-from <menachemdodge1@gmail.com>) id 1ZCMUl-0001eO-Ha for draft-ietf-roll-mpl-parameter-configuration.all@tools.ietf.org; Mon, 06 Jul 2015 23:36:45 -0700
Received: by wiwl6 with SMTP id l6so304346044wiw.0 for <draft-ietf-roll-mpl-parameter-configuration.all@tools.ietf.org>; Mon, 06 Jul 2015 23:36:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=K4wqPxFm80FC9gT5A9BXclZmsHpOM8kF+SP2RFdIm20=; b=HKRtEJImfxMhvjkP0i6epNYsPamInWUjAyw4Cd2tYfhdswA3YmkBIbGY6j0qXafk7k aHv8Jfo9R4JMCt+3bS78QNUvxCMrzMRA1pFfxn7P94qltZnCXd7m+mwHG6XholUNEKib l1yOJVRcUnCMuKaQrvcxKUEv9jg5UxAq/ZF+pxAjZd6y7CXNf22+ccqMBB6uc4Ch1POR k4J605GMDnw0FTcC+Mzty8ybzQmFUEOFz9y6Pi6K5wDfuL11pqLUuGfWF1BVyVKXLa8a pdzuo68Ay1S3IZiWd9PNjZrU7blKyUS7+zhqQ/KY6SeHT5uMBV9PWOrLZRojZ8Wztu/k HH7w==
MIME-Version: 1.0
X-Received: by 10.180.73.244 with SMTP id o20mr61645901wiv.31.1436250994311; Mon, 06 Jul 2015 23:36:34 -0700 (PDT)
Received: by 10.28.30.14 with HTTP; Mon, 6 Jul 2015 23:36:34 -0700 (PDT)
Date: Tue, 07 Jul 2015 09:36:34 +0300
Message-ID: <CAJ2jOhW=WqBq1WTG=8LnG7r0_3o1r2Oq67OR4K8DnkwOk_3yFQ@mail.gmail.com>
From: מנחם דודג' <menachemdodge1@gmail.com>
To: ops-dir@ietf.org, draft-ietf-roll-mpl-parameter-configuration.all@tools.ietf.org, Benoit Claise <bclaise@cisco.com>
Content-Type: multipart/alternative; boundary="f46d0435c06a5307ea051a433ef1"
X-SA-Exim-Connect-IP: 2a00:1450:400c:c05::232
X-SA-Exim-Rcpt-To: draft-ietf-roll-mpl-parameter-configuration.all@tools.ietf.org
X-SA-Exim-Mail-From: menachemdodge1@gmail.com
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on zinfandel.tools.ietf.org)
Resent-To: draft-ietf-roll-mpl-parameter-configuration.all@ietf.org
Resent-Message-Id: <20150707063645.48CDE1A9127@ietfa.amsl.com>
Resent-Date: Mon, 06 Jul 2015 23:36:45 -0700
Resent-From: menachemdodge1@gmail.com
Archived-At: <http://mailarchive.ietf.org/arch/msg/draft-ietf-roll-mpl-parameter-configuration.all@tools/aHA3rbKrBV4xvUuVwmYRU781ZSs>
Archived-At: <http://mailarchive.ietf.org/arch/msg/roll/k4fBoQOmIYErhue4PjwCs6kpo3w>
X-Mailman-Approved-At: Tue, 07 Jul 2015 02:19:37 -0700
Subject: [Roll] [OPS-DIR] OPS-DIR Review of draft-ietf-roll-mpl-parameter-configuration-06
X-BeenThere: roll@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: Routing Over Low power and Lossy networks <roll@ietf.org>
List-Id: Routing Over Low power and Lossy networks <roll.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/roll>, <mailto:roll-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/roll/>
List-Post: <mailto:roll@ietf.org>
List-Help: <mailto:roll-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/roll>, <mailto:roll-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jul 2015 06:36:47 -0000

Hello,

I have reviewed this document as part of the Operational directorate's
ongoing effort to review all IETF documents being processed by the IESG.
These comments were written with the intent of improving the operational
aspects of the IETF drafts. Comments that are not addressed in last call
may be included in AD reviews during the IESG review.  Document editors and
WG chairs should treat these comments just like any other last call
comments.

This document is for the Standards Track.

This document defines a DHCPv6 option that will allow a network to be
configured with a single set of "Multicast Protocol for Low power and Lossy
Networks" (MPL) parameters easily. This is needed because MPL has a set of
parameters to control its behavior which need to be identical for each MPL
forwarder in the MPL domain.

The MPL is defined in I-D ietf-roll-trickle-mcast


The document is quite readable.


Section 2.1 could be improved if for each parameter defined a reference
would be given to indicate where the parameter is defined. I found most of
them in: draft-ietf-roll-trickle-mcast-12 but for example, I'm not sure
what the Proactive_Forwarding flag is used for.

Section 4 discusses Security Considerations but I think that some phrases
in the paragraph are too general.
Example:  "other methods for security should be applied" does not indicate
what these methods are or where to look for them.
Another Example: "To protect attacks from outside of
the network, unneccessary DHCPv6 packets should be filtered on the
border router between the ROLL network and the Internet"  - what is meant
by "unnecessary DHCPv6 packets"?


NITS
====

Section 2.3 First Paragraph Second Sentence - Remove 'is'

OLD           ==> Note that there may be cases in which a node may fail is
to join a domain
SUGGEST ==> Note that there may be cases in which a node may fail to join a
domain

Section 2.3 Last Paragraph is not clear.

Perhaps the last sentence should read "In this case" (instead of "In the
case").


Section 2.6 - First Sentence - Not Clear

Is the update rate not to be more than twice the Information Refresh Time?
Not clear to me how many updates are allowed in an Information Refresh Time.

Should the word 'of' be replaced by 'the'.

"more often than twice *the* Information Refresh Time".

Suggest rephrasing this paragraph.


Otherwise I have no other issues with teh document.

Thank you kindly,
Menachem