IETF Logo Mail Archive

Re: [rtcweb] AD Review: draft-ietf-rtcweb-fec-07

Justin Uberti <juberti@google.com> Sat, 03 March 2018 05:51 UTC

Return-Path: <juberti@google.com>
X-Original-To: rtcweb@ietfa.amsl.com
Delivered-To: rtcweb@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 51AD8126C19 for <rtcweb@ietfa.amsl.com>; Fri, 2 Mar 2018 21:51:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.709
X-Spam-Level:
X-Spam-Status: No, score=-2.709 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZM7QwSy1X2Jq for <rtcweb@ietfa.amsl.com>; Fri, 2 Mar 2018 21:51:09 -0800 (PST)
Received: from mail-vk0-x22e.google.com (mail-vk0-x22e.google.com [IPv6:2607:f8b0:400c:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A545B124D37 for <rtcweb@ietf.org>; Fri, 2 Mar 2018 21:51:09 -0800 (PST)
Received: by mail-vk0-x22e.google.com with SMTP id y127so6991827vky.9 for <rtcweb@ietf.org>; Fri, 02 Mar 2018 21:51:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ciKaf6mTV/PDCIAk1B/JX3octmRSi+08VzVmRKwSLLg=; b=SevdZ04pi6HkRJ7ozJfZURFypl7S2luW9/QYABad7WyGHpxNlzcVv4bLuDY3gkHmQr hsBeV3ZAC9tExmc02G09Les68MKdsNI7iTDwgjDZG7FwoCSFNZ7ddCLh1U28+h1cHPH5 T/ASpzTM8BizRBxWZ/o1JFIyJkZTCyvd71/P72CVA2EInMOIQDCZQV8MqM3jgxBNW9JD t3m+BvSkO8v0DjsgAbS44HK2kD+P6mXWPDorXvETtWvebahSx1naXErV5F0yP5h3hnfd u1yJZ+pHyjMIUukkfi7aedIoQrlr5L/mV7q9/8xPawZoyF2T4dN/gss039aS+giMTGhv NjNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ciKaf6mTV/PDCIAk1B/JX3octmRSi+08VzVmRKwSLLg=; b=PlEoX/NlTaLay4w/QxeSowLdhOupXon0qUeFUTE+Hoya5KtSayb+RV1CvpCgxBlpKO bCsPpmbExEGAzZcpQa9oCe4PtromMcstQe2fk6lCO4UdeUSdpWI0JXTCFEWvD1xd+2XH 6JzfR0A8v3mCzNX9pNVZAz/Ay19gVXl/TXX9iGx48CP8AaIlRM+K6WUzQpNlZZduw7gZ O5WaqtUcYhTxCFPu5mgWB0f0ORer2lHC8vzjpVQpxa31ekRkZUPknqGq88R6pnvUQnOu yPhvrX/KG6u04r63UVnTHZtsoctDCaMYlXNQCYZQXvh71SoARFZ/KB8UlgN6penYCzCJ ReAg==
X-Gm-Message-State: APf1xPBXEdVzVK1IAcIodDSXT8ZbGxE4QRHgSylqiizHSQ/d2jHgfdBb sA3yy7GDZ5LvQruLb7v/0YoFGWsO/D4aJDE1bQ4OR//B
X-Google-Smtp-Source: AG47ELv+GmsFKMcEf1uNLzeQ0tsNzTJdhwIAgdqEc4ZRJZXLM6ByLPwUPFGaEeFsll6DxKr6pLYAkmPzShwWsT5hSXA=
X-Received: by 10.31.79.70 with SMTP id d67mr5439442vkb.9.1520056267979; Fri, 02 Mar 2018 21:51:07 -0800 (PST)
MIME-Version: 1.0
Received: by 10.31.167.206 with HTTP; Fri, 2 Mar 2018 21:50:47 -0800 (PST)
In-Reply-To: <CAOJ7v-3pY_qoFEoDT7qS+K6=D67NNMQ=+gV97yWr72VVpxZR3w@mail.gmail.com>
References: <b00a2399-699a-5633-ec61-1c819bae8093@nostrum.com> <CAOJ7v-3pY_qoFEoDT7qS+K6=D67NNMQ=+gV97yWr72VVpxZR3w@mail.gmail.com>
From: Justin Uberti <juberti@google.com>
Date: Fri, 02 Mar 2018 21:50:47 -0800
Message-ID: <CAOJ7v-2r8f=Z5R6wiU0WaK06XF4nNbANi76tPpZJCQg8bkpg3A@mail.gmail.com>
To: Adam Roach <adam@nostrum.com>
Cc: "rtcweb@ietf.org" <rtcweb@ietf.org>
Content-Type: multipart/alternative; boundary="001a114e0076e515f405667bad3b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtcweb/HmJdKoga6Q3Whccx0rzz7zyVkrE>
Subject: Re: [rtcweb] AD Review: draft-ietf-rtcweb-fec-07
X-BeenThere: rtcweb@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Real-Time Communication in WEB-browsers working group list <rtcweb.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtcweb/>
List-Post: <mailto:rtcweb@ietf.org>
List-Help: <mailto:rtcweb-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Mar 2018 05:51:11 -0000

Just published -08 which addresses all comments other than the one I
previously noted.

On Fri, Mar 2, 2018 at 8:52 AM, Justin Uberti <juberti@google.com> wrote:

>
>
> On Thu, Mar 1, 2018 at 3:40 PM, Adam Roach <adam@nostrum.com> wrote:
>
>> I have completed my AD review of draft-ietf-rtcweb-fec-07, and found only
>> very minor editorial nits, which should be treated as normal last call
>> comments.
>>
>
> Thanks for the review, and agree with the comments, with one exception.
> Should I publish a new version of the document with corrections, or wait
> for the document to progress further?
>
>>
>> Due to this document's close relationship with
>> draft-ietf-payload-flexible-fec-scheme, I plan to wait until both
>> documents are ready to progress before placing draft-ietf-rtcweb-fec into
>> IETF Last Call.
>>
>> Thanks to everyone who contributed to this document over its lifetime.
>>
>> Nits follow.
>>
>> ------------------------------------------------------------
>> ---------------
>> §2
>>
>> Since this document uses "should" in non-normative sentences, please use
>> the
>> RFC 8174 boilerplate.
>>
>> ------------------------------------------------------------
>> ---------------
>> §3.3
>>
>>    Some audio codecs, notably Opus [RFC6716] and AMR [RFC4867] support
>>
>> Insert comma before "support"
>>
>> ------------------------------------------------------------
>> ---------------
>> §4.1
>>
>>    against individual losses, with minimal overhead.  Note that as
>>    indicated above the built-in Opus FEC only provides single-frame
>>
>> Insert commas before and after the phrase "as indicated above"
>>
>> ------------------------------------------------------------
>> ---------------
>> §7
>>
>>    Implementations MAY support additional FEC mechanisms if desired,
>>    e.g.  [RFC5109].
>>
>> - Change the comma after "desired" to a semicolon.
>
>
> I think a comma is appropriate here; this is also consistent with how e.g.
> is used elsewhere in the document.
>
>
>> - Insert a comma after "e.g."
>>
>> ------------------------------------------------------------
>> ---------------
>>
>>
>> /a
>>
>> _______________________________________________
>> rtcweb mailing list
>> rtcweb@ietf.org
>> https://www.ietf.org/mailman/listinfo/rtcweb
>>
>
>

v2.23.0 | Report a Bug | By Email