Re: [rtcweb] [rtcweb-wg/jsep] Patch 1 (#862)

Adam Roach <adam@nostrum.com> Thu, 24 January 2019 21:48 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: rtcweb@ietfa.amsl.com
Delivered-To: rtcweb@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 49B7C1311CD for <rtcweb@ietfa.amsl.com>; Thu, 24 Jan 2019 13:48:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.679
X-Spam-Level:
X-Spam-Status: No, score=-1.679 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, HTML_MESSAGE=0.001, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N8OiSWvzHVNI for <rtcweb@ietfa.amsl.com>; Thu, 24 Jan 2019 13:48:37 -0800 (PST)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 96A991311D7 for <rtcweb@ietf.org>; Thu, 24 Jan 2019 13:48:37 -0800 (PST)
Received: from Svantevit.local (99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id x0OLmXVB087252 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 24 Jan 2019 15:48:35 -0600 (CST) (envelope-from adam@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1548366515; bh=kX789OzA+Y8M5+aBNcY1lZz5GvF9iRZinPA27YZ81h0=; h=Subject:To:References:From:Date:In-Reply-To; b=m09SIQDH+DgsdulPWIJaf6cBuEiBOep1/Fon6L8TKRJCu9nuhPX3qposdEtY5kaRg 3LJA/bwT7cJ0qtBR50qJcB6ZZzBZ1kqvZboyhLlxsvQmnh/bv2oeKn8Yh/WTEMvQ5S iw7EEaf4EZ72WmK6cSzx1q8/BoNcf4bwv6xfLDDk=
X-Authentication-Warning: raven.nostrum.com: Host 99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228] claimed to be Svantevit.local
To: Nils Ohlmeier <notifications@github.com>, "rtcweb@ietf.org" <rtcweb@ietf.org>
References: <rtcweb-wg/jsep/pull/862@github.com> <rtcweb-wg/jsep/pull/862/review/196258381@github.com>
From: Adam Roach <adam@nostrum.com>
Message-ID: <10f85b51-8ed3-3dcd-0d9b-a76d5625b7da@nostrum.com>
Date: Thu, 24 Jan 2019 15:48:28 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <rtcweb-wg/jsep/pull/862/review/196258381@github.com>
Content-Type: multipart/alternative; boundary="------------4B6EF78E004CE9163E50C74E"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtcweb/LrN9HCRbc1zndxffLR85rnHsOJg>
Subject: Re: [rtcweb] [rtcweb-wg/jsep] Patch 1 (#862)
X-BeenThere: rtcweb@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Real-Time Communication in WEB-browsers working group list <rtcweb.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtcweb/>
List-Post: <mailto:rtcweb@ietf.org>
List-Help: <mailto:rtcweb-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jan 2019 21:48:39 -0000

On 1/24/19 3:30 PM, Nils Ohlmeier wrote:
>
> *@nils-ohlmeier* approved this pull request.
>
> In general this looks like a reasonable path forward. Ideally I would 
> like to see some clarity added for trickle ICE implementations (see 
> comment below).
>
> ------------------------------------------------------------------------
>
> In draft-ietf-rtcweb-jsep.xml 
> <https://github.com/rtcweb-wg/jsep/pull/862#discussion_r250783916>:
>
> > @@ -1799,9 +1799,27 @@ candidate:1 1 UDP 1694498815 192.0.2.33 10000 typ host
>   
>             <t>For media m= sections, JSEP implementations MUST support
>             the "UDP/TLS/RTP/SAVPF" profile specified in
> -          <xref target="RFC5764"></xref>, and MUST indicate this
> -          profile for each media m= line they produce in an offer. For
> -          data m= sections, implementations MUST support the
> +          <xref target="RFC5764"></xref>. Implementations MUST indicate this
> +          profile for each media m= line they produce in an offer unless the
> +          media section contains only TCP candidates; if all candidates use TCP as a
>
> Ideally it would be a little bit more clear what this sentence 
> translates to for trickle ICE implementations. I would expect that a 
> trickle ICE implementation should start with "UDP/TLS/RTP/SAVPF". But 
> I can see how someone could mis-read this in the way he/she thinks the 
> implementation needs to wait for trickle ICE gathering to be finished 
> to decide which protocol to use in the m= line. And thus would void 
> the trickle ICE benefits for the purpose of obeying to this sentence.
>

Because trickling in RTCWEB always starts with no candidates in the SDP, 
I think the behavior here is reasonably clear (see section 5.2.1). That 
said, if you'd like to propose specific language to address your 
concern, please do so.

/a