Re: [rtcweb] AD Review: draft-ietf-rtcweb-fec-07

Justin Uberti <juberti@google.com> Fri, 02 March 2018 16:52 UTC

Return-Path: <juberti@google.com>
X-Original-To: rtcweb@ietfa.amsl.com
Delivered-To: rtcweb@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3B17012D72F for <rtcweb@ietfa.amsl.com>; Fri, 2 Mar 2018 08:52:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.01
X-Spam-Level:
X-Spam-Status: No, score=-2.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ucXzFsfZwefT for <rtcweb@ietfa.amsl.com>; Fri, 2 Mar 2018 08:52:43 -0800 (PST)
Received: from mail-vk0-x230.google.com (mail-vk0-x230.google.com [IPv6:2607:f8b0:400c:c05::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B2C8126DC2 for <rtcweb@ietf.org>; Fri, 2 Mar 2018 08:52:43 -0800 (PST)
Received: by mail-vk0-x230.google.com with SMTP id b65so6117841vka.2 for <rtcweb@ietf.org>; Fri, 02 Mar 2018 08:52:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2Q5yR25sj4U3HtJjOEjPkegFpwgAXfKm/lte3jNVayo=; b=EN4TJoOIB02+1aiDbbm6bWd6kjs0O6aBAzYRyzjpS07CS2DIpAnD2d/WD7+v3iZ3ji nl3lXiMICw70KcBFj3m9QVmAMb4qMRBMAJXZZBItcdywGI1LI10t/iAHRuiB/qcYBk3D VTaGnY/euX2Hd5F9j/Re2zBOpmJ7zMi+apCBfG+QXJLXVr+lEkLwjHHYXIDabOhr477y gOa6dguWkuSnNfPIPxVSuna3FAUTMY8xHWv+sKRu3gR+Ut5FrK0tyqq9PoWdS8KRsVYe 0cj9i4kTSKEPi3+I2K2Hv9E/lTjMfvkAK95s+H/2eY93zszNy73zF3Mdwi6RCoRoMLDB jNYQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2Q5yR25sj4U3HtJjOEjPkegFpwgAXfKm/lte3jNVayo=; b=NIrCF+XqpIrHaQ/ozwHfJ8dvEOn0+02dIWRiLnaeGRr6ZYcOxln1VLnH/9ebX1fVoH Y4qPekulAYV18wt+p93B/LbWYGF9QtlhmuV1bxcDfEjuM/px/b8b2ITW/mc5mpHiQ5Bl vuoqStEPisv3Dc4TL5jNDficjkWo4/QpP4FO2MwaO+B86MEOLwZNj5ZLKg/X5N9IQLFL 3rMq7F9za31gf+C8R4YFphbohd1aNQbH/XVQ0yPeJBY//5zibXHwGNTySK7g3wIhUY/B liJDU+E24FIFlvsUUIQT4evsGNRsVaR2F19BtDgnoD8kDiHU7yOdzUqoS1M97Uuigk4I 9yGA==
X-Gm-Message-State: AElRT7HP5eIkPKuYc/tbCMkDGs04wVkcrOlakXQ7UO0R9BG7x8e6qFBf 9BwxIllzYKF7IIPBF72WlaEVjjyrj7qC8A6HwysvLQ==
X-Google-Smtp-Source: AG47ELvVm9WBiOhawyRLb8reMu2usU4gHMr6sAaTn3xb9Hpr3ydws7Gk2WHd0l+oWutLp1dNl6wOLHKmCKMkC5lELhI=
X-Received: by 10.31.231.5 with SMTP id e5mr3429978vkh.39.1520009561406; Fri, 02 Mar 2018 08:52:41 -0800 (PST)
MIME-Version: 1.0
Received: by 10.31.167.206 with HTTP; Fri, 2 Mar 2018 08:52:20 -0800 (PST)
In-Reply-To: <b00a2399-699a-5633-ec61-1c819bae8093@nostrum.com>
References: <b00a2399-699a-5633-ec61-1c819bae8093@nostrum.com>
From: Justin Uberti <juberti@google.com>
Date: Fri, 02 Mar 2018 08:52:20 -0800
Message-ID: <CAOJ7v-3pY_qoFEoDT7qS+K6=D67NNMQ=+gV97yWr72VVpxZR3w@mail.gmail.com>
To: Adam Roach <adam@nostrum.com>
Cc: "rtcweb@ietf.org" <rtcweb@ietf.org>
Content-Type: multipart/alternative; boundary="94eb2c094c32f7442d056670cd22"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtcweb/vgixVZTErNX7Lb3f0QSkXa_gg-g>
Subject: Re: [rtcweb] AD Review: draft-ietf-rtcweb-fec-07
X-BeenThere: rtcweb@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Real-Time Communication in WEB-browsers working group list <rtcweb.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtcweb/>
List-Post: <mailto:rtcweb@ietf.org>
List-Help: <mailto:rtcweb-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Mar 2018 16:52:45 -0000

On Thu, Mar 1, 2018 at 3:40 PM, Adam Roach <adam@nostrum.com> wrote:

> I have completed my AD review of draft-ietf-rtcweb-fec-07, and found only
> very minor editorial nits, which should be treated as normal last call
> comments.
>

Thanks for the review, and agree with the comments, with one exception.
Should I publish a new version of the document with corrections, or wait
for the document to progress further?

>
> Due to this document's close relationship with
> draft-ietf-payload-flexible-fec-scheme, I plan to wait until both
> documents are ready to progress before placing draft-ietf-rtcweb-fec into
> IETF Last Call.
>
> Thanks to everyone who contributed to this document over its lifetime.
>
> Nits follow.
>
> ------------------------------------------------------------
> ---------------
> §2
>
> Since this document uses "should" in non-normative sentences, please use
> the
> RFC 8174 boilerplate.
>
> ------------------------------------------------------------
> ---------------
> §3.3
>
>    Some audio codecs, notably Opus [RFC6716] and AMR [RFC4867] support
>
> Insert comma before "support"
>
> ------------------------------------------------------------
> ---------------
> §4.1
>
>    against individual losses, with minimal overhead.  Note that as
>    indicated above the built-in Opus FEC only provides single-frame
>
> Insert commas before and after the phrase "as indicated above"
>
> ------------------------------------------------------------
> ---------------
> §7
>
>    Implementations MAY support additional FEC mechanisms if desired,
>    e.g.  [RFC5109].
>
> - Change the comma after "desired" to a semicolon.


I think a comma is appropriate here; this is also consistent with how e.g.
is used elsewhere in the document.


> - Insert a comma after "e.g."
>
> ------------------------------------------------------------
> ---------------
>
>
> /a
>
> _______________________________________________
> rtcweb mailing list
> rtcweb@ietf.org
> https://www.ietf.org/mailman/listinfo/rtcweb
>