Re: [Technical Errata Reported] RFC5884 (5085)

"Carlos Pignataro (cpignata)" <cpignata@cisco.com> Sat, 12 August 2017 02:53 UTC

Return-Path: <cpignata@cisco.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0AF041324C5 for <rtg-bfd@ietfa.amsl.com>; Fri, 11 Aug 2017 19:53:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.52
X-Spam-Level:
X-Spam-Status: No, score=-14.52 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Itb2sJSHZMKA for <rtg-bfd@ietfa.amsl.com>; Fri, 11 Aug 2017 19:53:50 -0700 (PDT)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C92A31321B9 for <rtg-bfd@ietf.org>; Fri, 11 Aug 2017 19:53:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=7744; q=dns/txt; s=iport; t=1502506429; x=1503716029; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=o8onjkkbrR1J8S1zsq9akLs3HdIty68nt6q+12pmxBI=; b=OwxckNOwuf51ryyScsgoiCWdH8fIE3OmygzDcxwCykPuttfZHlvTNdOY 2lEYbOsq5LcvEo8BAZuimtsox6Vl05Vyn7b8MveytLtcsVYVYiH7SYd4Z uEJG5grVo5uI5KLuosWXqIt6G1CP+bTf4J0eZs46UNgB4p+q0DGYqkOCv M=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0BIAQC0bI5Z/4oNJK1dGQEBAQEBAQEBAQEBBwEBAQEBg1qBHFwHjgqQDYFMIog2jWEOggSFRwIahFw/GAECAQEBAQEBAWsohRgBAQEBAgEjETMSBQsCAQgYAgImAgICHxEVEAIEDgWKFwMNCKsxgiaHNg2EIQEBAQEBAQEBAQEBAQEBAQEBAQEBAR2BC4IdggKBTIFjKwuCcYE8gRuBZjaDEzCCMQWJeI4Mh2Y8Ao9EhHSCD4VdimiMMYlhAR84gQp3FUkSAYUQgXd2hwErgQWBDwEBAQ
X-IronPort-AV: E=Sophos;i="5.41,361,1498521600"; d="scan'208";a="284717534"
Received: from alln-core-5.cisco.com ([173.36.13.138]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 12 Aug 2017 02:53:48 +0000
Received: from XCH-RTP-003.cisco.com (xch-rtp-003.cisco.com [64.101.220.143]) by alln-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id v7C2rmYe023871 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Sat, 12 Aug 2017 02:53:48 GMT
Received: from xch-rtp-020.cisco.com (64.101.220.160) by XCH-RTP-003.cisco.com (64.101.220.143) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 11 Aug 2017 22:53:47 -0400
Received: from xch-rtp-020.cisco.com ([64.101.220.160]) by XCH-RTP-020.cisco.com ([64.101.220.160]) with mapi id 15.00.1210.000; Fri, 11 Aug 2017 22:53:47 -0400
From: "Carlos Pignataro (cpignata)" <cpignata@cisco.com>
To: Greg Mirsky <gregimirsky@gmail.com>
CC: Jeff Haas <jhaas@pfrc.org>, "kireeti@juniper.net" <kireeti@juniper.net>, Tom Nadeau <tnadeau@lucidvision.com>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "Reshad Rahman (rrahman)" <rrahman@cisco.com>, Alia Atlas <akatlas@gmail.com>
Subject: Re: [Technical Errata Reported] RFC5884 (5085)
Thread-Topic: [Technical Errata Reported] RFC5884 (5085)
Thread-Index: AQHTEsasU87guosjHUWva6qlHRtDoKJ/rxSAgAAJTYCAAJGPgA==
Date: Sat, 12 Aug 2017 02:53:47 +0000
Message-ID: <FDD595D5-7415-40F2-AEA3-27537A5BEC8D@cisco.com>
References: <20170811053550.27303B81263@rfc-editor.org> <20170811173930.GJ24942@pfrc.org> <CA+RyBmWYRAT3g=zCN+ot9mFDYuPCOGCwyPQJp-+9AfA6oJjttA@mail.gmail.com>
In-Reply-To: <CA+RyBmWYRAT3g=zCN+ot9mFDYuPCOGCwyPQJp-+9AfA6oJjttA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.118.116.133]
Content-Type: text/plain; charset="utf-8"
Content-ID: <448F9AB1F565BC4F96166EA0D78300C2@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/ATeLnc8xdrsal2vzxQtvfPg_mKI>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Aug 2017 02:53:52 -0000

Greg,

> On Aug 11, 2017, at 2:12 PM, Greg Mirsky <gregimirsky@gmail.com> wrote:
> 
> Re-sending to the corrected list (apologies for duplicates).
> 
> Dear All,
> I suggest to reject this proposal. The current text is clear and the mechanics of bootstrapping BFD session over MPLS LSP is well understood - remote peer MUST start sending BFD control packets first and BFD peer MAY send Echo Reply with its Local Discriminator as value in BFD Discriminator TLV.
> 

This seems to repeat the text in 5884 without explaining why you feel a particular interpretation is the correct technical one.

The text you include:
	“MAY send Echo Reply with its Local Discriminator as value in BFD Discriminator TLV”

suffers from the ambiguity that this Errata is trying to clarify. Which one is it?
* (MAY send Echo Reply with its Local Disc)
* (MAY send Echo Reply), with its Local Disc.

The actual text is:
   The egress LSR MAY respond with an LSP Ping Echo
!  reply message that carries the local discriminator assigned by it for
   the BFD session. 

And NOT:
   The egress LSR MAY respond with an LSP Ping Echo
!  reply message, which carries the local discriminator assigned by it for
   the BFD session. 


Based on restrictive versus non-restrictive clause, I feel it is correct to accept the errata.


And by the way, RFC 5884 is not say what happens if the LSP Ping Reply has a different discriminator value!

Thanks,

Carlos.

> Regards,
> Greg
> 
> 
> On Fri, Aug 11, 2017 at 10:39 AM, Jeffrey Haas <jhaas@pfrc.org> wrote:
> [Note that I have adjusted the addresses in the headers to try to catch the
> RFC authors' current accounts.]
> 
> 
> The 5884 interop issue keeps bubbling up.  Balaji submitted an errata, which
> provides us with a good place to start technical discussion.
> 
> Please note I also spent some time off-list discussing this errata with
> Balaji.
> 
> 
> On Thu, Aug 10, 2017 at 10:35:50PM -0700, RFC Errata System wrote:
> > Section: 6
> >
> > Original Text
> > -------------
> > The egress LSR MAY respond with an LSP Ping Echo
> > reply message that carries the local discriminator assigned by it for
> > the BFD session.
> >
> > Corrected Text
> > --------------
> > The egress LSR MUST respond with an LSP Ping Echo reply message that
> > MAY carry the local discriminator assigned by it for the BFD session.
> >
> >
> > Notes
> > -----
> > It is not clear from the original text which of the following is optional:
> >   -  The egress MUST send a reply, but the discriminator in the reply is optional
> >   -  The reply itself is optional
> >
> > Technically, the reply cannot be optional, because the egress needs to report LSP-Ping verification status to the ingress.
> >
> > The proposed text recommends to include BFD discriminator in the reply. This was the intent of the original text.
> 
> My opinion follows:
> 
> In section 6 -
> 
> :    On receipt of the LSP Ping Echo request message, the egress LSR MUST
> :    send a BFD Control packet to the ingress LSR, if the validation of
> :    the FEC in the LSP Ping Echo request message succeeds.  This BFD
> :    Control packet MUST set the Your Discriminator field to the
> :    discriminator received from the ingress LSR in the LSP Ping Echo
> :    request message.  The egress LSR MAY respond with an LSP Ping Echo
> :    reply message that carries the local discriminator assigned by it for
> :    the BFD session.  The local discriminator assigned by the egress LSR
> :    MUST be used as the My Discriminator field in the BFD session packets
> :    sent by the egress LSR.
> 
> In the text above, I consider it quite clear that the receipt of the BFD
> packet contains sufficient state to bring up the BFD session.  The receipt
> of the same Discriminator in the LSP Ping Echo Reply is optional.
> 
> This makes sense partially because the reply may be dropped and we want the
> BFD session to come up as fast as possible.
> 
> The point of contention appears to be what to do if we *never* get such
> replies.  It's worth pointing out additional text in RFC 5884, section 3.2.
> 
> :    Hence, BFD is used in conjunction with LSP Ping for MPLS LSP fault
> :    detection:
> :
> :       i) LSP Ping is used for bootstrapping the BFD session as described
> :          later in this document.
> :
> :      ii) BFD is used to exchange fault detection (i.e., BFD session)
> :          packets at the required detection interval.
> :
> :     iii) LSP Ping is used to periodically verify the control plane
> :          against the data plane by ensuring that the LSP is mapped to
> :          the same FEC, at the egress, as the ingress.
> 
> iii above reminds us that the LSP may be torn down because LSP Ping fails.
> Thus, it seems problematic that we do not get a reply ever.
> 
> However, with the BFD session in the Up state, we have information proving
> that the LSP is up.  Thus we have contradictory intent.
> 
> ---
> 
> My opinion is that the MAY in the RFC 5884 procedures is intended to have
> the BFD session come up by the most expedient means.  I do not believe the
> likely intent was to say "don't send Echo Reply".  Among other things, that
> seems contrary to the intent of the general LSP Ping procedures.
> 
> Having given my personal observations, we now get to the business of the
> Working Group: Debating intent and related text.
> 
> -- Jeff
> 
> 

—
Carlos Pignataro, carlos@cisco.com

“Sometimes I use big words that I do not fully understand, to make myself sound more photosynthesis."