Yangdoctors last call review of draft-ietf-bfd-stability-08

Ebben Aries via Datatracker <noreply@ietf.org> Mon, 22 March 2021 00:10 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: rtg-bfd@ietf.org
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id E3D0E3A0C82; Sun, 21 Mar 2021 17:10:12 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ebben Aries via Datatracker <noreply@ietf.org>
To: <yang-doctors@ietf.org>
Cc: draft-ietf-bfd-stability.all@ietf.org, last-call@ietf.org, rtg-bfd@ietf.org
Subject: Yangdoctors last call review of draft-ietf-bfd-stability-08
X-Test-IDTracker: no
X-IETF-IDTracker: 7.27.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161637181289.17673.15670328442520728650@ietfa.amsl.com>
Reply-To: Ebben Aries <ebben.aries@nokia.com>
Date: Sun, 21 Mar 2021 17:10:12 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/AUdr_cGXe52rt4hLEgOBcOM-5QY>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Mar 2021 00:10:13 -0000

Reviewer: Ebben Aries
Review result: Ready with Nits

One of the simpler YD reviews since this draft contains only a single module
with a single r/o leaf augment to various other BFD module nodes.

1 module in this draft:
- ietf-bfd-stability@2021-02-24.yang

YANG compiler errors or warnings (pyang 2.4.0, yanglint 1.10.17, confdc 7.2.3.4)
- warning: RFC 8407: 3.1: The IETF Trust Copyright statement seems to be missing
  - Minor issue just due to slight wording adjustment from copyright info
    normally used in the draft/RFC itself
    https://trustee.ietf.org/documents/trust-legal-provisions/tlp-5/


Module ietf-bfd-stability@2021-02-24.yang:
- Contact information should follow formatting seen in other published
  modules.  Just some minor cleanup/readjustments here.
- Various augments will augment the respective 'session-statistics' container
  however for 'bfd-lag:member-links/micro-bfd-ipv4',
  'bfd-lag:member-links/micro-bfd-ipv6' and 'bfd-mpls:sessions' these augments
  sit in parallel to that container.  Is there any reason this is not
  consistent?


General comments on the draft/modules:
- Section 7.2: It is stated the document registers "2" YANG modules when it is
  infact only a single module

Overall, just minor nits and view as ready from a YANG doctor review
standpoint once the above is addressed