Re: Tsvart last call review of draft-ietf-bfd-multipoint-16

"Carlos Pignataro (cpignata)" <cpignata@cisco.com> Tue, 26 June 2018 05:17 UTC

Return-Path: <cpignata@cisco.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AAA47130EC6; Mon, 25 Jun 2018 22:17:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.509
X-Spam-Level:
X-Spam-Status: No, score=-14.509 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rzQzbGI4ZEcN; Mon, 25 Jun 2018 22:17:23 -0700 (PDT)
Received: from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 20617130E9B; Mon, 25 Jun 2018 22:17:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=13044; q=dns/txt; s=iport; t=1529990243; x=1531199843; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=GunRYBQ79cwg8f4zHigWGKMRBSGtDmraRnDJnIneiXU=; b=LW7gFWTP7hOHTgMUckcG76oaXOabi+jFLy985+pyosajhjHnDSo6uD+1 sNA8SuuMTcOfsWFm+7zytG2GK9Kn0mGxKlW0B6h/rra7KBOtdED3wU+O9 MsMA2lqSW80ZC64A5RSB7BmMmK+tArBqCOSiQ3X0insFww9xqdiSOJlfI M=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0C0AACWyzFb/4UNJK1dGQEBAQEBAQEBAQEBAQcBAQEBAYJTVwEBAQEhYn8oCoNviASMQoFliE2HX4UGgXoLI4RJAheCdiE0GAECAQEBAQEBAm0cDIUpBiNWEAIBCD8DAgICHxEUEQIEDgWDJQGBG0wDFQ+sboIcH4ZxDYEsgRUFiGyBVj+BDgEnDIJcglZCAQECAYReMYIkApFVhy8sCQKFfIYKgwmBQIQGiAOKJU2GVQIREwGBJB04gVJwFWUBgj6CIxeIWYU+bwEBjlaBGgEB
X-IronPort-AV: E=Sophos;i="5.51,273,1526342400"; d="scan'208,217";a="415295645"
Received: from alln-core-11.cisco.com ([173.36.13.133]) by rcdn-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2018 05:17:21 +0000
Received: from XCH-RTP-017.cisco.com (xch-rtp-017.cisco.com [64.101.220.157]) by alln-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id w5Q5HKHC005023 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 26 Jun 2018 05:17:21 GMT
Received: from xch-rtp-020.cisco.com (64.101.220.160) by XCH-RTP-017.cisco.com (64.101.220.157) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 26 Jun 2018 01:17:20 -0400
Received: from xch-rtp-020.cisco.com ([64.101.220.160]) by XCH-RTP-020.cisco.com ([64.101.220.160]) with mapi id 15.00.1320.000; Tue, 26 Jun 2018 01:17:20 -0400
From: "Carlos Pignataro (cpignata)" <cpignata@cisco.com>
To: Greg Mirsky <gregimirsky@gmail.com>
CC: Bob Briscoe <ietf@bobbriscoe.net>, "draft-ietf-bfd-multipoint.all@ietf.org" <draft-ietf-bfd-multipoint.all@ietf.org>, "tsv-art@ietf.org" <tsv-art@ietf.org>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, IETF list <ietf@ietf.org>
Subject: Re: Tsvart last call review of draft-ietf-bfd-multipoint-16
Thread-Topic: Tsvart last call review of draft-ietf-bfd-multipoint-16
Thread-Index: AQHT/HRExw3CBwk62EGoYxhzIgZ7z6RyZA6A
Date: Tue, 26 Jun 2018 05:17:20 +0000
Message-ID: <1A5DF3AA-ED83-4656-AB1B-E8CC9E721CE1@cisco.com>
References: <152694840016.8083.12174100605609215107@ietfa.amsl.com> <CA+RyBmVmsFxmiDTLLS5Jz+q_Fgb3O7QcsbMJwFUxbh-+9XxYWQ@mail.gmail.com> <1afa9af2-9fce-1588-ca09-cd39f1122688@bobbriscoe.net> <CA+RyBmVo2B6bh=j6a32xOcq8EwTGceuDeifgEGKBVRRwMi9HGQ@mail.gmail.com>
In-Reply-To: <CA+RyBmVo2B6bh=j6a32xOcq8EwTGceuDeifgEGKBVRRwMi9HGQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.118.116.133]
Content-Type: multipart/alternative; boundary="_000_1A5DF3AAED834656AB1BE8CC9E721CE1ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/FfM__SQ_OJ7Rej-AUNVEf-UFOk4>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2018 05:17:26 -0000

Greg,

Please find one late follow-up inline.

On Jun 4, 2018, at 10:23 PM, Greg Mirsky <gregimirsky@gmail.com<mailto:gregimirsky@gmail.com>> wrote:

8/ Incremental deployment

Section 4.4.1.  "New State Variable Values" defines bfd.SessionType =
PointToPoint as well as a couple of Multipoint alternatives. Presumably this
spec does not require all existing PointToPoint systems to support this state
value. Is the implication that only Multipoint systems that happen to be in
PointToPoint mode should use this state?
GIM>> You're aboultely right, existing implementations of BFD don't need to support bfd.SessionType variable. Only implementations that support the base BFD, single-hop or multi-hop, and this specification, mpBFD, should support bfd.SessionType and set it to PointToPoint value when BFD is in single-hop or multi-hop mode. When in mpBFD mode, bfd.SessionType will be set to either MultipointHead or MultipointClient.
[BB]: Doesn't something need to be written (or referenced) to clarify all this? AFAIR, this spec. never made clear that multipoint is a fork in implementations.
GIM2>> And so is S-BFD. (Note, bfd.SessionType introduced in RFC 7880 S-BFD but missed to define PointToPoint value).


I do not believe the question was whether S-BFD or any other protocol followed the behavior. It’s a question about this document.

For correctness, S-BFD (RFC 7880) did not miss to define PointToPoint value — it chose not to.

Back to this document, the question was whether something needs to be written to clarify.

The text in rev -18 still needs clarification. It reads:

https://tools.ietf.org/html/draft-ietf-bfd-multipoint-18#section-5.4.1

      bfd.SessionType

         The type of this session as defined in [RFC7880].  Newly added
         values are:

            PointToPoint: Classic point-to-point BFD, as described in
            [RFC5880].

            MultipointHead: A session on the head responsible for the
            periodic transmission of multipoint BFD Control packets
            along the multipoint path.

            MultipointTail: A multipoint session on a tail.

         This variable MUST be initialized to the appropriate type when
         the session is created.


Basically, the variable MUST be initialized, PointToPoint is used for RFC 5880, and this text effectively renders every implementation of RFC 5880 non compliant.

Could you please add some clarifying text that codifies what you described above (i.e., existing p2p traditional BFD only do not need to set the variable)

Thanks!


—
Carlos Pignataro, carlos@cisco.com<mailto:carlos@cisco.com>

“Sometimes I use big words that I do not fully understand, to make myself sound more photosynthesis."