AD review of draft-ietf-bfd-multipoint-14

Martin Vigoureux <martin.vigoureux@nokia.com> Tue, 17 April 2018 15:06 UTC

Return-Path: <martin.vigoureux@nokia.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 09D491242F7; Tue, 17 Apr 2018 08:06:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IPle5OxCpMWe; Tue, 17 Apr 2018 08:06:15 -0700 (PDT)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on0720.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::720]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 15BAD1200C5; Tue, 17 Apr 2018 08:06:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KFNdYXHOnny4aGWV9zz6Qok3CX6/vC5Vb5TCT/dVJK0=; b=qIKzvYjFOpm/ng+oP4lXAkyjvJHwuEjnwX2bZN9ZYT4njVvxfeT72oqrDm3DCKm5KX+WYDJRQxcb6B9rjYQo4RWNyIgUopbOH06mQ371xzQU1ML/fGJUOSGWZsrG0OCjFjn+c0FrxZWNpwde1B3rR5UNSo8LCkagaW/Wz4mDkV0=
Received: from [IPv6:2a01:cb04:a1a:4c00:f443:6b8b:e1f8:5e65] (2a01:cb04:a1a:4c00:f443:6b8b:e1f8:5e65) by VI1PR0701MB2141.eurprd07.prod.outlook.com (2603:10a6:800:30::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.8; Tue, 17 Apr 2018 15:06:12 +0000
From: Martin Vigoureux <martin.vigoureux@nokia.com>
Subject: AD review of draft-ietf-bfd-multipoint-14
To: draft-ietf-bfd-multipoint@ietf.org
Cc: rrahman@cisco.com, bfd-chairs@ietf.org, rtg-bfd@ietf.org
Message-ID: <ef98cd8b-2e3a-40bc-42e9-82cb64d1f87d@nokia.com>
Date: Tue, 17 Apr 2018 17:06:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Originating-IP: [2a01:cb04:a1a:4c00:f443:6b8b:e1f8:5e65]
X-ClientProxiedBy: VI1PR0602CA0018.eurprd06.prod.outlook.com (2603:10a6:800:bc::28) To VI1PR0701MB2141.eurprd07.prod.outlook.com (2603:10a6:800:30::10)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:VI1PR0701MB2141;
X-Microsoft-Exchange-Diagnostics: 1; VI1PR0701MB2141; 3:7AjVkarSG0xGPGE06hv5ktH2O8qFsMS+hNWz9PjrAQDIHnKTLR1q/im2H6ayAmTNBKcozECvhv6u6INDs8drM2iOqTOz/+D5AIZQlT97dDZ7lzqdnKVY3+NjAgly9z3stxGQNMx6bQ1QEuK9lNwq0DrrN8eZU9nOVcOwnUy6v6IyinZ40jH7Zre6dvgnSFlZwNnF7brWXR9wlN1y2LE1KD9MKD6tmZoKdcpzEBwzwBH/g66qY2CtmzhJETIt64Gf; 25:4FN0RWH/3qaYiCuhWwDVzYoKDPRVqDIf3V2Gbr1qutog63Ie+tpSEeSAhtXFLbPZGhsLgx06WxLJFixjdh0WR+Vf+BG7a/gLUH5pAfQS/5eg4pQQlbH0lFc3e0hDjscaIFiGIejM5Cpy8Te8rswMl8/qtVI2mFVfJ6MRDwwYmHl4wV3CyESibb0lrQfceiP+mfruH4aHij7KRLAwRRduel+TOAMoYvmENQ5U+B0wR6E8TXIqAZclRansLYS26o9rQo+qzWhHi04/vv7x/Pzhmkv37h6K9xhwR/XZ7B9R0v1WPuTbDAqyL0IyOqt+Qb+/y9XN2iLf2acqjjMH9nolbg==; 31:LQNxFCIqh0nY2HxI9Uc4tZI8ZeRZH/hnPGvnaPQiqSGcj9Hr7bgxyNBdqrqohUkLkTBO0ThbHfwsiBpUW/Ygbes23o9aIfnIm/CRcz+463x5bnW6sCwt9aZ1S2LGi1cIXsskdrpRuYgavvhKATV8fmewnYNnfn+2ufFbroLpuLxeZbrgAGkuU+YsVmaSZPhZSOTNkBb0kYt+d8y2f7GAizo8edaojsLKRWAqwkqVeCk=
X-MS-TrafficTypeDiagnostic: VI1PR0701MB2141:
Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=martin.vigoureux@nokia.com;
X-Microsoft-Exchange-Diagnostics: 1; VI1PR0701MB2141; 20:GnbDsInrExkVtmH5icJRAXCr9KqGaWBSj0CauBzGmhJ+rC3WHYyCSw0CR5WJHN10CImq8nsv5yLOUTtHZcgvCKqeZX6jpLV6YTOugTOVZjXyuLUPnHEit1ImUtl3WteK2/bM2VEpINT13yc1iWJ0ERu8pNGqCau7ZD54mPorBCBmRlC2TnPEP521vLIt9iNGlBZ89tuTIMu7yGuY8eLVaU7w6CqbqPCb9WS1rMbq2H8PGhCceUhnRZtvkoKqcsnLJUEygXG0LXSRW5tThti8vx5mQ4RehkxGU8yM2TMSHpMrQhTkHVlPAuHJVPBpAMsWNq3NDyjBQM559JgyZetjuUYjADKLAqhZSH9m9blg+TvWR212S4gIPcwSE/TrNsy4A8J+FCVotr6vjJ3GOOpy2BK4R4Q3NO+24nEsYxjTAcYnR+cyKcI0+byu9DIe29c2Vnpj69ydofI3iOUHB4aSY93Y2YtO4H8ayZpGFjk11bVNuyQEV9t7+ezcqHnituIb; 4:QQDxzk25VOz+5DKzv7nban4pDbZT6s/t/9mDkSbCqq2rp+pUQoL80hf/2PbQR4puolzxtdz6n7Zgcl0GmMeS88pi3xnIRep/C+t2/rTmy6D1PFarOjIQRL+so0Ve76vPo9Soh1SSpgyAdk/Sb2dqshxRMqjYfyV+jY4j4P5ezCHKuPM5KxOKghauwDUg4byoJW5kwKLdEMvGKyo4GgabBSGwJkDFIjaiRfotBnqaP2mUWaliQ4zNj7IUQAlBnRayJz1WP4QlRnzC0avxtFtVzQ==
X-Microsoft-Antispam-PRVS: <VI1PR0701MB214108AF93050AD5696CE80F8CB70@VI1PR0701MB2141.eurprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231232)(11241501184)(806099)(944501359)(52105095)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR0701MB2141; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0701MB2141;
X-Forefront-PRVS: 0645BEB7AA
X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(396003)(346002)(39380400002)(366004)(54094003)(199004)(189003)(25786009)(86362001)(3260700006)(4326008)(81166006)(97736004)(8936002)(8676002)(81156014)(50466002)(6306002)(31686004)(2361001)(2351001)(6116002)(316002)(230700001)(105586002)(64126003)(36756003)(31696002)(58126008)(345774005)(2906002)(6486002)(65826007)(5660300001)(59450400001)(7736002)(305945005)(1706002)(2486003)(44832011)(386003)(46003)(6666003)(476003)(106356001)(67846002)(16526019)(186003)(68736007)(52116002)(53936002)(52396003)(65956001)(52146003)(478600001)(2616005)(486006)(966005)(6916009)(47776003)(65806001)(23676004); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR0701MB2141; H:[IPv6:2a01:cb04:a1a:4c00:f443:6b8b:e1f8:5e65]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
Received-SPF: None (protection.outlook.com: nokia.com does not designate permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: 1;VI1PR0701MB2141;23:AdO4hv3MR60CavjUG6+6JYib13JDwzilIs70Z4Cl8tkoZqE/r+IzJM2nqAxvEyB5ih3unBj6H+Qw0wHa1v9k0vYq+/91wPfpQdwVtjMiZ1FyD2Gnia/DBydT3//QzxkiObapKLb+pCfmIMyMNQc5v+oofAH9snj8pn3yvh+ILUCNAXJRbC+SQA41KWLw4bchvz9muvAnDiY2G8o7GBrTg5OPPhy2jbGoRPmsHvbfi6BYnLFs4RbKoL4S3Tk/VDXsEW7PWLPR3vhLzsItPYJHkrfAwU2n00pjaHeChGW2El/RiGEMiMTk/eePAglUx9bZoDeO5YZ1dK82qmBnfCXxG9pdPHm2+DubWcH+Rk1QosBF4vFsFvGPJZrWAZHSqocikBwBwDyLWmactKzlMkmGp6VcvnNM3Z7cshDfTnYfuaWMg9SRCwL33pho+UmEC3PECkPaPHqZf5hs8uVu2Z9wMkFlGnS+rkl6QAO08dtzUh1ped4uOYEwz0+NbGhcukm5+AKVby+JuQKQa6ibVDeRVb+11cEzjqaTyLo5Q17Zg5NxmjK5AUhtrFBx1iHfyTpOYJkiU4sBlhZCjrWNe0BSTlQRGJiU/X0t1yLGswzka5JY6F0LCpexTwD6MRmq1t2rnfWBANNV+E1uVK45/FgJjvU0tFKRP2td2YpwczBDcPC0qE9DRnZ4u0dMAYnHAoXkEkJMT4OBbmZVNJcQKQmNMORyR3uq7ceEHuzmpbvbs1xVA0zrPwwWvMDilft0M7WLQI7XQ0Cjm0PHdiQ7ZJHHKhGBuV4B+2X8MvjOEfgcmtfIcRjuNx9KIak/nFmdvhZ1VBzTuO3j9o1Nlr+SfELZfCflXNTpz4Z4PE6a2vgoHfURl2r+H5MpmKTHZdN8LMAEzf107IT8DiJUg5YIxOnpiUngLFJIBLNTJWKnN7BVKjnz4yK8NA5SCUJmIxfnxzL39FGK/y0H9TDtdClVJ+pKUz8lSiZAvd0sk+B1bPjwZh/uczWXCFuPBXnx7UZSgLw+GMss11oSKZ+DOemTBOdVNMLV/p8KsIraQkmgrLIVWksbL3o+JUC0sD1ZShUht1CvU+MkV/FYXUj0N+SoqVAUUXlxkmbOU1KHx40khubTEsQ+y2Go9ywG1j0Zk0G/I5Bv5Z4IXeB3ka3C766Qc7lk++1AzI2lBt8OYYsZLoecx6wsERj74f/e8uo3l3TtrhsxtHTVJx977QV0PtbMXil9mssciyxx0MSAbC+RuM2Fa1uAZ1Z2ipi8hTk/77oyapYj9vZfoPxVp/jFxJy8gFV5xNWvih347tWw18tDzINqkQ8H/Y0s1ESYAkZV6rUL0IiHfpDYdBdqsGI7c0KqUKMc3tSrfqzd8bvanzGKfNt+yqcJZVkvatIE2NXeqPQf1ohgv/ANYjbWZqSSodukIKR74V0CpJeYyxULqXCfbVuVGBM=
X-Microsoft-Antispam-Message-Info: GBLbiXnesxA6xYv9AYY/l1AjGfc0dzrrxUEiOQfTnEbzsg59/Fm16EQhduJegowqzmbu69spOZ4SzFYlMhwKwxu7mZ265XjWfcApdFpWzVuKT/gsRTEcKyF28nkXfaWc+kiU2T+bEyfYTpL4/Vx3aqk/O+5AKFGzdTiUN8B+21uM2RGpJWHvLBMiL6Wtq0gLg/hMq6+k59DcTuZfznxTPsjMThhnZV+xfzyAnWDlGq5+DMQf6VQYCApJTGw3G2O6
X-Microsoft-Exchange-Diagnostics: 1; VI1PR0701MB2141; 6:hpLDu0bLyE63CNfiAH/YosoCy+Tz6Ijrnrldvd19WNpJC0yEnOGvSVV2qBboh76JnYGOHx6UmFT13o3wlVIBcXwVxafdhjHnL60JY9gIjIVXwvHjAoV+S4zXonpF1/b5DB/6wHjEH65/mK3+nhrUs430Zu/ok7MK18ml7xZKBoNq/DpfyFt+8i0wp5jWYwWyMhg815G7oZwl60x43EbWXBwVFjNxMMqrmC8DPGuKV9ZebKYGMfcwOuZr4qHT8OZrM7lY9PWxfqDW3FWjOBR+5q7esvEDca87YJ6vOd1ysUIKTSsQkGng651ot7fxmmAaE1wcqNFXo+WcVGhJM5NqIrYpd6hbKlCGoOhlkA0b5RWEcNrHa6QmThvmCTJ0UFOCMehaMjV2p187Gmfp4Pe9pFb7ZNH3+wIShABR+da0UCJfp+N1kOf0FOfQ8ruSGF5ceh0WC0bbt4X2YABm4GtM6Q==; 5:kIjB2WhATdZrccMK6h2PNb2LxeBGV4rZAt81hFSBuY3gSmhuY44QPJCod68fjbIxK42rfh/aYZN17aRKw48M5EzfU5rqKb3rqQQWpSq9GrSYIKGSHw5L5fc/btW+FFZ9Yu3yyKFG6ZNjM7U39nue8CJJikYh0aNaPns5OxbqcHs=; 24:w8L+y8qUZHU7GaGtGATUfzi2MrzFy3A8cCvrQ6lVG4fybGU8rf7cwyfGS6j92aP+VoM2PvJ+OWmmo8EKgY3E/fP6gQxQ/l5Ig7uO8K/lBJ8=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; VI1PR0701MB2141; 7:ICCm+tngfr9Ue7g2RvCUXujV3mA/jJNuc4Qw2i3MxL8P6Rw8OVy8x0ym4/5nCWdpEQ3TeXiydmJ8nUD2JzuDW5DDOaFXswer42hqWs96b36yOc8uvgRLOh/L9MPnbEENtmd3+6REiFyaGDBg0OiaHLp7+7JlVBb4lr0VySYdl+aWbn1cBpwJFcKGqnP9YfmTbAdZQVQtkppkY4JyMgBaHreOvw5P/61bRE1CyIDrsYEdk/n3ZfpXjYmpIKFZcskZ
X-MS-Office365-Filtering-Correlation-Id: 2285e4d2-c331-4285-5f41-08d5a474c252
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2018 15:06:12.4421 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2285e4d2-c331-4285-5f41-08d5a474c252
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB2141
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/IlE9Oazda9AWF5Y6mj0-8B3R-Vg>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2018 15:06:18 -0000

[resend, wrong bfd wg address in first attempt ...]
Authors, WG,

thank you for this document. It is clear and well written.
I didn't find any technical comment to make so I've been nit picking :-)
Please find those comments below.

regards,
martin

---
Please check and address the nits:
https://tools.ietf.org/idnits?url=https://tools.ietf.org/id/draft-ietf-bfd-multipoint-14.txt

On that aspect, does this document really update 7880 as the header 
says? The Introduction only refers to 5880 and it is not clear in the 
body of the Document what effectively impacts 7880. The only thing I saw 
is the addition of new session types but that does not require an update 
in my opinion. Could you clarify?


    i.e. existence of a path between the sender and the receiver.
do you mean "forwarding path"?


Section 2. and Section 3. seem a bit redundant. They both state the same 
thing but from a different angle. Not critical.


    Although this document describes a single head and a set of tails
    spanned by a single multipoint path, the protocol is capable of
    supporting (and discriminating between) more than one multipoint path
    at both heads and tails.
There is no text to describe how one could achieve that. Wouldn't it be 
worth adding some?


    Point-to-point sessions, as described in [RFC5880], are of type
    PointToPoint.
Does this really fit in Section 4.2 which looks to be about the mpBFD 
session model.


    Sessions of type MultipointHead MUST NOT send BFD control packets
    with the State field being set to INIT, and MUST be ignored on
    receipt.
English is not my native language but I wonder if this really says what 
you want. It seems that "Sessions" is the subject of "MUST be ignored" 
while I think it's the packets which are the intended subject. So I'd write:
    and those packets MUST be ignored on receipt.


    Because there is no three-way handshake in Multipoint BFD, a newly
    started head (that does not have any previous state information
    available) SHOULD start with bfd.SessionState set to Down and with
    bfd.RequiredMinRxInterval set to zero in the MultipointHead session.

    To shut down a multipoint session a head MUST administratively set
    bfd.SessionState in the MultipointHead session to either Down or
    AdminDown and SHOULD set bfd.RequiredMinRxInterval to zero.  The
In both these paragraphs one could read that the head "SHOULD set 
bfd.RequiredMinRxInterval to zero" while 4.4.2 says MUST. Clarification 
needed?

s/M, P bit/M and P bits/
---