Re: Yangdoctors early review of draft-ietf-bfd-unsolicited-01

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Mon, 19 August 2019 19:31 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BE16512022A; Mon, 19 Aug 2019 12:31:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=JTuBjfqa; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=Xz0JqYd9
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 64jQaj1LK_Ar; Mon, 19 Aug 2019 12:31:32 -0700 (PDT)
Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 631B0120019; Mon, 19 Aug 2019 12:31:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4562; q=dns/txt; s=iport; t=1566243092; x=1567452692; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=qY5y5kYgC1sEAgLw0CnjNdMefOJI6y03PDEkGVZfNXM=; b=JTuBjfqaZrg9yidFD8ykQhboJ6jUFXIrA6dBzXBY+fEAERlkMdhCqHk+ yqgpPqGefCknMeGKsDNc/ivnzPsozjNH4iX0qsK3Tw7pIWqa1iWFGagrb nWKwYfyMor8idTgOaccPZkPRHUa6aGmnlxb1acO36UH8nVkV8SfFzdhZ1 g=;
IronPort-PHdr: =?us-ascii?q?9a23=3APVcWmRw2VyFfqqTXCy+N+z0EezQntrPoPwUc9p?= =?us-ascii?q?sgjfdUf7+++4j5YhSN/u1j2VnOW4iTq+lJjebbqejBYSQB+t7A1RJKa5lQT1?= =?us-ascii?q?kAgMQSkRYnBZufE0T7KffsRyc7B89FElRi+iLzPA=3D=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0B9AABt+Fpd/4ENJK1mGwEBAQEDAQE?= =?us-ascii?q?BBwMBAQGBVgMBAQELAYFEUANtVSAECyqEH4NHA4p6TYFqJYlejgeCUgNUCQE?= =?us-ascii?q?BAQwBAR8OAgEBhD8CF4MPIzcGDgIFAQEEAQEBAgEGBG2FJwyFSgEBAQECARI?= =?us-ascii?q?REQwBATcBDwIBCA4KAgImAgICHxEVEAIEDgUigwABgWoDDg8BAqA0AoE4iGF?= =?us-ascii?q?zgTKCegEBBYULDQuCFAMGgQwoAYtoF4FAP4E4DBOCTD6CGkcCgUstgnQyggQ?= =?us-ascii?q?ijmQxnABACQKCHYZoiVgEg3UbmESVPIF6ji8CBAIEBQIOAQEFgWYigVhwFWU?= =?us-ascii?q?BgkGCQoNyilNygSmNVwEB?=
X-IronPort-AV: E=Sophos;i="5.64,406,1559520000"; d="scan'208";a="314513832"
Received: from alln-core-9.cisco.com ([173.36.13.129]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 19 Aug 2019 19:31:31 +0000
Received: from XCH-ALN-006.cisco.com (xch-aln-006.cisco.com [173.36.7.16]) by alln-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id x7JJVVRF018849 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 19 Aug 2019 19:31:31 GMT
Received: from xhs-aln-002.cisco.com (173.37.135.119) by XCH-ALN-006.cisco.com (173.36.7.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 19 Aug 2019 14:31:30 -0500
Received: from xhs-aln-003.cisco.com (173.37.135.120) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 19 Aug 2019 14:31:29 -0500
Received: from NAM01-BN3-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-003.cisco.com (173.37.135.120) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 19 Aug 2019 14:31:29 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aOQabAe82j4yaMzueMSutAfuxdjhu90h/tJvteVRxrBVxQE/L3noC2yMy0SpmGiIn0aiGJOmWdhCaf2haiH1jFTAQavtIfZT6fELQtKdDfE9a7yKcVIdd9lRtXzKcUUjTJCu9iHF+d4muLLgk8ZOq9DQO6pFEX7bep9hCiXa95JfGzWMZUds0+7L7GASSQp6xxCFn5H4f82txV1CiPDlnf5J73QIWk2kq8VOdZPHoksM19NFkATJs2aXpSPCG0JNIiry1LJi51dDh+combW1WKDqeENajK2c2u9QeXOoPm1ur938+c+bJgGyxLSpSXfTiPcQTmQkjxTyIJqpn2QgEw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qY5y5kYgC1sEAgLw0CnjNdMefOJI6y03PDEkGVZfNXM=; b=H2yB6NxzU0f6wRs9f+k3WitLNYzhvX7m7NnzNqKOKA8n5+ntIUs4aqjOcc/d1gx/k8mbz5wTi/hpDvnBo+WG8LZrcQhITMmwAFXBneE/R2D206To3HBu/QHrK/bLvkuY7o0/Pluakzdo71ChqtR2ctFPgQTUDwPkhdl8DPqQ1xb1NdML9s6h+tsepV/AobVhpJhoYxp1B1oxNp9sJMztAamFVnlg+AtXl+cRDeldrGgzeYQeqDJ4ud6zVsKiVZkJb8Gnowkz8evMRFOnPCOujnbLrehB+o/VNpCOascLtpMQS9p68Zne9zsi19A9VtTNNg68eahoNUQMLy4ZjUo7Bw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qY5y5kYgC1sEAgLw0CnjNdMefOJI6y03PDEkGVZfNXM=; b=Xz0JqYd9sItyo1TZRBGSvLSiv4VgVJAhsO79GewqLRpCX99kDQV2GgXp7c1lr7SI0559cW8VkPmGepu7zlQcy2Odp0fwHBIFCBG3jYsFuhsHArSwn4wL/wK0K+KHYHNAoF2TBdYhNa2l7iDEhkXm8oz7rcld9rksoOlX+A8wA2c=
Received: from MN2PR11MB4157.namprd11.prod.outlook.com (20.179.150.223) by MN2PR11MB4237.namprd11.prod.outlook.com (10.255.90.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16; Mon, 19 Aug 2019 19:31:28 +0000
Received: from MN2PR11MB4157.namprd11.prod.outlook.com ([fe80::80bb:d4b:bc47:7daf]) by MN2PR11MB4157.namprd11.prod.outlook.com ([fe80::80bb:d4b:bc47:7daf%3]) with mapi id 15.20.2178.018; Mon, 19 Aug 2019 19:31:28 +0000
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: Martin Bjorklund <mbj@tail-f.com>
CC: "mjethanandani@gmail.com" <mjethanandani@gmail.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-unsolicited.all@ietf.org" <draft-ietf-bfd-unsolicited.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-bfd-yang@ietf.org" <draft-ietf-bfd-yang@ietf.org>
Subject: Re: Yangdoctors early review of draft-ietf-bfd-unsolicited-01
Thread-Topic: Yangdoctors early review of draft-ietf-bfd-unsolicited-01
Thread-Index: AQHVVoFcW4RvcvlvFUaeAOxMqn9qZqcCz2yA///ENgCAAEUogP//wIcA
Date: Mon, 19 Aug 2019 19:31:27 +0000
Message-ID: <496A5CD5-23C9-4865-BC52-EFC5409475A8@cisco.com>
References: <156621414936.19813.853283734958376284@ietfa.amsl.com> <0CD4CB48-9382-4724-A5A6-A7B0DE7D7D57@gmail.com> <22279DB9-A0F3-4D5E-BFDC-38B2AD5B109F@cisco.com> <20190819.211837.1184862907842631386.mbj@tail-f.com>
In-Reply-To: <20190819.211837.1184862907842631386.mbj@tail-f.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1a.0.190609
authentication-results: spf=none (sender IP is ) smtp.mailfrom=rrahman@cisco.com;
x-originating-ip: [2001:420:2840:1250:6900:eb73:e481:aee6]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c48390e6-2242-4ab4-19ec-08d724dbd4d4
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR11MB4237;
x-ms-traffictypediagnostic: MN2PR11MB4237:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <MN2PR11MB4237FF15661206848DFB292DABA80@MN2PR11MB4237.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0134AD334F
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(346002)(376002)(366004)(136003)(199004)(189003)(6436002)(8936002)(478600001)(256004)(54906003)(6486002)(99286004)(76176011)(33656002)(6246003)(4326008)(6916009)(53936002)(966005)(14454004)(71190400001)(71200400001)(186003)(102836004)(486006)(476003)(2616005)(46003)(11346002)(446003)(53546011)(25786009)(229853002)(316002)(6116002)(58126008)(7736002)(36756003)(305945005)(66476007)(66946007)(5660300002)(76116006)(8676002)(86362001)(66446008)(66556008)(64756008)(81166006)(6306002)(81156014)(6512007)(2906002)(6506007)(66574012); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4237; H:MN2PR11MB4157.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 6bX+ECQSQ4237aoJPj47yh/SQ4biah1BOAyaOnbBqCaxe4Ooorn/gGYxCgPK2sERauyADdzR0PRFcXEJbjTUOvzWFSIpYjRd/ZphyLWBEM5u7Je9cq4137Xe/oEgiNPZudVWENZUXREfiXZhtvdgRyxl/hKagoW3RI7MHA8BCm4/41NTu5u14oSg9a7MEIngWZVEp0YWv8ATVWgDfH5NNY67HCl/ruP5a/SBM4gjo/BlHW/DJHLGER+ZBvCVscKmmboHEvEVXZpHkE3YAy2rx7OPvzo3wA4nnJIgKO1rSahQGYUzJDr1ZfkMS2gwCdGwbdpmgNENmG9WLXSWjgoDBBKaFaDXfUHd1y8QobQqnQEr2zMLDJbDjZ7U/XFp5pKn8Otu+D38+f+8z/5ZZpx5foUXiGmoU1vy9y21MVpnRzI=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <72513F3F9E27E84788CF1977EDD2295A@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c48390e6-2242-4ab4-19ec-08d724dbd4d4
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Aug 2019 19:31:27.9574 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: u1wMB+kBXWyk4AeKK0JIwIy1XfkByEvijTx9MtR5RxEQHdhWnWQhbYyOleVcbuw9uh4LGvNkR1dUSyjy+wulWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4237
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.16, xch-aln-006.cisco.com
X-Outbound-Node: alln-core-9.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/Lb7CMxyve1RBz64MEcTvU91rFw0>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Aug 2019 19:31:35 -0000

I was looking at an old copy of the doc which didn't have default. So yes, mandatory doesn't make sense with the default statements.

Your assumption below wrt the intention is correct. I don't know how feasible it is to add this while it's in the editor q.

Regards,
Reshad.

On 2019-08-19, 3:18 PM, "Martin Bjorklund" <mbj@tail-f.com>; wrote:

    "Reshad Rahman (rrahman)" <rrahman@cisco.com>; wrote:
    > Thanks Martin and Mahesh.
    > 
    > I believe we should add a mandatory statement to the choic (speaking
    > as BFD YANG co-author,)
    
    But then it is not clear why all leafs in the cases have default
    statements.
    
    Since the 'single-interval' case is optional with a if-feature (which
    BTW is weird since it is trivial to implement), and the only other
    case has default values on both its leafs, I would have assumed that
    the intention was that if nothing is configured, the server should use
    1000000 microseconds for the intervals.  If this is the intention,
    perhaps a statement:  "default tx-rx-intervals;" can be added to the
    module, even though the doc is in the RFC ed q.
    
    
    /martin
    
    
    
    > 
    > Just created https://github.com/bfd-wg
    > 
    > Regards,
    > Reshad.
    > 
    > 
    > On 2019-08-19, 2:45 PM, "Mahesh Jethanandani" <mjethanandani@gmail.com>; wrote:
    > 
    >     [Adding the authors of BFD YANG module]
    >     
    >     Martin brings up a good point. But since the document that contains ietf-bfd-types is sitting in RFC Ed Queue, this will have to go into a bis document.
    >     
    >     Chairs, could you create a bfd-wg in GitHub for us to track this as an issue to be fixed as part of a bis document?
    >     
    >     > On Aug 19, 2019, at 4:29 AM, Martin Björklund via Datatracker <noreply@ietf.org>; wrote:
    >     > 
    >     > Reviewer: Martin Björklund
    >     > Review result: Ready with Nits
    >     > 
    >     > I have reviewed this document from a YANG model perspective only.
    >     > 
    >     > My only comment is actually for a grouping defined in ietf-bfd-type, but used
    >     > in this module.  There is a choice "interval-config-type":
    >     > 
    >     >  +--rw unsolicited {bfd-unsol:unsolicited-params-global}?
    >     >       +--rw enable?                           boolean
    >     >       +--rw local-multiplier?                 multiplier
    >     >       +--rw (interval-config-type)?
    >     >          +--:(tx-rx-intervals)
    >     >          |  +--rw desired-min-tx-interval?    uint32
    >     >          |  +--rw required-min-rx-interval?   uint32
    >     >          +--:(single-interval) {single-minimum-interval}?
    >     >             +--rw min-interval?               uint32
    >     > 
    >     > This choice is not mandatory and doesn't have a default case, so the question
    >     > is what happens if no nodes from the choice has been configured?   I would
    >     > expect the choice to have a default case (but this then would apply to
    >     > ietf-bfd-types, not this document.)
    >     > 
    >     > 
    >     
    >     Mahesh Jethanandani
    >     mjethanandani@gmail.com
    >     
    >     
    >     
    >     
    >