Re: I-D Action: draft-ietf-bfd-yang-06.txt

Jeffrey Haas <jhaas@pfrc.org> Mon, 31 July 2017 17:06 UTC

Return-Path: <jhaas@slice.pfrc.org>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 66E541326AE; Mon, 31 Jul 2017 10:06:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.903
X-Spam-Level:
X-Spam-Status: No, score=-1.903 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NQwv2l9YqQNY; Mon, 31 Jul 2017 10:06:45 -0700 (PDT)
Received: from slice.pfrc.org (slice.pfrc.org [67.207.130.108]) by ietfa.amsl.com (Postfix) with ESMTP id E8ACA1326D7; Mon, 31 Jul 2017 10:06:41 -0700 (PDT)
Received: by slice.pfrc.org (Postfix, from userid 1001) id 6DFDC1E380; Mon, 31 Jul 2017 13:06:54 -0400 (EDT)
Date: Mon, 31 Jul 2017 13:06:54 -0400
From: Jeffrey Haas <jhaas@pfrc.org>
To: Yingzhen Qu <yingzhen.qu@huawei.com>
Cc: Mahesh Jethanandani <mjethanandani@gmail.com>, "Acee Lindem (acee)" <acee@cisco.com>, Reshad Rahman <rrahman@cisco.com>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-yang@ietf.org" <draft-ietf-bfd-yang@ietf.org>, "draft-ietf-ospf-yang@ietf.org" <draft-ietf-ospf-yang@ietf.org>
Subject: Re: I-D Action: draft-ietf-bfd-yang-06.txt
Message-ID: <20170731170654.GP24942@pfrc.org>
References: <D59904F6.2C51B4%rrahman@cisco.com> <D59FB0AD.BA38A%acee@cisco.com> <D59FB38C.2CE83D%rrahman@cisco.com> <D59FB594.BA3A0%acee@cisco.com> <D59FB7D2.2CE8F1%rrahman@cisco.com> <D59FB934.BA3C3%acee@cisco.com> <D59FBE2A.2CEA06%rrahman@cisco.com> <D5A01A7B.BA49E%acee@cisco.com> <C71CC69E-DAE4-49E0-983A-9B2EE9B4CD46@gmail.com> <594D005A3CB0724DB547CF3E9A9E810B5388E1@dfweml501-mbx>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <594D005A3CB0724DB547CF3E9A9E810B5388E1@dfweml501-mbx>
User-Agent: Mutt/1.5.21 (2010-09-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/M_jfKb3BRwkdmvjDpnReKhhymZw>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Jul 2017 17:06:46 -0000

On Sun, Jul 30, 2017 at 05:14:28PM +0000, Yingzhen Qu wrote:
> Please see attached ospf bfd module. Base ospf module also needs to be updated to remove the bfd enable leaf. ISIS model need to do the same change, ietf-isis-bfd.yang will look the same as ietf-ospf-bfd.yang.
> 
> Please let me know your commetns.

This looks fine to me.  I'm even fine with an enable leaf, although disable
is semantically equivalent to removing the configuration.

-- Jeff