Re: WGLC for draft-ietf-bfd-unaffiliated-echo (ending 7 April, 2023)

Greg Mirsky <gregimirsky@gmail.com> Thu, 06 April 2023 01:03 UTC

Return-Path: <gregimirsky@gmail.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 890F9C1524AE for <rtg-bfd@ietfa.amsl.com>; Wed, 5 Apr 2023 18:03:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.095
X-Spam-Level:
X-Spam-Status: No, score=-2.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8Gbx7U_NtNpu for <rtg-bfd@ietfa.amsl.com>; Wed, 5 Apr 2023 18:03:37 -0700 (PDT)
Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 09019C14CE54 for <rtg-bfd@ietf.org>; Wed, 5 Apr 2023 18:03:37 -0700 (PDT)
Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-54184571389so711265307b3.4 for <rtg-bfd@ietf.org>; Wed, 05 Apr 2023 18:03:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680743016; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9OumGKadXhxIof7uRp7BHv2KPwW5GSvOZWCkFL5UYPA=; b=b7HZ47JPC+ctyX0uQJUmtXN22rD+5J2aP+P6kZ+erh/y2+GgXAJmynEhTyHzj/RGBc +vFp5KifQEZclZ+e3r9azCaw7+ph+z0BtQ15Ek30EuvwoILA05y0BcTDHY+zw1KHvnt+ f4qaKQxtypKBJmpJt7kyzgMfIwDgteEiAhuu0HPBoMGA/o01rsBWn2S4Kv5INBk7hV4L uOm7ILTFqmsA/CiZSD8mnVEQFOp5WfFV8Ygs7nzWAvm+2Zv+4i+dIyzLd3i4ePJ5DJFX Nk+EfMOILEeQcq0B4+aMn0u5g++AGmM2BnPc1sSCRjsnmrZmZ/Vvn6MMTfRjWoXzYZMm YrJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680743016; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9OumGKadXhxIof7uRp7BHv2KPwW5GSvOZWCkFL5UYPA=; b=AWdNM/fOtxAKiKoi2lZIJJYjVROEaI84sCAaRjLpiWTNhhmxIldnKpy3f/fFM7TSgC F+GDcAQkL4nHR8gYTVSHg4s1GhtO2QOx/8A2gqhzlmC33hFTZe5TRDS+fqGSk4lv9Psu 0CIJ5AaTNgz8KLTj53GUMufEtI7viME5LYaXF6nndGLiCdafvWaqg5z5obqfv3vILFhK iGMHHMklQKHst8P9tX2N+pnWdUFEZGSJdiGb0UFA0i4fd5GgpwIOflQpeYGskhLdlImX LoWkf7bY6IR6Xgy1JalfFHIA3sDvN3nnl4Q5aC/xUfO0md/WEus+FQynxAEaQxAzWgUl mhew==
X-Gm-Message-State: AAQBX9eB5KZYumuuWczQVWu7+04rNNKwnrUD+9qY/Sycm5NNhAbM3MQw fNe/4NmwSd8u3+W71Hohv2VGeLyWLRmNtJsIm00=
X-Google-Smtp-Source: AKy350ab/ACoITVMxG/z5kxRvonpJT4x4cVZ1L606Nt4KjyuGRIgUsuRTGA5HoZwiT5OyEQ+5uh2Nmp4Qy3mZU9tGx0=
X-Received: by 2002:a81:b20a:0:b0:541:7237:6e6b with SMTP id q10-20020a81b20a000000b0054172376e6bmr4900216ywh.0.1680743015729; Wed, 05 Apr 2023 18:03:35 -0700 (PDT)
MIME-Version: 1.0
References: <CA+RyBmXtST1EZcba_RM90NLf5hYAiKL2+XjSZwO2r-d_XNjwqA@mail.gmail.com> <202304030951493197032@zte.com.cn>
In-Reply-To: <202304030951493197032@zte.com.cn>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Wed, 05 Apr 2023 18:03:24 -0700
Message-ID: <CA+RyBmXMXSzvUCtAheycqSdO8M01pp=N345K9Qv3Z37EPYEFLg@mail.gmail.com>
Subject: Re: WGLC for draft-ietf-bfd-unaffiliated-echo (ending 7 April, 2023)
To: xiao.min2@zte.com.cn
Cc: jhaas@pfrc.org, rtg-bfd@ietf.org
Content-Type: multipart/alternative; boundary="0000000000006951a205f8a07a74"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/QwuFlHmiyIF9iV8-9064_in1rCs>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Apr 2023 01:03:41 -0000

Hi Xiao Min,
thank you for sharing your views. I have several technical questions:

   - As this specification replaces the Echo function defined in RFC 5880,
   I expect it will describe the applicability of the new Echo functionality
   when the link in Figure 1 is a tunnel or a member link of a LAG.
   - The draft describes how the destination IP address of the Echo packet
   is set. Are there any special considerations for selecting IPv6 destination
   address?
   - Also, are there any special considerations for selecting the source IP
   address for IPv4 and/or IPv6 network?

Furthermore, please find my notes below under the GIM>> tag.

Regards,
Greg

On Sun, Apr 2, 2023 at 6:51 PM <xiao.min2@zte.com.cn> wrote:

> Dear Greg,
>
>
> Thanks for sharing your thoughts, even if they're concerns.
>
> Please see inline...
> Original
> *From: *GregMirsky <gregimirsky@gmail.com>
> *To: *Jeffrey Haas <jhaas@pfrc.org>;
> *Cc: *rtg-bfd@ietf.org <rtg-bfd@ietf.org>;
> *Date: *2023年03月27日 13:40
> *Subject: **Re: WGLC for draft-ietf-bfd-unaffiliated-echo (ending 7
> April, 2023)*
> Dear Authors,
> I read the latest version of the draft. I appreciate your work on
> improving its readability. I have several concerns and appreciate your
> consideration:
>
>    -
>
>    It appears like the document defines the format of the Echo message.
>    As I understand the RFC 5880, the format of the Echo message is not
>    specified in the RFC 5880. It seems like by defining the format in this
>    document, you affect RFC 5880 compliance of implementations that do support
>    RFC 5880 as it exists today.
>
>    [XM]>>> As far as I can tell, several vendors have implemented this
>    feature and nobody reports the problem.
>
> GIM>>I think that it would be beneficial to reflect information about
existing implementation in the Implementation State section as described in RFC
7942 <https://datatracker.ietf.org/doc/rfc7942/>. At the same time, your
update about deployed implementations doesn't resolve my concern about the
impact of the proposal on earlier implementations of the Echo function as
it is defined in RFC 5880.

>
>    -
>
>
>    -
>
>    The draft, in my opinion, significantly changes the architecture of
>    the BFD, as it is defined in RFC 5880. I believe that characterizing Echo
>    as a function stresses its dependency from a BFD mode, Asynchronous and
>    Demand. The changes proposed in this draft are very extensive and severely
>    affect the existing architecture of BFD by setting the Echo function on
>    par, unrelated with the BFD modes.
>
>    [XM]>>> Please see above.
>
> GIM>> My question is about the impact on implementations that support the
Echo function as currently defined in RFC 5880. Perhaps you have verified
that there's no adverse impact? Please, if you have it, share information
about any interoperability between a system using the RFC5880-style Echo
function and a system with the unaffiliated Echo.

>
>    -
>
>
>    -
>
>    Also, I think that the normative language in the last paragraph of the
>    Secrity Considerations sections are too soft. Currently used recommendation
>    level, in my opinion, is insufficient and should be brought to the
>    requirement level. I.e., I propose s/RECOMMENDED/MUST/ and s/SHOULD
>    NOT/SHALL NOT/
>
>    [XM]>>> I agree we can strengthen the requirements for security. I'll
>    incorporate the changes you proposed if no objection from others.
>
>
>
> In conclusion, I am very much concerned with the amount of changes to the
> BFD architecture proposed in the document. I am also concerned with the
> affect on the protocol conformance standing of the established BFD
> implementations, SH BFD in particular. Hence, I propose changing this draft
> to the Experimental track.
>
> [XM]>>> As said, I have different opinion on the implication of this
> feature. As to the Standards Track vs Experimental Track, I'm open to it, I
> personally prefer the former.
>
>
> Cheers,
>
> Xiao Min
>
>
> Regards,
> Greg
>
> On Tue, Mar 21, 2023 at 11:02 AM Jeffrey Haas <jhaas@pfrc.org> wrote:
>
>> Working Group,
>>
>> https://datatracker.ietf.org/doc/draft-ietf-bfd-unaffiliated-echo/05/
>>
>> The authors of draft-ietf-bfd-unaffiliated-echo have requested WGLC.
>>
>> The draft, in my opinion, is in fairly good shape.  However, since it
>> functions via looping packets back to itself and trying to exercise the
>> normal RFC 5880 state machine behaviors to a large extent, the draft could
>> use very high scrutiny for several matters:
>>
>> - Does the state machine behave appropriately at all stages?
>> - Are the descriptions of the values of the BFD fields clear in all cases?
>>
>> Please supply the authors and the Working Group with your feedback.
>>
>> The intended finish date for this WGLC is 7 April, 2023.  This is one week
>> after the end of IETF 116.
>>
>> Note that Reshad is an author on the draft, so I'll be handling the full
>> set
>> of review and shepherding work.
>>
>> -- Jeff
>>
>>
>>
>