RE: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data Model for Routing Information Protocol (RIP)) to Proposed Standard

Xufeng Liu <Xufeng_Liu@jabil.com> Tue, 05 December 2017 16:31 UTC

Return-Path: <Xufeng_Liu@jabil.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D27512778D; Tue, 5 Dec 2017 08:31:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=jabil.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PSCMeDxMuiVy; Tue, 5 Dec 2017 08:31:34 -0800 (PST)
Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0132.outbound.protection.outlook.com [104.47.40.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A6BE1127342; Tue, 5 Dec 2017 08:31:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jabil.onmicrosoft.com; s=selector1-jabil-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fBUvEmuO8l9FHuVWHTIq/ZzVj8uKoS4JGTN8g5Ps45Y=; b=GvIctLQoGnEHxXs3ovBuGd0+3gu+Z6QWAS7El9ELJL32hRvqP1t7ESwo8X2R1xFVlZjwkz95nw3dg+YRbmbyRrZHRuV6gVOpgCT3z79XZo2Z+XRrA8TpRk5CIRZaJXY8IIK3YPN6TC4LX9TRdDdUOqCdqMlXV9dQEf296A5KbEk=
Received: from BN3PR0201MB0867.namprd02.prod.outlook.com (10.160.154.13) by BN3PR0201MB0868.namprd02.prod.outlook.com (10.160.154.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Tue, 5 Dec 2017 16:31:31 +0000
Received: from BN3PR0201MB0867.namprd02.prod.outlook.com ([10.160.154.13]) by BN3PR0201MB0867.namprd02.prod.outlook.com ([10.160.154.13]) with mapi id 15.20.0282.012; Tue, 5 Dec 2017 16:31:31 +0000
From: Xufeng Liu <Xufeng_Liu@jabil.com>
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>, "ietf@ietf.org" <ietf@ietf.org>
CC: "draft-ietf-rtgwg-yang-rip@ietf.org" <draft-ietf-rtgwg-yang-rip@ietf.org>, "rtgwg@ietf.org" <rtgwg@ietf.org>, "rtgwg-chairs@ietf.org" <rtgwg-chairs@ietf.org>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>
Subject: RE: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data Model for Routing Information Protocol (RIP)) to Proposed Standard
Thread-Topic: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data Model for Routing Information Protocol (RIP)) to Proposed Standard
Thread-Index: AQHTaGYg1e2nHONyqEGMpcnPNFWcJKMrkyYAgAN30LCAAAU5AIAF5R/w
Date: Tue, 5 Dec 2017 16:31:31 +0000
Message-ID: <BN3PR0201MB0867E8226DEE9C74C4C508F4F13D0@BN3PR0201MB0867.namprd02.prod.outlook.com>
References: <151188659372.12435.1451903543359435950.idtracker@ietfa.amsl.com> <1511974182521.58987@cisco.com>, <CY1PR0201MB08759E21D67482E9851E0F58F1390@CY1PR0201MB0875.namprd02.prod.outlook.com> <1512165964785.84477@cisco.com>
In-Reply-To: <1512165964785.84477@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNceGxpdVxhcHBkYXRhXHJvYW1pbmdcMDlkODQ5YjYtMzJkMy00YTQwLTg1ZWUtNmI4NGJhMjllMzViXG1zZ3NcbXNnLWJkOWNjZjc1LWQ5ZDktMTFlNy05YzM3LTE4NWUwZmUzYzQ1Y1xhbWUtdGVzdFxiZDljY2Y3Ny1kOWQ5LTExZTctOWMzNy0xODVlMGZlM2M0NWNib2R5LnR4dCIgc3o9IjY3ODIiIHQ9IjEzMTU2OTY1MDg5MTA3NTI4NSIgaD0idnFsd05LeE9nRUgySCtGeHNrZkNmenBiRnpvPSIgaWQ9IiIgYmw9IjAiIGJvPSIxIi8+PC9tZXRhPg==
authentication-results: spf=none (sender IP is ) smtp.mailfrom=Xufeng_Liu@jabil.com;
x-originating-ip: [98.191.72.170]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BN3PR0201MB0868; 6:eWiyW7Y+0UstbG37hYocVCsQTtR+JQooZOPoAF5Exo+GHfDNSvNoLZk/GXXQIXO0NFkg9b8G65+PNt7B/Xy8FQ6S1wfqFJxkfqhOxmyDZkGJdoasCGQwBZJ3YTQ5lABmnHbDH5pWMSQrCVrH7PkzZSsFslGMqRzYMVngmiMYkN9kEX67Tz0CJsXhscusMoPv1L0jzGH2LFqpBW56+S1Fdf0KnTPBgaSYeZjaL8zzKQ7mubQKvmVoMjphQh8CGfRcd58v1Vu7RQK4re7q9/os0LP6kHr1jXX6IU96x4Qzt6YIt8VjZ3eny7guzzc1SSf3cEYgAtSDXHhWoSpmJd65y+Geye1JozWNd86BNYPoo6c=; 5:6Znlc6Z4ehp6rt5EUE9ZeLhsRYQHwe3AZnSYbIOEqlJ+fiKTxpheiyFPjmgpqi8O6lFGA1K/Gegw5PGukl3R1V2myRRjJ8PQJOcaBDE2e/Og33TXrn81c3HOsswIddGDBhilXZBmBsGp75qgsq3H0WDWsEmSkryMmiISiRl78cw=; 24:R8rBfT7iYQwbRTMF/MPJJNV2FWw9F8t6ahDcn1ALJqKIzs78Nua1ihzZKKlvdh+fDLEFoTxD2+2uxZscxFRC6P0hDiF36LEnzXIwrXhscpg=; 7:Q4aI1uoq7HNqdJ0mxvbQN4nLL8LoSHSkCctsi3Wy5h4/b7VBDorUCDI56AxTSkyhGT298aa97ByH/G1WOfArI1D1tL5G0pIkdKOGukZuN/IhDwd0/y7rOIwrAgctV9/kjKgBU0B3y86teroiaQN+59Ph+RE8juPHOgAOwDqcdbh9FkkdWVN5OFpjq0Ug+XGQ/2yYfR/R/wRRY0F3wtxIo+T4X47MJiuqgHS4ud0E+gAhuhcYYbgJu+urd1wbGWvh
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: f5245124-e91a-48ba-f255-08d53bfda45f
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603286); SRVR:BN3PR0201MB0868;
x-ms-traffictypediagnostic: BN3PR0201MB0868:
x-microsoft-antispam-prvs: <BN3PR0201MB086898C44EB0ABF9D67CBFD5F13D0@BN3PR0201MB0868.namprd02.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(120809045254105)(95692535739014)(21534305686606);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231022)(6055026)(6041248)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(6072148)(201708071742011); SRVR:BN3PR0201MB0868; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BN3PR0201MB0868;
x-forefront-prvs: 0512CC5201
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(979002)(376002)(346002)(39860400002)(366004)(51914003)(13464003)(72206003)(966005)(6506006)(80792005)(2950100002)(4001150100001)(316002)(2900100001)(74316002)(106356001)(93886005)(105586002)(55016002)(14454004)(97736004)(81166006)(4326008)(478600001)(7736002)(575784001)(99286004)(81156014)(86362001)(305945005)(6306002)(8936002)(33656002)(230783001)(8676002)(5660300001)(3280700002)(68736007)(6436002)(7696005)(76176011)(3846002)(6116002)(6246003)(101416001)(66066001)(2906002)(3660700001)(102836003)(54906003)(110136005)(25786009)(53936002)(77096006)(229853002)(9686003)(53546010)(2501003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1102; SCL:1; SRVR:BN3PR0201MB0868; H:BN3PR0201MB0867.namprd02.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; LANG:en;
received-spf: None (protection.outlook.com: jabil.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: jabil.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5245124-e91a-48ba-f255-08d53bfda45f
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2017 16:31:31.0965 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bc876b21-f134-4c12-a265-8ed26b7f0f3b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0201MB0868
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/W0dey_KsDp-ursrgWsbQ0ybavGA>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Dec 2017 16:31:43 -0000

Hi Reshad,

Thanks for the review comment. Can you please check the following?
Regards,
- Xufeng

> -----Original Message-----
> From: Reshad Rahman (rrahman) [mailto:rrahman@cisco.com]
> Sent: Friday, December 1, 2017 5:05 PM
> To: Xufeng Liu <Xufeng_Liu@jabil.com>;; ietf@ietf.org
> Cc: draft-ietf-rtgwg-yang-rip@ietf.org; rtgwg@ietf.org; rtgwg-chairs@ietf.org;
> rtg-bfd@ietf.org
> Subject: Re: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data Model
> for Routing Information Protocol (RIP)) to Proposed Standard
> 
> Hi Xufeng,
> 
> You are correct, I looked at the wrong version.
> 
> If explicit-neighbors feature is not supported, would you want to have the BFD
> client parameters (client-cfg-parms) configured in RIP? Otherwise operator
> needs to look at neighbors discovered and configure parameters under BFD for
> that neighbor. And when a new neighbor shows up, the same thing has to be
> done again.

[Xufeng] Yes. It would be better to have such a capability. Now that a newer version of the BFD model (draft-ietf-bfd-yang-07) have been posted, it would be better to use the  new grouping "client-cfg-parms" and be consistent with other IGPs. Please review if the followings are the proper changes:

  module ietf-rip {
+     import ietf-bfd-types {
+      prefix "bfd-types";
+    }

          container bfd {
            if-feature bfd;
            description "BFD configuration.";
-           leaf enabled {
-             type boolean;
-             default false;
-             description
-               "'true' if BFD is enabled for the interface.";
-           }
+           uses bfd-types:client-cfg-parms;
          }

  }

       +--rw interfaces
       |  +--rw interface* [interface]
       |     +--rw interface                  if:interface-ref
       |     +--rw bfd {bfd}?
-       |     |  +--rw enabled?   boolean
+      |     |  +--rw enable?                     boolean                         <== From grouping client-cfg-parms
+      |     |  +--rw local-multiplier?           multiplier
+      |     |  +--rw (interval-config-type)?
+      |     |     +--:(tx-rx-intervals)
+      |     |     |  +--rw desired-min-tx-interval     uint32
+      |     |     |  +--rw required-min-rx-interval    uint32
+      |     |     +--:(single-interval)
+      |     |        +--rw min-interval                uint32

[Xufeng] BTW. A comment about the leaf "enable" above: in most published models, "enabled" is used instead of "enable". Do you want to make it consistent?
 
> 
> Please see email discussion with OSPF/ISIS YANG authors.
> https://mailarchive.ietf.org/arch/msg/rtg-bfd/KNipAESw8fGKuUKrCxFlhdkRA0Y
> 
> Regards,
> Reshad.
> 
> ________________________________________
> From: Xufeng Liu <Xufeng_Liu@jabil.com>;
> Sent: Friday, December 1, 2017 4:50 PM
> To: Reshad Rahman (rrahman); ietf@ietf.org
> Cc: draft-ietf-rtgwg-yang-rip@ietf.org; rtgwg@ietf.org; rtgwg-chairs@ietf.org;
> rtg-bfd@ietf.org
> Subject: RE: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data Model
> for Routing Information Protocol (RIP)) to Proposed Standard
> 
> Hi Reshad,
> 
> Can you please double-check the revision 06 of the document? draft-ietf-rtgwg-
> yang-rip-04 used bfd-grouping-base-cfg-parms, and was taken out by draft-ietf-
> rtgwg-yang-rip-05. Please let us know if this is not the case, or we need to do
> something differently.
> 
> Thanks,
> - Xufeng
> 
> > -----Original Message-----
> > From: Reshad Rahman (rrahman) [mailto:rrahman@cisco.com]
> > Sent: Wednesday, November 29, 2017 11:49 AM
> > To: ietf@ietf.org
> > Cc: draft-ietf-rtgwg-yang-rip@ietf.org; rtgwg@ietf.org;
> > rtgwg-chairs@ietf.org; rtg-bfd@ietf.org
> > Subject: Re: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG
> > Data Model for Routing Information Protocol (RIP)) to Proposed
> > Standard
> >
> > Hi,
> >
> > The RIP YANG model uses bfd-grouping-base-cfg-parms from BFD YANG.
> > That grouping does not exist in latest revision (it has been renamed).
> > Also, as per discussions we had with OSPF/ISIS YANG authors, the
> > grouping which should be used from BFD is client-cfg-parms.
> >
> > Regards,
> > Reshad.
> > ________________________________________
> > From: rtgwg <rtgwg-bounces@ietf.org>; on behalf of The IESG <iesg-
> > secretary@ietf.org>;
> > Sent: Tuesday, November 28, 2017 11:29 AM
> > To: IETF-Announce
> > Cc: draft-ietf-rtgwg-yang-rip@ietf.org; rtgwg@ietf.org;
> > rtgwg-chairs@ietf.org
> > Subject: Last Call: <draft-ietf-rtgwg-yang-rip-06.txt> (A YANG Data
> > Model for Routing Information Protocol (RIP)) to Proposed Standard
> >
> > The IESG has received a request from the Routing Area Working Group WG
> > (rtgwg) to consider the following document: - 'A YANG Data Model for
> > Routing Information Protocol (RIP)'
> >   <draft-ietf-rtgwg-yang-rip-06.txt> as Proposed Standard
> >
> > The IESG plans to make a decision in the next few weeks, and solicits
> > final comments on this action. Please send substantive comments to the
> > ietf@ietf.org mailing lists by 2017-12-12. Exceptionally, comments may
> > be sent to iesg@ietf.org instead. In either case, please retain the
> > beginning of the Subject line to allow automated sorting.
> >
> > Abstract
> >
> >
> >    This document describes a data model for the Routing Information
> >    Protocol (RIP).  Both RIP version 2 and RIPng are covered.
> >
> >
> >
> >
> > The file can be obtained via
> > https://datatracker.ietf.org/doc/draft-ietf-rtgwg-yang-rip/
> >
> > IESG discussion can be tracked via
> > https://datatracker.ietf.org/doc/draft-ietf-rtgwg-yang-rip/ballot/
> >
> >
> > No IPR declarations have been submitted directly on this I-D.
> >
> >
> > The document contains these normative downward references.
> > See RFC 3967 for additional information:
> >     draft-bjorklund-netmod-rfc7223bis: A YANG Data Model for Interface
> > Management (None - IETF stream)
> >     draft-ietf-netmod-revised-datastores: Network Management Datastore
> > Architecture (None - IETF stream)
> >     draft-acee-netmod-rfc8022bis: A YANG Data Model for Routing
> > Management (NDMA Version) (None - )
> >     draft-bjorklund-netmod-rfc7277bis: A YANG Data Model for IP
> > Management (None - IETF stream)
> >     draft-ietf-ospf-yang: Yang Data Model for OSPF Protocol (None -
> > IETF stream)
> >
> >
> >
> > _______________________________________________
> > rtgwg mailing list
> > rtgwg@ietf.org
> > https://www.ietf.org/mailman/listinfo/rtgwg