Re: Shephered writeup for draft-ietf-bfd-secure-sequence-numbers

Mahesh Jethanandani <mjethanandani@gmail.com> Tue, 23 February 2021 20:03 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D8D583A0D24; Tue, 23 Feb 2021 12:03:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o_GTsXvEA239; Tue, 23 Feb 2021 12:03:14 -0800 (PST)
Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A473D3A0D43; Tue, 23 Feb 2021 12:02:28 -0800 (PST)
Received: by mail-pf1-x430.google.com with SMTP id m6so9519013pfk.1; Tue, 23 Feb 2021 12:02:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:message-id:date:cc:to; bh=KNv5lbBYH1KOaAaDG1Qp/w3ZKGVMpEFYxGmnyOclNBI=; b=UfBEJKPPAu9+TQNw5ph6pFiLBOIDTBkr7ADBrE0obmgQmaP0nklRp9mWQ7ve2YJ8mE hCER9gXGRbZDkIUBUamsbkOQr17bhRnf8goL0ravM0cwSupw+5YQG/kUcbL7I7nGhRXR /01ZVRWlCqtgtsv6oJZsAmLXowF5E2G/RxxPEejatN5GYSvlYpdE2VkmGWw2AmIdw4bU Su6W0s+yfFXGLm+/NaF5cvme1qUjRm4lM24yGA05xaUf+ltAgswkhNJ+ujBCN26uTG7u wCyjrYkYgjYFbgTFbSnKEv64pA5D7WoKZ75DAPHijFBDwUTipbLzewxs9Hp5m04CW4XW tN5g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:cc:to; bh=KNv5lbBYH1KOaAaDG1Qp/w3ZKGVMpEFYxGmnyOclNBI=; b=rLHUIN6IP+laWsk/DRzZzymXYswW4Z3ULI2rS2Hwx39u5QMDV6EyLsv5aEdsOerBWt G/ynju8MvOW7xdL0nkcgtQrZKsFNNf7VstPRFKCn1r/mGghSY4JeKlFOe7rchxcEuPt/ RQe0I31m4dFrVN4faohA1zzm5T2fUja3VNxdVzFrcSWXmai8Xg2ez15cZU68X2DYkbwa bRbc8NZQjR23fpGIvL6ys8ajF0CZWMkavyzvkmieqtmPBqby9IDDFDslYD4QmI8Sj1hQ n4obg/N/EFC2CQ4EzHgvRyO/wzTTF9B/HPKXuLwTy2h9vtDrgWAFxlY8G1fqBGU9PqcX XlNQ==
X-Gm-Message-State: AOAM531bWKQJ9/HZfn2xQ6nkHTpZ5XuIys+gmeCIV8MYK+iurMTyghSy o6mr0E7L3wXOrvZ3GsEnmeM=
X-Google-Smtp-Source: ABdhPJyjKQRC96X98jCzJ/WtzoNHTopdQDCAi3yJA6mXe8M40aMamaxtuFu9pBSr418LfTHpRG1NFg==
X-Received: by 2002:a65:4781:: with SMTP id e1mr25614222pgs.30.1614110548208; Tue, 23 Feb 2021 12:02:28 -0800 (PST)
Received: from ?IPv6:2601:647:5600:5020:7d6e:1c69:17df:2398? ([2601:647:5600:5020:7d6e:1c69:17df:2398]) by smtp.gmail.com with ESMTPSA id f28sm26040157pfk.182.2021.02.23.12.02.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Feb 2021 12:02:27 -0800 (PST)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_65F67508-340F-4148-A899-368F70017ED9"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: Shephered writeup for draft-ietf-bfd-secure-sequence-numbers
Message-Id: <1995CE5F-4996-4C2B-9BFE-B3DC56511CC0@gmail.com>
Date: Tue, 23 Feb 2021 12:02:25 -0800
Cc: "rtg-bfd@ietf. org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-secure-sequence-numbers@ietf.org" <draft-ietf-bfd-secure-sequence-numbers@ietf.org>, Martin Vigoureux <martin.vigoureux@nokia.com>
To: Reshad Rehman <reshad@yahoo.com>, Jeffrey Haas <jhaas@pfrc.org>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/er6W03XE587iU6KgLxGRT1Rjdp4>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Feb 2021 20:03:21 -0000

Hi Reshad,

I never really received this e-mail, till Sonal forwarded it to me. Anyway, here are our responses to the comments you have provided. Please see inline with [mj].

> Hi Sonal, authors,
> 
>  
> 
> Thanks for the document update. Main comments:
> 
>  
> 
> Hash has been replaced by symmetric algorithm, to be able to retrieve the sequence number at the receiving side, this is good. 
> Section 3 mentions that the symmetric key is provisioned securely on sender and receiver, but there is no mention of provisioning of the algorithm/function. Also there is no mention of what algorithms to use, is this on purpose since what’s good today will not be recommended tomorrow? Should we at least say “do not use DES” or too obvious?
[mj] I believe this is a question for the WG, and maybe something we can bring up in the upcoming meeting, if it is not answered on the mailing list. Would the WG prefer that a (set of) algorithms MUST be defined to ensure interoperability, or is this something we should leave up to implementors/operators to agree? We are concerned what we define today might be obsoleted tomorrow.

> Was there any discussions/thoughts on using asymmetric encryption instead (I didn’t follow this document when it started)? It avoids the pain of having a shared secret. I’m not saying we should go with asymmetric, just wondering.
[mj] We chose symmetric because that is what 5880 talks about.

> For the key, the terms “symmetric key”, “shared secret key” and “shared key” are used, settle on one for clarity (I believe it should be “shared key” or “shared secret”?)
[mj] Ok. How about “shared secret key”?

> For the algorithm, the terms “symmetric key algorithm”, “symmetric algorithm” , “symmetric encryption algorithm”, “symmetric decryption algorithm” are used. Again, pick 1 “symmetric algorithm”?).
[mj] Ok. We will pick “symmetric algorithm”.

> The term “hash” is still used e.g. in section 4 header
[mj] That is deliberate. We use “hash” when we refer to the value that is calculated over the entire packet and appended as a value at the end of the packet. That is different from ciphertext, which is the value after applying the symmetric algorithm on the sequence number and inserted in-lieu of the sequence number before the hash is calculated.

> Security is not my expertise. Should we get a security review asap, as opposed to waiting for IESG review. Jeff/Martin?
[mj] It would not be a bad idea, although we do have a security expert as a co-author on the draft :-)

> Diagram chains are clearer now.
> Sequence number validity as described at the bottom of page 3 and on P4 (at the end of section 3). RFC5880 sections 6.7.3 and 6.7.4 describe that received sequence number should be between bfd.RcvAuthSeq(+1) to bfd.RcvAuthSeq+(3*Detect Mult) inclusive. I don’t see why this has to be changed for secure sequence numbers.
[mj] We will just refer to 5880.

> Jeff’s comment regarding “The first sequence number can be obtained…” in section 3. I believe the text is incorrect. RFC5880 sections 6.7.3 and 6.7.4 explain how the first sequence number is obtained (using bfd.AuthSeqKnown and bfd.RcvAuthSeq).
[mj] Ditto.

>  
> 
> Nits:
> 
>  
> 
> Section 4: s/”while encryption/decryption”/”while doing encryption/decryption”/
> 
[mj] Ok.
> What does “non linear” mean in “monotonically increasing (but non linear) sequence number”?
[mj] A monotonically increasing number is just that, an increasing number, but it does not have to be linear. See the diagram below. That is why the mention of non-linear.


> Section 7: s/Jeff Hass/Jeff Haas/
> 
[mj] Will fix :-). Thanks
>  
> 
> Regards,
> 
> Reshad.
> 
Mahesh Jethanandani
mjethanandani@gmail.com