Re: Eric Rescorla's No Objection on draft-ietf-bfd-yang-16: (with COMMENT)

Jeffrey Haas <jhaas@pfrc.org> Tue, 10 July 2018 23:31 UTC

Return-Path: <jhaas@slice.pfrc.org>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB9BE12426A; Tue, 10 Jul 2018 16:31:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o8YSc3OWjduo; Tue, 10 Jul 2018 16:31:00 -0700 (PDT)
Received: from slice.pfrc.org (slice.pfrc.org [67.207.130.108]) by ietfa.amsl.com (Postfix) with ESMTP id 3A987130E67; Tue, 10 Jul 2018 16:31:00 -0700 (PDT)
Received: by slice.pfrc.org (Postfix, from userid 1001) id EEF881E28F; Tue, 10 Jul 2018 19:30:50 -0400 (EDT)
Date: Tue, 10 Jul 2018 19:30:50 -0400
From: Jeffrey Haas <jhaas@pfrc.org>
To: Eric Rescorla <ekr@rtfm.com>
Cc: "Reshad Rahman (rrahman)" <rrahman@cisco.com>, The IESG <iesg@ietf.org>, "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-yang@ietf.org" <draft-ietf-bfd-yang@ietf.org>, "bfd-chairs@ietf.org" <bfd-chairs@ietf.org>
Subject: Re: Eric Rescorla's No Objection on draft-ietf-bfd-yang-16: (with COMMENT)
Message-ID: <20180710233050.GB12853@pfrc.org>
References: <153074359709.27286.9248456135858358472.idtracker@ietfa.amsl.com> <490A33FD-E9F4-4798-B770-7D43BB962F8E@cisco.com> <CABcZeBM5fQCU4sSOBFWRuM9OCFEyaGuAbhFoNV9ACAaPqKO3sg@mail.gmail.com> <3875A614-F6AB-4A18-8A62-E809E45594C2@cisco.com> <CABcZeBMshzjQB=kC-9C9GLakYR7sQd1EHP1Tv+E5BtmbE2GxxA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CABcZeBMshzjQB=kC-9C9GLakYR7sQd1EHP1Tv+E5BtmbE2GxxA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/l8M360He0_qkFuDvSwfLenaQSD4>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jul 2018 23:31:02 -0000

[Note that I'm making this comment for posterity so that the IESG doesn't
ask the same thing of other draft authors.]

On Thu, Jul 05, 2018 at 06:18:42AM -0700, Eric Rescorla wrote:
> On Thu, Jul 5, 2018 at 6:10 AM, Reshad Rahman (rrahman) <rrahman@cisco.com>
> wrote:
> > <RR2> The pyang tool does this for real references (leafref) but not in
> > the grouping case (which is reuse and not reference). Even though there is
> > replication in the tree diagrams, I believe there is benefit in seeing the
> > complete tree for each module.
> >
> 
> Well, this is a comment so you're free to ignore it, but IMO it makes it
> very hard to read these.

The fundamental issue here is one of clear representation of a node being
instantiated vs. the semantic idea that we're seeing a template (grouping)
instantiated.

At the moment, pyang output is showing that when you use a grouping, you get
an actual node in the tree.  Given that things like augmentations cannot be
done to groupings as a logical entity and have impact everywhere, this is
perhaps an important detail, if annoying.

The proper place to pursue a fix to this is asking for a bis on RFC 8340.

-- Jeff