Re: Yangdoctors early review of draft-ietf-bfd-unsolicited-01

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Mon, 19 August 2019 19:11 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 72882120877; Mon, 19 Aug 2019 12:11:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=BOP6RWJz; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=dKBvaJzP
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3ISiVM0Rv6KC; Mon, 19 Aug 2019 12:11:13 -0700 (PDT)
Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6321A120822; Mon, 19 Aug 2019 12:11:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2678; q=dns/txt; s=iport; t=1566241873; x=1567451473; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=gSs47GIuv/9kVRNABlIfYakquGLi+VjYKyAFQCP/qhs=; b=BOP6RWJzzB3hgJYScET5w4x4XZrJ/xndFt+FfmbP+/RdgtfVMXcNDmug Rt00oTHUZl6oA9fGtVcnFDxK0OVsEDitiJQzC0a2bzIJCggbOHUfq2Uwe 1UBCj19PwSpGHyNtNESVDsfJMCYdPjJh9RAcDeh69dAFsXOLYkLS5z8h2 A=;
IronPort-PHdr: =?us-ascii?q?9a23=3AAaWbexLU3HAdeSKIA9mcpTVXNCE6p7X5OBIU4Z?= =?us-ascii?q?M7irVIN76u5InmIFeBvad2lFGcW4Ld5roEkOfQv636EU04qZea+DFnEtRXUg?= =?us-ascii?q?Mdz8AfngguGsmAXFfhJf7vZioSF8VZX1gj9Ha+YgBY?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AOAABF81pd/4wNJK1mGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBVQIBAQEBAQsBgURQA21VIAQLKoQfg0cDinqCXIlejge?= =?us-ascii?q?BLoEkA1QJAQEBDAEBHw4CAQGEPwIXgw8jNgcOAgUBAQQBAQECAQYEbYUnDIV?= =?us-ascii?q?KAQEBAQIBEhERDAEBNwEPAgEIDgoCAiYCAgIfERUQAgQBDQUigwABgWoDDg8?= =?us-ascii?q?BAqArAoE4iGFzgTKCegEBBYUODQuCFAMGgQwoAYtoF4FAP4E4H4JMPoIaRwK?= =?us-ascii?q?BeIJ0MoIEIo5kMY4RjW9ACQKCHYZoiVgEg3UbmESNWodigXqOLwIEAgQFAg4?= =?us-ascii?q?BAQWBVwIvgVhwFWUBgkGCQoNyilNygSmNVwEB?=
X-IronPort-AV: E=Sophos;i="5.64,406,1559520000"; d="scan'208";a="309881452"
Received: from alln-core-7.cisco.com ([173.36.13.140]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 19 Aug 2019 19:11:10 +0000
Received: from XCH-ALN-001.cisco.com (xch-aln-001.cisco.com [173.36.7.11]) by alln-core-7.cisco.com (8.15.2/8.15.2) with ESMTPS id x7JJBARl026439 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 19 Aug 2019 19:11:10 GMT
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by XCH-ALN-001.cisco.com (173.36.7.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 19 Aug 2019 14:11:10 -0500
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 19 Aug 2019 14:11:09 -0500
Received: from NAM01-BY2-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 19 Aug 2019 15:11:09 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hh3fI0AvbYonxUGJpWogdcrTI9F8CInNlkWL7TUIJvH8Z341oqzVd3yke0uLQ1lYDmnNyRq2/OO3DkBh5A1cnvxZ+/KXiOKPvJdvqw8YTDJPknvRZquL8+yO6d0o70cKnBCZLphoKzSeZRYztrVwPsoErzF5qjAN7KjE/hBKylhJQL3Xnljcr0F2CBDA30jJuVcOvNvuNU7XK5fhfVg89UCdZ3A3PeJmTE4LUbX98QRlH+Xi3d7eX1Ogj2/54338DhdiFt7YO09O9bN8zwtRx7FhRUycvez0Y3aVVbfbT0YXr4XxC2Lsgb66qmzr8EXrLnakUuMloy8xKIH+lDgk3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gSs47GIuv/9kVRNABlIfYakquGLi+VjYKyAFQCP/qhs=; b=FwXqx0Z/YhlKOB+Os05L8QIDhizeTUjJi4h6kslvbMF4884/zxSIypv8dkUf7Zxb3vsJy8NHzcqRatYYWn4XlacBl6HWC46lFoWuZjT4a7m5bY/E1wtoW+ZtdSbARglWUTn2V/Ea5auX+lObBzMOq8oslvvcklnaDjRV08aDNCSElINrWeiQccOLIMERJdOvIGdXbCe++aegR12yPpiMxQ1Wc5dZwYddas9NdZD1Uycho5kmoFsqMpT3quO+FHyOhC2sQvTZXYDhCzE7khpecq1MxW39EDb2UmvnitQALYMJJkpoXWg178EJwGC2HEFy2SwmozLQAVM85RiFBMgIgA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gSs47GIuv/9kVRNABlIfYakquGLi+VjYKyAFQCP/qhs=; b=dKBvaJzPicHbS3z2zE3bOpbe2l50+CDZ4rlFpaZ/5yXmEy7F5M1JQFXyfTvA3IGnjiuZxVYzZIVIdKgXNhkkjItwfeXhJXtUTsdxVVMftmizQjpRlYjpckz91+dkGzRYijrKdQLZ2dS0EVTUDGCuO65fHND+0u0A9PuXo08vyDc=
Received: from MN2PR11MB4157.namprd11.prod.outlook.com (20.179.150.223) by MN2PR11MB4430.namprd11.prod.outlook.com (52.135.39.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16; Mon, 19 Aug 2019 19:11:08 +0000
Received: from MN2PR11MB4157.namprd11.prod.outlook.com ([fe80::80bb:d4b:bc47:7daf]) by MN2PR11MB4157.namprd11.prod.outlook.com ([fe80::80bb:d4b:bc47:7daf%3]) with mapi id 15.20.2178.018; Mon, 19 Aug 2019 19:11:08 +0000
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: Mahesh Jethanandani <mjethanandani@gmail.com>, =?utf-8?B?TWFydGluIEJqw7Zya2x1bmQ=?= <mbj@tail-f.com>
CC: YANG Doctors <yang-doctors@ietf.org>, "rtg-bfd@ietf. org" <rtg-bfd@ietf.org>, "draft-ietf-bfd-unsolicited.all@ietf.org" <draft-ietf-bfd-unsolicited.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-bfd-yang@ietf.org" <draft-ietf-bfd-yang@ietf.org>
Subject: Re: Yangdoctors early review of draft-ietf-bfd-unsolicited-01
Thread-Topic: Yangdoctors early review of draft-ietf-bfd-unsolicited-01
Thread-Index: AQHVVoFcW4RvcvlvFUaeAOxMqn9qZqcCz2yA///ENgA=
Date: Mon, 19 Aug 2019 19:11:07 +0000
Message-ID: <22279DB9-A0F3-4D5E-BFDC-38B2AD5B109F@cisco.com>
References: <156621414936.19813.853283734958376284@ietfa.amsl.com> <0CD4CB48-9382-4724-A5A6-A7B0DE7D7D57@gmail.com>
In-Reply-To: <0CD4CB48-9382-4724-A5A6-A7B0DE7D7D57@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1a.0.190609
authentication-results: spf=none (sender IP is ) smtp.mailfrom=rrahman@cisco.com;
x-originating-ip: [2001:420:2840:1250:6900:eb73:e481:aee6]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5e953d6f-fa94-473b-3c9c-08d724d8fd75
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR11MB4430;
x-ms-traffictypediagnostic: MN2PR11MB4430:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <MN2PR11MB4430C609F1A4D65077AEBC8DABA80@MN2PR11MB4430.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0134AD334F
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(136003)(376002)(346002)(396003)(189003)(199004)(229853002)(486006)(53936002)(81166006)(8676002)(6486002)(6436002)(54906003)(53546011)(6506007)(6512007)(6306002)(256004)(186003)(86362001)(11346002)(7736002)(476003)(2616005)(36756003)(64756008)(305945005)(66476007)(66556008)(66446008)(66946007)(76116006)(46003)(446003)(2906002)(6116002)(81156014)(99286004)(71190400001)(71200400001)(76176011)(33656002)(478600001)(966005)(14454004)(8936002)(316002)(25786009)(110136005)(102836004)(4326008)(58126008)(5660300002)(6246003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4430; H:MN2PR11MB4157.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: bkxo5/PZCOFEpWaWJOMxCAcKuIusmZWAqILRZBH4Tfzg7m8mytFufP2zPHpAKhGZGt8EkHfLylF3aseYS3vzR55n2rYXNBz19nlC8ooCVD59J5SO6SwglIT/Yr/S4/Iz5YLEiEAp1ZojXUB54xtjvp8zyGjFLUBQ3jocKker/30OlVmB7lWBlhaSn0JZeWpJRDdHF6/ssIVOp1u0VCPhJ2AD0a6OCI3M3orJ3nZkrMoWYC/A3o+c8UiTaaTMqPZL6q3swX4yZwM8NyE6agzkU3kBg+cfiTETfWfu/Nf/DukF+LH4qcD3Dt9K12dV0el8qRzMZC4/1kn5nc4IL/hdB3Tz4RXSYIpXAMojN3EWCgIk0Y7ZhM9266kZ1sQn6hjEKuTfYJtuZl4JjJORTGpLUoyTAML6QDixesisb07rmQA=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <15CAFDD79BA38F43A759E6646FA78E1E@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e953d6f-fa94-473b-3c9c-08d724d8fd75
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Aug 2019 19:11:07.9119 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b1r4GDl57Um+GOeCTGBa69xZcnALm9fsCrtHyOQGEqIRCvZw0552QrzUe4lQl9dJtvugpDMYNlilSbM/Z0D6IQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4430
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.11, xch-aln-001.cisco.com
X-Outbound-Node: alln-core-7.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/wREmabS-VXMFViXq-CD3Pg-STDc>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Aug 2019 19:11:17 -0000

Thanks Martin and Mahesh.

I believe we should add a mandatory statement to the choic (speaking as BFD YANG co-author,)

Just created https://github.com/bfd-wg

Regards,
Reshad.


On 2019-08-19, 2:45 PM, "Mahesh Jethanandani" <mjethanandani@gmail.com>; wrote:

    [Adding the authors of BFD YANG module]
    
    Martin brings up a good point. But since the document that contains ietf-bfd-types is sitting in RFC Ed Queue, this will have to go into a bis document.
    
    Chairs, could you create a bfd-wg in GitHub for us to track this as an issue to be fixed as part of a bis document?
    
    > On Aug 19, 2019, at 4:29 AM, Martin Björklund via Datatracker <noreply@ietf.org>; wrote:
    > 
    > Reviewer: Martin Björklund
    > Review result: Ready with Nits
    > 
    > I have reviewed this document from a YANG model perspective only.
    > 
    > My only comment is actually for a grouping defined in ietf-bfd-type, but used
    > in this module.  There is a choice "interval-config-type":
    > 
    >  +--rw unsolicited {bfd-unsol:unsolicited-params-global}?
    >       +--rw enable?                           boolean
    >       +--rw local-multiplier?                 multiplier
    >       +--rw (interval-config-type)?
    >          +--:(tx-rx-intervals)
    >          |  +--rw desired-min-tx-interval?    uint32
    >          |  +--rw required-min-rx-interval?   uint32
    >          +--:(single-interval) {single-minimum-interval}?
    >             +--rw min-interval?               uint32
    > 
    > This choice is not mandatory and doesn't have a default case, so the question
    > is what happens if no nodes from the choice has been configured?   I would
    > expect the choice to have a default case (but this then would apply to
    > ietf-bfd-types, not this document.)
    > 
    > 
    
    Mahesh Jethanandani
    mjethanandani@gmail.com