[RTG-DIR]Re: RtgDir Last Call review of draft-ietf-opsawg-teas-attachment-circuit-11
Donald Eastlake <d3e3e3@gmail.com> Tue, 14 May 2024 17:29 UTC
Return-Path: <d3e3e3@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 66568C14F68E; Tue, 14 May 2024 10:29:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.601
X-Spam-Level:
X-Spam-Status: No, score=-5.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, NORMAL_HTTP_TO_IP=0.001, NUMERIC_HTTP_ADDR=1.242, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z22uPZGoecSk; Tue, 14 May 2024 10:29:32 -0700 (PDT)
Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1FEF8C14F5FC; Tue, 14 May 2024 10:29:32 -0700 (PDT)
Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-43dfd4c323dso25500051cf.0; Tue, 14 May 2024 10:29:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715707770; x=1716312570; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LPrQHAObkfheAUe7lOGRibp6P3UfhV2Q2ol2WV4512s=; b=MtSbQcxfg6eDNgaYo+88RJX2AIeVvbXwEceqb6SyZTlSb4ufk1guqKMKMSi8o4EGZB 9feYJeqo22/m2RTHsPWGSe4zKVQ5dxJtniyweFvzQU8Osz3kBN4YylRUEotxy3gDGKyl RLNYdHvM8wnPicVxpjxW7IlETBmn9F4ukBSf64oDf8T/6rZ0WaTAcXVeo6rRTHahZNxA iE2FrjmgzLJOjHgj2Kaq/I4TvXmfGfs4LpMcb1Mkc+SuUILMUUkrnNR8/oKb4OrJYFp0 MfWheJEp17zpGf4553JRcvx9STSCquT1Kig0nezFw7kxdH10HbkxTMgJp2SkW8GZQtc8 SMGQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715707770; x=1716312570; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LPrQHAObkfheAUe7lOGRibp6P3UfhV2Q2ol2WV4512s=; b=GlQkyzyKLB3QI5M2KRL/JNsZe3idvTgkL5xAzLwYrVVHVeufdPQNdDPb9+FmEOPWUn 9wzfgqhJ7KgmPQWHnBgkXlAZ2suJPuLGEy8EG/b//3K5X4pFNFKvzndDMZm9ePOtGT1c SCzayGj3Jzn4Hr3KX4NS24FRuIuCZG1QxkfXTsEbU8DNw8wSt1Qjf3tGKOmdZ/prIBiO uh9CZz/gI/zWnhFH4Pi42Avb0V7l3JSddvXMvH040GieEhGnCeAUKX3giKRNxfJnjkLe fZFIVxu0aeLQ47AS+QBsokclWLzy46aW4n+GtJjh1I4ihtDZCugI+G7ZpRjJckraWblh Llog==
X-Forwarded-Encrypted: i=1; AJvYcCW4LspKiJ929TQfWcyqsVckDJN5PVQlMJ4cMKZmXHORg52J44FJJtQK8IqYbT/NUyKUplSVglBYyTVUpRUGcYRzk6hHro9OSs9jyBAD/cx32KEUNETPCS/vg3SlIR+GC08qKtDiPBQRvPSRWM+7zB9CyQ8+ag==
X-Gm-Message-State: AOJu0YynlX0xiVFWST36dNOXvkofyQdEFVpIkdonUxZCFBgh/olHvWk6 cSEgp93o0/NmUpbHmWr1FzoGXhlbhbZImc+0i+5rW7m7NkcKRDDB58y+CFtHFG2b4yr5JNNc0UZ ltY68gwQh76z9DGthOgQqTx/Xwq8=
X-Google-Smtp-Source: AGHT+IH86bPsXJzEzUYnf9MGZBW+L/ADGGQPanUsL9nGsFg8a5IsajQZCNtjTGcuMryi2OIgMPCyrPZg4XNB6ikY5Xs=
X-Received: by 2002:ac8:7fcb:0:b0:43a:d899:9089 with SMTP id d75a77b69052e-43dfdb9185bmr148598471cf.41.1715707770609; Tue, 14 May 2024 10:29:30 -0700 (PDT)
MIME-Version: 1.0
References: <CAF4+nEGLUWctvg8_8a-nNy0MifdeDi8DrTyDVNBjj3F+g=9Vhw@mail.gmail.com> <DU2PR02MB10160481119018C6AFEE07F4A88E22@DU2PR02MB10160.eurprd02.prod.outlook.com>
In-Reply-To: <DU2PR02MB10160481119018C6AFEE07F4A88E22@DU2PR02MB10160.eurprd02.prod.outlook.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Tue, 14 May 2024 13:29:18 -0400
Message-ID: <CAF4+nEEBBJrA-USoVskMiFf=EuCehicJ4NOwzGhm_namMzvWig@mail.gmail.com>
To: mohamed.boucadair@orange.com
Content-Type: multipart/alternative; boundary="00000000000034a70606186d588f"
Message-ID-Hash: 4DOYBKQB73VB6URVGCP62EPNN3ZCAE42
X-Message-ID-Hash: 4DOYBKQB73VB6URVGCP62EPNN3ZCAE42
X-MailFrom: d3e3e3@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-rtg-dir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "<rtg-ads@ietf.org> (rtg-ads@ietf.org)" <rtg-ads@ietf.org>, Routing Directorate <rtg-dir@ietf.org>, "teas@ietf.org" <teas@ietf.org>, Last Call <last-call@ietf.org>, "opsawg@ietf.org" <opsawg@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [RTG-DIR]Re: RtgDir Last Call review of draft-ietf-opsawg-teas-attachment-circuit-11
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/-IJ_CrO_4GGHgZWyY_oC5QzJlYM>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Owner: <mailto:rtg-dir-owner@ietf.org>
List-Post: <mailto:rtg-dir@ietf.org>
List-Subscribe: <mailto:rtg-dir-join@ietf.org>
List-Unsubscribe: <mailto:rtg-dir-leave@ietf.org>
Hi Med, Thanks for accepting most of my suggestions. I consider my comments to have been resolved. Thanks, Donald =============================== Donald E. Eastlake 3rd +1-508-333-2270 (cell) 2386 Panoramic Circle, Apopka, FL 32703 USA d3e3e3@gmail.com On Mon, May 13, 2024 at 7:46 AM <mohamed.boucadair@orange.com> wrote: > Hi Donald, > > Thank you for the review. > > I like the suggestions. I went with almost all of them (except the one > about the ToC) as you can see in the candidate version: > https://boucadair.github.io/attachment-circuit-model/draft-ietf-opsawg-teas-attachment-circuit.txt > . > > Cheers, > Med > > > -----Message d'origine----- > > De : Donald Eastlake <d3e3e3@gmail.com> > > Envoyé : vendredi 10 mai 2024 23:19 > > À : <rtg-ads@ietf.org> (rtg-ads@ietf.org) <rtg-ads@ietf.org> > > Cc : Routing Directorate <rtg-dir@ietf.org>; draft-ietf-opsawg- > > teas-attachment-circuit.all@ietf.org; teas@ietf.org; Last Call > > <last-call@ietf.org> > > Objet : RtgDir Last Call review of draft-ietf-opsawg-teas- > > attachment-circuit-11 > > > > > > Hello, > > > > I have been selected as the Routing Directorate reviewer for this > > draft. The Routing Directorate seeks to review all routing or > > routing-related drafts as they pass through IETF last call and > > IESG review, and sometimes on special request. The purpose of the > > review is to provide assistance to the Routing ADs. For more > > information about the Routing Directorate, please see > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2 > > Fwiki.ietf.org%2Fen%2Fgroup%2Frtg%2FRtgDir&data=05%7C02%7Cmohamed > > .boucadair%40orange.com%7C5e2654d5909a4f91feaa08dc7136edb5%7C90c7 > > a20af34b40bfbc48b9253b6f5d20%7C0%7C0%7C638509727928172271%7CUnkno > > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h > > aWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=DhlZd1ZXwBN4NpT1xyLrHtBMyYD > > K0zA7aUXpJ4cGc%2Fw%3D&reserved=0 > > > > Although these comments are primarily for the use of the Routing > > ADs, it would be helpful if you could consider them along with > > any other IETF Last Call comments that you receive, and strive to > > resolve them through discussion or by updating the draft. > > > > Document: draft-ietf-opsawg-teas-attachment-circuit-11 > > Reviewer: Donald Eastlake > > Review Date: 2024-05-08 > > IETF LC End Date: date-if-known > > Intended Status: Standards Track > > > > Summary: > > > > This document is basically ready for publication but has nits > > that should be considered prior to publication. > > > > This document specifies a YANG service data model for Attachment > > Circuits and a set of reusable groupings. I am not that deep a > > YANG expert but it seems to be in the right direction. > > > > Comments: > > > > I found the writing in this draft to be of good quality and > > readability. I previously review version -07 and it looks like > > the minor issues I found have been fixed and most, but not all, > > of the nits I found have been fixed. > > > > No major issues found. > > > > Minor Issues: > > > > No minor issues found. > > > > Nits: > > > > The Table of Contents only goes down two levels, to Sections > > whose number is of the form n.m. But some sections in Sections 5 > > are five levels deep (n.m.o.p.q). The ToC does not need to go all > > the way to level 5, but I think it should be extended to at least > > level 3. > > > > Section 1.1, next to last paragraph: there is no reason to cite > > that the various identifiers used are ones intended for examples. > > Suggest deleting this paragraph. > > > > Section 2: I suggest adding entries for PE, CE, and NF. > > > > Section 5.2 under 'oper-status': "it is recommended to consider > > both administrative and operational service status values in > > conjunction." > > -> "considering administration and operational service status > > values > > together is recommended." > > > > Section 5.2.2.2: "abovementioned" -> "above mentioned" > > > > Section 7: two extra spaces that should be deleted: > > "nacm:default-deny- write" > > key- string > > > > Section A.11.1, first paragraph: "permits to manage connectivity > > requirements" -> "permits managing connectivity requirements" > > > > A.11.3, fourth bullet point: "permits to handle compute failures" > > -> "permits handling compute failures" > > > > Suggest replacing the two occurrences of "leverages" with "uses". > > > > All references to RFC 5798 should be replaced by references to > > RFC 9568. > > > > The nits checker finds 56 lines too long but that is probably due > > to non-ASCII characters, > > > > Thanks, > > Donald > > =============================== > > Donald E. Eastlake 3rd +1-508-333-2270 (cell) > > 2386 Panoramic Circle, Apopka, FL 32703 USA d3e3e3@gmail.com > > ____________________________________________________________________________________________________________ > Ce message et ses pieces jointes peuvent contenir des informations > confidentielles ou privilegiees et ne doivent donc > pas etre diffuses, exploites ou copies sans autorisation. Si vous avez > recu ce message par erreur, veuillez le signaler > a l'expediteur et le detruire ainsi que les pieces jointes. Les messages > electroniques etant susceptibles d'alteration, > Orange decline toute responsabilite si ce message a ete altere, deforme ou > falsifie. Merci. > > This message and its attachments may contain confidential or privileged > information that may be protected by law; > they should not be distributed, used or copied without authorisation. > If you have received this email in error, please notify the sender and > delete this message and its attachments. > As emails may be altered, Orange is not liable for messages that have been > modified, changed or falsified. > Thank you. > >
- [RTG-DIR]RtgDir Last Call review of draft-ietf-op… Donald Eastlake
- [RTG-DIR]Re: RtgDir Last Call review of draft-iet… mohamed.boucadair
- [RTG-DIR]Re: RtgDir Last Call review of draft-iet… Donald Eastlake