Re: [RTG-DIR] [Lsr] Rtgdir last call review of draft-ietf-lsr-isis-sr-vtn-mt-05

"Hejia (Jia)" <hejia@huawei.com> Thu, 14 December 2023 07:30 UTC

Return-Path: <hejia@huawei.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 55978C14CE2C; Wed, 13 Dec 2023 23:30:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.903
X-Spam-Level:
X-Spam-Status: No, score=-1.903 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5yXFwM1rLOJt; Wed, 13 Dec 2023 23:30:03 -0800 (PST)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E1133C14CF0D; Wed, 13 Dec 2023 23:30:02 -0800 (PST)
Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SrP9R1qKJz6857p; Thu, 14 Dec 2023 15:28:59 +0800 (CST)
Received: from lhrpeml100004.china.huawei.com (unknown [7.191.162.219]) by mail.maildlp.com (Postfix) with ESMTPS id 0E051140D27; Thu, 14 Dec 2023 15:30:01 +0800 (CST)
Received: from dggpemm500002.china.huawei.com (7.185.36.229) by lhrpeml100004.china.huawei.com (7.191.162.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Dec 2023 07:29:59 +0000
Received: from canpemm500009.china.huawei.com (7.192.105.203) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Dec 2023 15:29:57 +0800
Received: from canpemm500009.china.huawei.com ([7.192.105.203]) by canpemm500009.china.huawei.com ([7.192.105.203]) with mapi id 15.01.2507.035; Thu, 14 Dec 2023 15:29:57 +0800
From: "Hejia (Jia)" <hejia@huawei.com>
To: Chongfeng Xie <chongfeng.xie@foxmail.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>
CC: "draft-ietf-lsr-isis-sr-vtn-mt.all" <draft-ietf-lsr-isis-sr-vtn-mt.all@ietf.org>, last-call <last-call@ietf.org>, lsr <lsr@ietf.org>
Thread-Topic: [Lsr] Rtgdir last call review of draft-ietf-lsr-isis-sr-vtn-mt-05
Thread-Index: AdouXz7pn62Aqg9MTNKPIyLpgaOOJQ==
Date: Thu, 14 Dec 2023 07:29:57 +0000
Message-ID: <c3577f8a7a5e43d8ac33de94c99e0d97@huawei.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.50.74.231]
Content-Type: multipart/alternative; boundary="_000_c3577f8a7a5e43d8ac33de94c99e0d97huaweicom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/1wGE8L7ckP3WV5TBsW9r85th9eM>
Subject: Re: [RTG-DIR] [Lsr] Rtgdir last call review of draft-ietf-lsr-isis-sr-vtn-mt-05
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Dec 2023 07:30:08 -0000

Hi Chongfeng,

Thanks for your reply. Your reply looks reasonable.


B.R.
Jia


发件人: Chongfeng Xie [mailto:chongfeng.xie@foxmail.com]
发送时间: 2023年12月12日 13:14
收件人: Hejia (Jia) <hejia@huawei.com<mailto:hejia@huawei.com>>; rtg-dir@ietf.org<mailto:rtg-dir@ietf.org>
抄送: draft-ietf-lsr-isis-sr-vtn-mt.all <draft-ietf-lsr-isis-sr-vtn-mt.all@ietf.org<mailto:draft-ietf-lsr-isis-sr-vtn-mt.all@ietf.org>>; last-call <last-call@ietf.org<mailto:last-call@ietf.org>>; lsr <lsr@ietf.org<mailto:lsr@ietf.org>>
主题: Re: [Lsr] Rtgdir last call review of draft-ietf-lsr-isis-sr-vtn-mt-05



Hi Jia,

Thanks for the review comments.

I see your major comment is about the terminology alignment, as replied to Daniele, we will follow the decision in TEAS to update the terminologies in next revision.

Please see some replies to the minor issues inline:


From: He Jia via Datatracker<mailto:noreply@ietf.org>
Date: 2023-12-11 16:09
To: rtg-dir@ietf.org<mailto:rtg-dir@ietf.org>
CC: draft-ietf-lsr-isis-sr-vtn-mt.all<mailto:draft-ietf-lsr-isis-sr-vtn-mt.all@ietf.org>; last-call<mailto:last-call@ietf.org>; lsr<mailto:lsr@ietf.org>
Subject: [Lsr] Rtgdir last call review of draft-ietf-lsr-isis-sr-vtn-mt-05
Reviewer: He Jia
Review result: Not Ready

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The
Routing Directorate seeks to review all routing or routing-related drafts as
they pass through IETF last call and IESG review, and sometimes on special
request. The purpose of the review is to provide assistance to the Routing ADs.
For more information about the Routing Directorate, please see
https://wiki.ietf.org/en/group/rtg/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would
be helpful if you could consider them along with any other IETF Last Call
comments that you receive, and strive to resolve them through discussion or by
updating the draft.

Document: draft-ietf-lsr-isis-sr-vtn-mt-05
Reviewer: Jia He
Review Date: December 10, 2023
IETF LC End Date: date-if-known
Intended Status: Informational

Summary:
I have read the review comments from Daniele about the concept of enhanced VPN,
and the relationship with other existing terms. I agree with his suggestion to
follow the discussion and align the draft with the output. In addition, some
minor issues and also nits are found out as follows and should be considered
prior to publication.

Minor Issues:
1、In Section 1, it is said "Segment Identifiers (SIDs) can be used to represent
both the topological instructions and the set of network resources allocated by
network nodes to a VTN." Is it "allocated by network nodes" or "allocated to
network nodes"? If it is "network resources allocated by network nodes", why
not "allocated by centralized controllers" as well? If it is "network resources
allocated to network nodes" which are assocated with a VTN, why not " allocated
to network links" as well? Is there any special consideration by saying
"network nodes" only here?

[Chongfeng]: The description is a little bit confusing, actually it should be "network resources of the network nodes and links which are allocated to a VTN/NRP". We will update it in next revision.




2、In Section 4, "For SRv6 data plane, the SRv6 SIDs associated with the same
VTN can be used together to build SRv6 paths with the topological and resource
constraints of the VTN taken into consideration." Is "SRv6 Locator" missing?

[Chongfeng] SRv6 Locator is the covering prefix part of the SRv6 SIDs. In SRv6 segment list, the SRv6 SIDs are used to indicate the forwarding path and the set of resources used for packet processing. So the description is correct.


Nits:
1、Section 2, TLV 223 (MT IS Neighbor Attribute) is defined in RFC 5311, which
is not referenced in the draft. 2、Section 1,  Paragraph 3, last sentence,
s/...need to be distributed using control plane/...need to be distributed using
a control plane 3、Section 2, Paragraph 1, last sentecne, s/MT-ID could be used
as the identifier of VTN in control plane./MT-ID could be used as the
identifier of VTN in the control plane. 4、Section 2, "IS-IS Multi-Topology
[RFC5120]" and "IS-IS Multi-Topology Routing (MTR) [RFC5120]" are both used in
the draft. It is suggested to keep consistent throughout the draft.


[Chongfeng] Thanks for catching the nits, we will resolve them in next revision.

Best regards,
Chongfeng



_______________________________________________
Lsr mailing list
Lsr@ietf.org<mailto:Lsr@ietf.org>
https://www.ietf.org/mailman/listinfo/lsr