[RTG-DIR] RtgDir review: draft-ietf-pce-stateful-pce-p2mp-10.txt

"Andrew G. Malis" <agmalis@gmail.com> Mon, 18 February 2019 21:03 UTC

Return-Path: <agmalis@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id 5D2C8130E6B; Mon, 18 Feb 2019 13:03:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id gxrdSCoNxPkT; Mon, 18 Feb 2019 13:03:55 -0800 (PST)
Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 86406128BCC; Mon, 18 Feb 2019 13:03:52 -0800 (PST)
Received: by mail-qk1-x733.google.com with SMTP id r21so10782737qkl.11; Mon, 18 Feb 2019 13:03:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=AmHKDosH+0jFlqRjsYXMcuAmSH6KOFFW8T6/2/brlGM=; b=FfsFg+lGI1g5jlG7LdOorrXvsT60H8OQ5BJ0w2M7ijfeR9VzWxau8mB4kL0DAKMQfj 4L7phIlZzkAOxf7+7Dw9CqT2TDqxmMEqUXGc/oLLAmuTWH97T+1PCMmY5ikuz0z/JjKN D6uFcgneKclJmzOh5d2wHlqcKdLsp8eA8JS+qC6lESFGFO3zMP1HwbFlDSgBc2gGLtV3 mo0kpThzBrU7bcAsX6M8tHR0vgXKNIyqKXvt2oEQV7DpHjCwgfpVCkrv2a/gHgskRZEz DoRXoe8tmmCjZ77qethqeiyBUtPArNeoCdQ0XNKmWh6H6LCnquUTH8jV+2MjYHU8xP5/ a/Xw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=AmHKDosH+0jFlqRjsYXMcuAmSH6KOFFW8T6/2/brlGM=; b=i0706qCtqH1QJrJ9VkyL2AVjXGYiiRT6YKKgL0IZXkFrdPMLUOVRPr4hCIwcATTN0n WGj9OJbIDAQ3gClRp55z9mlRXbRjMQG8kC26TAPrqyLlD8kbpWDOqHkDGRn7aLpVG5kk V8hb4O2jM3t9/GBe6XsE9GuOIQB/5quB4fd0yssAcOwVeNZZdCI8XSOYsHfQ0iDm9OHf S36zknPrHpNXOv5pXe0t+3OJYn0gH8AtM39EMVHtrPv6wd2xThtYT9ktBr9ZHlQO3fDG yNV4HuB23LXpzclM8SHcetcBRZ+8m6DuvFRbVtTMg+5B3rFyzBdGoHBcyNJvKwZ5Znju FRZw==
X-Gm-Message-State: AHQUAua+t5B1sb60i2xr7qMm7tudsjFw8X14mK9F2j57UCuHpMgEact9 Hh//Ua9pvUenJeYFWUwa4j2u0RJgHtSUJOZyNC5gs84u
X-Google-Smtp-Source: AHgI3IaUNzCi0C34oXGS3dDmmjR1uCFhzOZea7EU06ETFYST3slw1ntPuOExysAlYhESV/xgCkZz8FbMor0fEYkvuOI=
X-Received: by 2002:a37:4a4d:: with SMTP id x74mr18089849qka.61.1550523831253; Mon, 18 Feb 2019 13:03:51 -0800 (PST)
MIME-Version: 1.0
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Mon, 18 Feb 2019 16:03:40 -0500
Message-ID: <CAA=duU0tv-q5BRg3nudfnao-DYwf2YVLcERGZBvjp+X2tBv38A@mail.gmail.com>
To: "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>
Cc: rtg-dir@ietf.org, draft-ietf-pce-stateful-pce-p2mp.all@ietf.org, pce@ietf.org
Content-Type: multipart/alternative; boundary="0000000000002d8006058231765b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/4JT3MmfDbgF_UBLu7f8iQDM7o10>
Subject: [RTG-DIR] RtgDir review: draft-ietf-pce-stateful-pce-p2mp-10.txt
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Feb 2019 21:03:59 -0000


I have been selected as the Routing Directorate reviewer for this draft.
The Routing Directorate seeks to review all routing or routing-related
drafts as they pass through IETF last call and IESG review, and sometimes
on special request. The purpose of the review is to provide assistance to
the Routing ADs. For more information about the Routing Directorate, please
see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it
would be helpful if you could consider them along with any other IETF Last
Call comments that you receive, and strive to resolve them through
discussion or by updating the draft.

Document: draft-ietf-pce-stateful-pce-p2mp-10.txt
Reviewer: Andy Malis
Review Date: 18 February 2019
IETF LC End Date: N/A (in preparation for IETF LC)
Intended Status: Standards Track


This document is basically ready for publication, but has nits that should
be considered prior to publication.


It was very easy to follow the draft. Excellent work by all involved.

Major issues:

No major issues found.

Minor Issues:

No minor issues found.


1. Section 3.1, second paragraph:

For P2MP this is an added advantage, where the size of message is much

For P2MP, where the size of message is much larger, this is an added

2. Section 5.1, fifth paragraph:

Path Computation LSP Initiate Message (PCInitiate):  is a PCEP

Path Computation LSP Initiate Message (PCInitiate): PCInitiate is a PCEP

3. Section 5.2, first paragraph:

PCEP speakers advertise Stateful capability via STATEFUL-PCE-CAPABILITY TLV
in open message.

PCEP speakers advertise Stateful capability via the STATEFUL-PCE-CAPABILITY
TLV in the OPEN object.

4. Section 5.2, third paragraph (N Flag): In two places, replace "changes"
with "change".

5. Section 5.3, first paragraph: Expand "LSR" (Label Switching Router) on
first use. It's not on the RFC Editor's list of well-known acronyms.

6. Section 5.3, second paragraph: Expand "PCED" (PCE Discovery TLV) on
first use.

7. Section 6.2, last paragraph: A right ")" is missing at the end of the

8. Section 6.5, first paragraph: In the second line, replace the comma with
a period and capitalize the following "this".

9. Section 6.5, last paragraph: A right ")" is missing at the end of the

10. Section 8, second paragraph: Add the word "The" to the start of the

11. Section 11.2, first paragraph. Change "and a registry was created" to
"and the STATEFUL-PCE-CAPABILITY TLV Flag Field subregistry was created"

12. Section 11.3, first paragraph: Change "and a registry was created" to
"and the LSP Object Flag Field subregistry was created"