[RTG-DIR]Re: Rtgdir early review of draft-ietf-pce-pcep-yang-25

"Matthew Bocci (Nokia)" <matthew.bocci@nokia.com> Tue, 22 October 2024 11:04 UTC

Return-Path: <matthew.bocci@nokia.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9B855C14CE5D; Tue, 22 Oct 2024 04:04:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.254
X-Spam-Level:
X-Spam-Status: No, score=-2.254 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.148, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=nokia.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lND-UUN8gENc; Tue, 22 Oct 2024 04:04:54 -0700 (PDT)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2083.outbound.protection.outlook.com [40.107.21.83]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E16BFC1FD76F; Tue, 22 Oct 2024 04:04:06 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JSRZC9krb0ePxmz2NiZZdj8LK+mGc0JF+kNRsG7VnswMskLu42awqbPtTZLFqjisbuv79lgIZjlDBoIvW7BYWY6rtRNIioZ7A/7HVdFGOwaef2HIcV14M6ce2Hat1LHTne8703soKN7cEQCop+Dn9c0MM5BWtX42obzv6Tv7I3ESxAP+BQ8Xuc02TWpl4G56rJGZRdCpoXMIC83pJ/InxdA/4Ovjg6hVirqxhXNBlsdS+4CLar3ZpqCQfFpfpryJoTRF8CJ+QLC4ZpF6jQyA5P1kQPrzWuGgXzzHo6wIsiyjesUqfIO7mx2DG5D6TL5AmUQF6pS39X5pdNOB1/wlQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0uEM7yL2Z0xDZVkU6WPWT5a8va0/xU12DgYnsSwZdgs=; b=XEuy1PyEZnLc8a7uKZ1crRuSCqSZwtDT54Fnb5jAuPCI6tcIhzQuqV18qzgK4Js7rkZa7QhKOGK/dTDEmgFlFZKl8n0gX20U41xGRlwPqKAto6vwuiTqD6e6H7e2WT6EeEtdMWC74mNIGlMtyig6QOlTjsEbzY2FBreOD9IHQU2WgYDDxxmTNsYD2Ju1CZuxfgZyzuq/06z027lRdgT0AcDsVwxLymq6EOtw4whLhJ/yTHX0PfWvAwrPitUr6y1/bLoMAwy2SyjiT7o8hKmPnRgLYvm3qwPKOAGddzYw7TPMVR14dIsCdkgWyMyvz4WWifOXm5oqG9GgEkmx+PvZgg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0uEM7yL2Z0xDZVkU6WPWT5a8va0/xU12DgYnsSwZdgs=; b=hvWhnoIcXzEPfoQ6bB9SNeaPHoh9bGnC7RF5Nf2NTOTrRmHuK27YZjnPSUeinLUTiMUBGbUnbg3BIc5EJnRMd65BwphQAD0ik1ZK51T3RweTjqL8OplrrU1OC8boOPIUC5AZ1wcyK6NopQt+P7o4lu+UcNLckNEG/uMmXOezpXb35+qAPHLHbmfTfCdiJQUZaeFrB5QqoCkQqnNV88Ld7blGxbK+t0MLbUHMppIQ3BCndKRMIHvYvoGzMHU55lDsa8CkFQtMZQz8umwdDD6G3OsH7CWWdDME0PwtQ5Fg8Itg3QzOBaBW5maUq+SzKoOVYKIqQDNuVkM2Ex6m42Ph4Q==
Received: from VI1PR0702MB3567.eurprd07.prod.outlook.com (2603:10a6:803:c::10) by AM8PR07MB8145.eurprd07.prod.outlook.com (2603:10a6:20b:320::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Tue, 22 Oct 2024 11:04:03 +0000
Received: from VI1PR0702MB3567.eurprd07.prod.outlook.com ([fe80::3bd2:999:b00c:394a]) by VI1PR0702MB3567.eurprd07.prod.outlook.com ([fe80::3bd2:999:b00c:394a%3]) with mapi id 15.20.8048.020; Tue, 22 Oct 2024 11:04:03 +0000
From: "Matthew Bocci (Nokia)" <matthew.bocci@nokia.com>
To: Dhruv Dhody <dd@dhruvdhody.com>
Thread-Topic: Rtgdir early review of draft-ietf-pce-pcep-yang-25
Thread-Index: AQHbIhpg8gGPg1INgki4MrP8t3GZabKSnvzc
Date: Tue, 22 Oct 2024 11:03:56 +0000
Message-ID: <VI1PR0702MB3567DFB20F7B6DF86D74FD6BEB4C2@VI1PR0702MB3567.eurprd07.prod.outlook.com>
References: <172899741008.1013253.9166432356869610013@dt-datatracker-78dc5ccf94-w8wgc> <CAP7zK5ZTWTNCqrEPhgGcZhwbA=rbskbL410DF1RfwMxeVNg3PA@mail.gmail.com>
In-Reply-To: <CAP7zK5ZTWTNCqrEPhgGcZhwbA=rbskbL410DF1RfwMxeVNg3PA@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-reactions: allow
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR0702MB3567:EE_|AM8PR07MB8145:EE_
x-ms-office365-filtering-correlation-id: a38a6e63-3751-4727-bb13-08dcf2893d50
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|8096899003|38070700018;
x-microsoft-antispam-message-info: 93OiQNZuk168aLGNJfeCOJMZUpb2X8uz3kn+RVsd/CcuVAB8rWQN8Ctvl9lnmWZykP6DgZGPy8n1XlF0lnS1G8nJV6/B+pIQiTQbYeCF1gngs4P/UmKmHf4d6z+EP9YF89Fxa318ab+rp73mQH/4rcKTbE4+VSUKMbJ5hte9UBbXlcHF4qN9k8FbpBnhceJ8Ayu5BpXrXzAO7w/YyxjKeUDXwZbmCKH5mg7VMluzRciC5WgP6fw/0C+EIbzNwwcjsKCzwG/2McCN4pnYNCiA2B4e9eTOssFCxir8MYpbvryaadNYasT5iN9J+ILbOxiYBNnFtmrto4w3VokI/1FziIshguueQ4WwI7fcG3GyF9SA1fBrKNu3EnoMxnnIVd4LQHMT/vlhZV/WR2W3c3E9n+8L7PKEQz0tRMAUj4801rsuoAbLMI6zsTbPiUPBXgntj8vg2uQdVbGOPabqr3pcgU2Yb3zr4XD2CD+sz5KdfHLo1TOXiBkXp00nC5giHfhkqAgsl4+Z1VvZ4fYNONL6RMcMMw4Z5h9hpbNoWucwwdE3+9P94asT65ayFdzhS92wuvJQk8m0hv24178bE/ONbavAx3PSxQygRPd9xXji398SnAnCH1YbSbNX2QcxoIlTPDLhYCJXtYeF60lr/U/2BXPb4UIG/t4XlbW5lNNiqkfazlMwkKyO07Q/TIvhz02oAA2GpTVo7ANbknLY4/bsINGzM3wKmHOM8e9nle1gnBgFAFuKmhwsqdykR8KEYzI6wye8L5SLRt7iQkyA6TX4FUUNmEAbIwHTnRnlXWfBi8QlsdMD6NhSNuHVfk3XaT0rDVzKm1hGU6xv7HyHvjMDTRhVzpl0FfYcmtC3qahbH0G/fgpNzyTCoKcCDRpLG1QMxqb5Vt4E2306Mn0EdD6ufCThC4vi12muivHjqo5GQrTIhSAf0hTM119RcLNWVHis5s5X7AaiY/Bu/1ti/KEI4/Eh3RXAo6VLNjNbNkGuJvHlEBtYfR458G11d98xuZWRpG3SnkqMpFu+KATnyTUT+UVNyN/L3+KfJYo+wRsvwixW8NDKOJojVksb9kaUNfIElqvATTwZxYoXTvxK73hjDanz6XTZFSI/rE69C40DWtm/ypvoDP1fwtY/ppGbfvrcICgVzS0+CxcEaRFlKkO8WvR3N4Yt7j7Lfp0N8l4q6TT7XZg2ZcTHVrmOz7W0mKeS7tYoOXWEUYAeKa05XusfMFqOrgl5WGtCE19QazRcV1o7xr8HKxVumkx84NlBSudQdyDGcjIRJ5elq5bDV05gm9256OGqd1qhg9GxvIoZDQetmXTp9Xzv8cYoOqFHXT8nwilLSmzbATu08YrNGAGnNw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0702MB3567.eurprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(8096899003)(38070700018);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: sFG1foOnxBqP4q4RaOrasFBqSavst/02IHxakjXPWqpLPbLvHuWd7WyyFSgRl1beDx6OSp4xSJAf/3yRHNdXEFfS0lyBaHNfbj/MIyTnX6yE+c5+d/2Y+ShwJTy/fj6Vi+v2XK3+dAQLivol87RKF7i1NE+cBh3L71d3cwRi+ECPI0M13w4DeJjbPi5aPBOq/6LkUBRufnk/qzcfokxb7PY27hYDSRPpNvDNDZOuuVdb/ZDVN4kVLK8aRLj7eGQROT9KiKpN59c560qg0a995H+gMfkH9JXyxnC5+SD1Xg6qot0k+TIH9BkeBqzK/lzTQxxcx9xKdMqvbcIy5w8lIFW03ljfelMHcNX7ZiKGg0mWt+Eac3ZyUDClZ+G2keSrMAVydEVC5ET/RAidHRTSnuzfm2Ac6S2ETwHzuNC0SCwyI7d6JDzTJJOXxQAKLn46dr/dkvhpcPBkiSN+3Lio2+vJxCbq7ma+5MJtCvgU4SnaVibFlAKghx0Vb31OQ/PIm+dpcoYTQcH0qdn5R5VXt63s39A7Od9N6IfHTOsVbIFCUcPuTPuETT26rfSgwV69wv2BugCuKe+hLgPCsZ2zQP9o15RwMWDj/l9c0sU//VMWdbSuSk55yqru5K0Y/dQqjTMBNLs06XAjirZMKMee59x2lhy2KfBmUtRY+VaHZfDCk9b0bgq9Dq9n0O7BE5v9KZ5ibmghV74zC0NxuJ1QXnU2NFFMK5YAHgrVeqRWdysqBDtb3KpAdhJHxn/5h4va5jmXBrsoF0rL8yXTE51nQ3LHkOhQPid7qo4UqCZBZabw93LsWW+EWIQemhNg6nZgd3GwF+tfYoIRdbPpR6Jot22YW1mIzqmrLv2G3TU5mn1RDOvXAfsvkXdcd0Glc7OY31OqHF8UWNirF8AWpqgHnYxAr7Jl/NuQ2w/zayrxC8M2fTTdg8RVslVUAAdpJHNWzdt6Igakna0OqMYs/7KSn6gKmhzfOwWJmn5V1ByFqWOas9xJYmGXV3S540xeWco0pG9ny2UySUz8NKpPd1cntRd+PbDYgMtGzvLl9IyDQN4Azy03fhF9m1+wTp39Iv2XZsqFhiyKH0yQwet0ZpEEyXPZ8j+1Z0nkb+PfeG0ODAuXh0TM08xUHHhYOnimE3t20mtCfKPVpOjNQ2nWFJyVCfjDnNe/LRG3NDEDjguaCjPHdpZKnC2yb3vmpYGM/B4FXMDxkZCvZsm9Ql0Wk2doqcuTKpdNliBEPIVizywhcFKl0yEeZlZRxNEKlKVjrgwHyOWBLyXlw+T5lF2bPjWHZavJfwdvpIUuHy596KRGcjkzPfRsqnyrIqVK2vzzwPEcePyirjP8EcEXbeh2QLDE/MyEOLKBgI35LHXAIrM0/lBlnq97/Kbs0ezt6peUawAtOY3JQCTrDSaUJ2KWwr78i6ojW6BmwuPrfkFVQWnthZz5TwyY0VYxY271glM29DFWyLQQVhKoTYY+aI4GawtYtfFS1XBv75LXQzRRZdVA+H3vYRNSKyOZsn9Ib4Ai/u3r/ZqvClR8W9/ZpNf+06tZk1IXIcOVdI7kb+XfM5ClGm+Q3xNFIpl98IovUasdc/KY
Content-Type: multipart/alternative; boundary="_000_VI1PR0702MB3567DFB20F7B6DF86D74FD6BEB4C2VI1PR0702MB3567_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0702MB3567.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a38a6e63-3751-4727-bb13-08dcf2893d50
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2024 11:04:03.2590 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4f+JeecP3049djRbb55yPvbNiuhTgv5km2eU9f9Ofl/jUZkU6lRtudv4byJ0iJQEg4B0NLHnuUrayDXITpyVCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR07MB8145
Message-ID-Hash: NYMJZLXK36DA7CEPFL3V24AX4GIVVAAU
X-Message-ID-Hash: NYMJZLXK36DA7CEPFL3V24AX4GIVVAAU
X-MailFrom: matthew.bocci@nokia.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-rtg-dir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-pce-pcep-yang.all@ietf.org" <draft-ietf-pce-pcep-yang.all@ietf.org>, "pce@ietf.org" <pce@ietf.org>
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [RTG-DIR]Re: Rtgdir early review of draft-ietf-pce-pcep-yang-25
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/7UWXp_53QITAygpwmJNGIoXIWfk>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Owner: <mailto:rtg-dir-owner@ietf.org>
List-Post: <mailto:rtg-dir@ietf.org>
List-Subscribe: <mailto:rtg-dir-join@ietf.org>
List-Unsubscribe: <mailto:rtg-dir-leave@ietf.org>

Hi Dhruv

Thanks. Looks good to me.

Best regards

Matthew

From: Dhruv Dhody <dd@dhruvdhody.com>
Date: Saturday, 19 October 2024 at 12:31
To: Matthew Bocci (Nokia) <matthew.bocci@nokia.com>
Cc: rtg-dir@ietf.org <rtg-dir@ietf.org>, draft-ietf-pce-pcep-yang.all@ietf.org <draft-ietf-pce-pcep-yang.all@ietf.org>, pce@ietf.org <pce@ietf.org>
Subject: Re: Rtgdir early review of draft-ietf-pce-pcep-yang-25

CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.


Hi Matthew,

Thanks for the feedback.

On Tue, Oct 15, 2024 at 6:33 PM Matthew Bocci via Datatracker <noreply@ietf.org<mailto:noreply@ietf.org>> wrote:
Reviewer: Matthew Bocci
Review result: Has Nits

Thanks for a clear an well written draft. I have reviewed this from the
perspective of my knowledge of PCEP and the way PCCs and PCEs generally work,
rather than going through the YANG with a fine-toothed comb, as I am not really
a YANG expert and I would hope that a YANG doctor's review would cover the
syntax and other correctness of the YANG. I have just a few nits/questions,
below, but otherwise I think the draft is ready for publication.

The line numbers are from the IDNits output.

[snip]
16      Abstract
18         This document defines a YANG data model for the management of Path

s / Path / the Path

Dhruv: Ack


19         Computation Element communications Protocol (PCEP) for communications

[snip]

91      1.  Introduction

93         The Path Computation Element (PCE) defined in [RFC4655] is an entity
94         that is capable of computing a network path or route based on a
95         network graph, and applying computational constraints.  A Path
96         Computation Client (PCC) may make requests to a PCE for paths to be
97         computed.

99         PCEP is the communication protocol between a PCC and PCE and is
100        defined in [RFC5440].  PCEP interactions include path computation
101        requests and path computation replies as well as notifications of
102        specific states related to the use of a PCE in the context of
103        Multiprotocol Label Switching (MPLS) and Generalized MPLS (GMPLS)
104        Traffic Engineering (TE).  [RFC8231] specifies extensions to PCEP to
105        enable stateful control of MPLS TE LSPs.

107        This document defines a YANG [RFC7950] data model for the management
108        of PCEP speakers.  It is important to establish a common data model
109        for how PCEP speakers are identified, configured, and monitored.  The
110        data model includes configuration data and state data.

112        This document contains a specification of the PCEP YANG module,
113        "ietf-pcep" which provides the PCEP [RFC5440] data model.  Further,
114        this document also includes the PCEP statistics YANG module "ietf-
115        pcep-stats" which provides statistics, counters and telemetry data.

117        The PCEP operational state is included in the same tree as the PCEP
118        configuration consistent with Network Management Datastore
119        Architecture (NMDA) [RFC8342].  The origin of the data is indicated
120        as per the origin metadata annotation.

MB> I take the above text to mean that this draft is a YANG model for PCEP when
the data plane is assumed to be MPLS. However, it doesn't quite say that. It
seems to imply that MPLS is the only valid data plane, when in fact SRv6 could
be used and there are drafts related to that. I would suggest rephrasing or
adding text to say the PCEP in general could be used with other data planes,
but we are only modelling MPLS here, or something along those lines. Just to
make it very clear what the scope of the model is.

Dhruv: I think the original text with the references makes sense to talk about MPLS as none of those RFC is thinking beyond MPLS. I have added a sentence to talk about SR - "[RFC8664] and [RFC9603] extend PCEP to support Segment Routing in MPLS and IPv6 respectively." and later in section 6 mentioned that SRv6 is covered in another document.

[snip]
553              |  +--rw inter-layer?            boolean {inter-layer}?
554              |  +--rw h-pce {h-pce}?
555              |     +--rw enabled?    boolean
556              |     +--rw stateful?   boolean {stateful}?
557              |     +--rw role?       hpce-role
558              +--rw msd?                          uint8 {sr}?

MB> The model implies that a PCC could have a MSD configured that is different
from the MSD that is advertised in the IGP, for example. I thought MSD was
really a router/LER-wide property, determined by the underlying datapath
implementation, rather than something to configure, so should this not be YANG
state for the PCC (i.e. ro rather than rw )? This question is also applicable
to line 771 in the draft.

Dhruv: RFC8664 allows MSD to be carried in PCEP independently and exchanged during the PCEP session establishment in the open message as per - https://www.rfc-editor.org/rfc/rfc8664.html#section-4.1.1; this is used when the IGP MSD is somehow unknown at the PCE. But you are correct that this should be marked read-only.

I have uploaded a -26 revision. See https://author-tools.ietf.org/iddiff?url1=draft-ietf-pce-pcep-yang-25&url2=draft-ietf-pce-pcep-yang-26&difftype=--html

Thanks!
Dhruv