Re: [RTG-DIR] Rtgdir last call review of draft-ietf-detnet-mpls-04

Stewart Bryant <stewart.bryant@gmail.com> Tue, 24 December 2019 14:26 UTC

Return-Path: <stewart.bryant@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E37A1200CD; Tue, 24 Dec 2019 06:26:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4LDqSDo9gQRE; Tue, 24 Dec 2019 06:26:11 -0800 (PST)
Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E73C6120018; Tue, 24 Dec 2019 06:26:07 -0800 (PST)
Received: by mail-wm1-x32d.google.com with SMTP id c127so2073300wme.1; Tue, 24 Dec 2019 06:26:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=TD0y42VJ+czEGKyOI1g0F6GtlWHxW6iyY1t5zCciZEk=; b=igAlG1bwxwwBICRAo/YraDBLerNZlbfrrmLfqafzoDQblIz9AjJtwnuWBgI3RKsnY0 LgV6IS2eWSe9E5TsOyfB5yp6gkw2B9Ce1odK0YKgrTFIYVzutRwN+vYfT7TTbNZJuwUq jBOL2Wytsye6eeOPDoD2OThH7TRhWnk3NF/WggVZtSGilCdGUukJEbXAVm1T4HDhqGJo JDj+KxKQnuK/q3eJQN6RMUVK0pum9ODjjlqxH93I1D6Xfei8B43eu0a29MND8S1NTV0F 2S2cPpfbcifX2BFoWHeGYOUQ4Zhf59bi3/fgYki/D0n/IyIM0tq/B/e/wBHDhXRM69BA WXJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=TD0y42VJ+czEGKyOI1g0F6GtlWHxW6iyY1t5zCciZEk=; b=GP6TuAP4tJkL/nl1qiEfcNlk1KucjXBqlfx+zcO5+eNlAHgkcZjZdUpZQgAjI5SAKn mXX/MH41dnk9oJepOJOyQwU0XZN8ERHdz+WDWBZ+vWBmWAGgLu4f6hlqxVK+hgFJS+5o 2vtM2njz/H1uFWkFLb1hsRnECrja2KfZEbG1lzEEHk7aXpQodEmzYErjunRzGx2wTHYQ +p08lo+63JppiUK1Ak0Fi86F6CvnHCyPkbBDZwfEFsIMy1sdoaGazy0THVbsAbMaKjSf Yoa7rjT3frbu32d5t3uJeUAKIlfvZ8p8lA+Me2jOcLFSmUcYUDoDfk9LKmNRKLYao+6x k4Kg==
X-Gm-Message-State: APjAAAVOAKSWD3/fORtgUg4xBvrpC0ycIYNATfsfSdcjfGJYpMBCJ/zx nUitHdHk/y8ySeMEtumJfrM=
X-Google-Smtp-Source: APXvYqwQFUZDFEcgc/QTuH7NUbUVffL+/hsE+Xyj6sQWsUPLnK5Yq0INgx07fu2C53VROD30rxounA==
X-Received: by 2002:a05:600c:22d3:: with SMTP id 19mr4514760wmg.92.1577197566396; Tue, 24 Dec 2019 06:26:06 -0800 (PST)
Received: from appleton.fritz.box ([62.3.64.16]) by smtp.gmail.com with ESMTPSA id o7sm2706183wmh.11.2019.12.24.06.26.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Dec 2019 06:26:05 -0800 (PST)
From: Stewart Bryant <stewart.bryant@gmail.com>
Message-Id: <F5B34BFA-A058-47D5-8650-7371ED223CA2@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_C55F36C1-48CC-4CEB-A554-53314B3F434C"
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\))
Date: Tue, 24 Dec 2019 14:26:03 +0000
In-Reply-To: <157714579482.2458.7370182245915799132@ietfa.amsl.com>
Cc: rtg-dir@ietf.org, last-call@ietf.org, draft-ietf-detnet-mpls.all@ietf.org, detnet@ietf.org
To: Carlos Pignataro <cpignata@cisco.com>
References: <157714579482.2458.7370182245915799132@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3601.0.10)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/9h6vYPjWKKdlx2YwCZUB-DYq7TU>
Subject: Re: [RTG-DIR] Rtgdir last call review of draft-ietf-detnet-mpls-04
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Dec 2019 14:26:14 -0000


> On 24 Dec 2019, at 00:03, Carlos Pignataro via Datatracker <noreply@ietf.org> wrote:
> 
> 
> 3.1.  Layers of DetNet Data Plane
> 
>   The DetNet control word (d-CW)
>   conforms to the Generic PW MPLS Control Word (PWMCW) defined in
>   [RFC4385].
> 
> Yes, but why not the Preferred CW?
> 

Hi Carlos

Thanks for the review. Just picking up a couple of points at this stage,

The PCW only supports a 16bit sequence number and it has the skip zero auto-signalling of active S/N feature.

This was a problem for DetNet because:

- We were worried about S/N rollover frequency in some applications and so we wanted the option of a larger S/N.

- We wanted to have the option to propagate the S/N from the payload to the transport to simplify the implementation in some cases. These applications have a non-skip zero S/N. Skip zero is an irritation to implement and we should probably have signalled in in PWs.

As you note in is only a preferred design for PWs, DetNet is not constrained by that and there were good reasons to adopt this alternate approach,



> 4.1.  DetNet Over MPLS Encapsulation Components
> 
>   The LSP used to forward the DetNet packet may be of any type (MPLS-
>   LDP, MPLS-TE, MPLS-TP [RFC5921], or MPLS-SR
>   [I-D.ietf-spring-segment-routing-mpls]).
> 
> I am not sure of the value of this statement for an "MPLS Dataplane" document.
> Further, are these "LSP Types" and if so where are the different types
> ennumerated? Does this mean that static binding LSPs and BGP signaled cannto be
> used? T-LDP does not work? "SDN Assigned"? I recommend removing this, since it
> can confuse and does not add much.

I think it just needs a “for example” and I think that it needs to be made clear that the design is not restricted to a single method of establishing an LSP nor to the characteristics and constraints that go with those LSPs.

> 
> 4.3.  OAM Indication
> 
> It is important to have the OAM Indication, but what type of OAM packets can
> run on top of this AcH? I found it interesting that for example there is not
> reference or citation to RFC 8029.
> 

Work has started on OAM, for example draft-mirsky-detnet-mpls-oam-00

The OAM for DetNet will be more complex than the OAM for a classical P2P or P2MP LSP (or PW) because of the PREOF function. There is nothing in the data plane that precludes us using on of the existing OAM indicators (GAL or 0001 ACH), but I think that it is important to thing through the subtleties. Thus I think it is OK to make progress on the elements of the data plane that we can nail down, and leave. The OAM as follow-up work.


> 
> 
> Also, outdated reference: draft-ietf-spring-segment-routing-mpls has been
> published as RFC 8660

This will get picked up on the next resin as part of the Nits check.

Best regards

Stewart