IETF Logo Mail Archive

Re: [RTG-DIR] RtgDir Review: draft-ietf-lsr-isis-rfc5306bis

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Fri, 07 December 2018 16:58 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 157AB130EB9; Fri, 7 Dec 2018 08:58:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.959
X-Spam-Level:
X-Spam-Status: No, score=-15.959 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-1.459, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q-IX0uW5U8ES; Fri, 7 Dec 2018 08:58:37 -0800 (PST)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E4228130EB3; Fri, 7 Dec 2018 08:58:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=17734; q=dns/txt; s=iport; t=1544201915; x=1545411515; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=SDWWQsTsyZdSAxwxNqtzk3htiUJeOkT6SA2c2y9fIYI=; b=YKo/bBsXFAfpnSS//e6GIdJnWGLxPQx7vRpTekBwkM3wIytwrQ0N4Skt aQedjENDZ03G4R1yYa3nAySLfIDDEikRnBzE+1V6Js1IZyXkuyqbe7Qm7 dLc7kvuZGjRpu2m477WlL+D6fVnTHYiH8Yz8oBvUFuIEjo1gOgcyrdNnc 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AMAABnpgpc/5FdJa1jGwEBAQEDAQEBBwMBAQGBUQYBAQELAYENSC5mgQInCoNwiBmMEYINkXiFV4F6CwEBI4RJAheDBCI0CQ0BAwEBAgEBAm0cDIU8AQEBBCMKXAIBCBEDAQEBKwICAjAdCAIEARIIgxqBHWQPpVeBL4RBQIUtjCIXgUA/gRGDEoMTCwIDAYF9gmSCVwKPI4ZNincJAocEij0ggVxNhEmKRokQhHGKcwIRFIEnDRI4J4EucBWDJwmLE4U/QTEBikyBHwEB
X-IronPort-AV: E=Sophos;i="5.56,326,1539648000"; d="scan'208,217";a="408165739"
Received: from rcdn-core-9.cisco.com ([173.37.93.145]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2018 16:58:34 +0000
Received: from XCH-RCD-005.cisco.com (xch-rcd-005.cisco.com [173.37.102.15]) by rcdn-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id wB7GwYUR010373 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 7 Dec 2018 16:58:34 GMT
Received: from xch-aln-001.cisco.com (173.36.7.11) by XCH-RCD-005.cisco.com (173.37.102.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 7 Dec 2018 10:58:33 -0600
Received: from xch-aln-001.cisco.com ([173.36.7.11]) by XCH-ALN-001.cisco.com ([173.36.7.11]) with mapi id 15.00.1395.000; Fri, 7 Dec 2018 10:58:33 -0600
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Manav Bhatia <manavbhatia@gmail.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "rtg-ads@tools.ietf.org" <rtg-ads@tools.ietf.org>, "draft-ietf-lsr-isis-rfc5306bis.all@ietf.org" <draft-ietf-lsr-isis-rfc5306bis.all@ietf.org>
Thread-Topic: [RTG-DIR] RtgDir Review: draft-ietf-lsr-isis-rfc5306bis
Thread-Index: AQHUjhnykM/D8ijjTk+8O3msttG186VzauJw
Date: Fri, 07 Dec 2018 16:58:33 +0000
Message-ID: <4339d4228e5d4851a61f7510103701e1@XCH-ALN-001.cisco.com>
References: <CAG1kdohLTUjoeDUUZ3LOhNw8O1yzY+xKKxkDu6KALiX2k6nqGQ@mail.gmail.com>
In-Reply-To: <CAG1kdohLTUjoeDUUZ3LOhNw8O1yzY+xKKxkDu6KALiX2k6nqGQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.13.164]
Content-Type: multipart/alternative; boundary="_000_4339d4228e5d4851a61f7510103701e1XCHALN001ciscocom_"
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.37.102.15, xch-rcd-005.cisco.com
X-Outbound-Node: rcdn-core-9.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/BWOnVIZW8-kJ5Yls4S10DqjmTOM>
Subject: Re: [RTG-DIR] RtgDir Review: draft-ietf-lsr-isis-rfc5306bis
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Dec 2018 16:58:39 -0000

(draft alias corrected)

Manav –

Thanx for the review.

I think your comment is on the mark – though implementers  have been known to bypass the existing limitation by signaling a long holdtime prior to restart even in the absence of PR bit. Suppose we added the following text at the end of Section 2.2.3:

“Use of the PR bit provides a means to safely  support restart periods which are significantly longer than standard holdtimes.”

??

   Les


From: rtg-dir <rtg-dir-bounces@ietf.org> On Behalf Of Manav Bhatia
Sent: Friday, December 07, 2018 2:45 AM
To: rtg-dir@ietf.org; rtg-ads@tools.ietf.org; draft-ietf--lsr-isis-rfc5306bis.all@ietf.org
Subject: [RTG-DIR] RtgDir Review: draft-ietf-lsr-isis-rfc5306bis


Hi,



I have done a routing directorate review of this draft.



https://datatracker.ietf.org/doc/draft-ietf-lsr-isis-rfc5306bis/



The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir



Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.



Document: draft-ietf-lsr-isis-rfc5306bis

Reviewer: Manav Bhatia

Review Date: 7 Dec 2018

Intended Status: Proposed Standard



Summary:

No issues found. This document is ready for publication.



Comments:

I have a minor comment on whether the authors could add some text that explains that the current mechanism only works when the restarting router comes up in a short amount of time, which is basically for as long as the Holdtimer does not expire on its neighbors. However, some restarts can take longer, and this adds support for such restarts.



Thanks, Manav

v2.23.0 | Report a Bug | By Email