IETF Logo Mail Archive

Re: [RTG-DIR] Rtgdir last call review of draft-ietf-rtgwg-yang-rib-extend-16

Yingzhen Qu <yingzhen.ietf@gmail.com> Mon, 01 May 2023 20:45 UTC

Return-Path: <yingzhen.ietf@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 00C02C15153C; Mon, 1 May 2023 13:45:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1k2d4gwlIPon; Mon, 1 May 2023 13:45:55 -0700 (PDT)
Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com [IPv6:2607:f8b0:4864:20::e36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 463B6C14CE55; Mon, 1 May 2023 13:45:55 -0700 (PDT)
Received: by mail-vs1-xe36.google.com with SMTP id ada2fe7eead31-4329313f39eso626182137.1; Mon, 01 May 2023 13:45:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682973954; x=1685565954; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2Ir54Jh4IK4zSLhLkE2zGIMy5c4WmaxPbHjDR67WIeE=; b=FSxDlbiv54SD9n8qvOKcCCi1fbB9rCYAvC1vmZSW0v/fBhkiMszLxBb6ZX2RjjNQx7 MKqgRXYFQyKNN9n1GfVPPJKu0oc48Jj77wvogWIGaLpaPJSp0tP/lXDdnQ/mkHOr5Js1 nDKomcX3ewZkMyknvNZiuEOn3YkW5cpITDavawLPwX8JZY4nlTJbh5W7kgcmifx+Ptwj lXd/ZzhNDGz+WzwJxtRWodZorAxRHh6jZvvPrGGUv2qeYHCjnUIlHew20YQWoJ3BAkx2 BOOz4DHWom8VlmBbhvpF1BE+c/Sh/0avccO0pQCYeN3Fvt6eKr0cjX5e9WvKkEkdNDx1 BtKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682973954; x=1685565954; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2Ir54Jh4IK4zSLhLkE2zGIMy5c4WmaxPbHjDR67WIeE=; b=KFDVlefFvOT0fZsHNvgxlV/FybADwBWQ13HGrFs0H6WhBFEqLs1Wh8qrcm+NvGdzbC O4JxbVJATIfLbYdWFhekrOkBtAEcKm4xGb4+sq4Az59nFnV6Wd9wHdVDgKXw4+4zDVW4 HOkeD8QGcF7B3wDJe4mN9dxX9TjTUPaOoBY9auV/ARmLwqv+O/gn8PBbmyYIByVw/YE1 IrrTP1i4cTYkIeO2P0eI4Bkw1f8gizElGo5IPmoUWm9u2AEK/kNjKub99SZW4YWJCeti 5NB+dkdYe9Y1vijj4jZ3ocBHvqqG5L2Z0TjrRJyxyvK5J0s+VQlaRA0CoV+FRs/wlA73 Aq5g==
X-Gm-Message-State: AC+VfDzOcB+yiqtI+7d6vg5CUQcv1HtnB+ZGAWC2mymbgayJyX0vZN6d QAeQrsgO8cKGsXDtawAUlIdTKDvySXjsK57FVvqYMDo=
X-Google-Smtp-Source: ACHHUZ4Hol8rQFz/wVg0VabL/FdkkNk/TR4J1IfzHZK/N/IJgrflT1+4BsmNGcMXwxdGNIu2Z44Ay95mvtSZFrEErzs=
X-Received: by 2002:a67:eb59:0:b0:42e:687e:d05a with SMTP id x25-20020a67eb59000000b0042e687ed05amr5468361vso.19.1682973953828; Mon, 01 May 2023 13:45:53 -0700 (PDT)
MIME-Version: 1.0
References: <168296662458.49135.11152971610183102502@ietfa.amsl.com>
In-Reply-To: <168296662458.49135.11152971610183102502@ietfa.amsl.com>
From: Yingzhen Qu <yingzhen.ietf@gmail.com>
Date: Mon, 01 May 2023 13:45:42 -0700
Message-ID: <CABY-gOMerNd0=P2zwdt4b=y0_wHUsWqYAi+Q0He38EiYPz0Qeg@mail.gmail.com>
To: Zhaohui Zhang <zzhang@juniper.net>
Cc: rtg-dir@ietf.org, draft-ietf-rtgwg-yang-rib-extend.all@ietf.org, last-call@ietf.org, rtgwg@ietf.org
Content-Type: multipart/alternative; boundary="000000000000af2a8b05faa7e8cb"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/DcCDWVlSiJkuu6emlfBwognKCWY>
Subject: Re: [RTG-DIR] Rtgdir last call review of draft-ietf-rtgwg-yang-rib-extend-16
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 01 May 2023 20:45:56 -0000

Hi Jeffrey,

Thanks for the review, please see my answers below.

Thanks,
Yingzhen

On Mon, May 1, 2023 at 11:43 AM Zhaohui Zhang via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Zhaohui Zhang
> Review result: Has Issues
>
> I have the following one nit comment and one question:
>
>   augment "/rt:routing/rt:ribs/rt:rib/"
>     + "rt:routes/rt:route/rt:next-hop/rt:next-hop-options/"
>     + "rt:next-hop-list/rt:next-hop-list/rt:next-hop"
>   {
>     description
>       "Augment the multiple next hops with repair path.";
>     uses repair-path;
>   }
>
> The description is slightly misleading. It is to agument a single next-hop
> in
> the next-hop-list, not "multiple next hops".
>
> [Yingzhen] how about: "Augment the next-hop with a repair path."

Shouldn't the repair path be applicable to static routes as well?
>
[Yingzhen]: Theoretically you can have a repair-path for a static route,
but have you seen this in deployment?

v2.23.0 | Report a Bug | By Email