[RTG-DIR] RtgDir review: draft-ietf-mpls-egress-ptotection-framework-03

Alexander Vainshtein <Alexander.Vainshtein@ecitele.com> Tue, 20 November 2018 09:41 UTC

Return-Path: <Alexander.Vainshtein@ecitele.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9BD1412D4EF; Tue, 20 Nov 2018 01:41:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.7
X-Spam-Level:
X-Spam-Status: No, score=-1.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=eci365.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VoYEGDGzQ3zH; Tue, 20 Nov 2018 01:41:13 -0800 (PST)
Received: from mail1.bemta25.messagelabs.com (mail1.bemta25.messagelabs.com [195.245.230.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EA16B12D4EC; Tue, 20 Nov 2018 01:41:08 -0800 (PST)
Received: from [46.226.52.199] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-4.bemta.az-b.eu-west-1.aws.symcld.net id 06/76-08991-3B6D3FB5; Tue, 20 Nov 2018 09:41:07 +0000
X-Brightmail-Tracker: H4sIAAAAAAAAA1WTe0hTcRTH/e3e3d3EyW2mnkYPWvaS7nJWtoK oCKKIoggqLKs7vW2LbY7dWVZ/FNJLl7UeI5NlZitJhWAF1hAUC3LiKkQrV5qrJJXMykB7KN3H tPrnx+ec7/me37mH3yUxVR+hJtl8J+uwMRYNEYsvWTCSQvtfDO1KC5xJ1b+unasP37oj1we9I 5i+vKZHsRpf7/P9kG1BmXKzzZCbv09uCkb8Cnv7HSw/XF1MHEcnfFgRiiVxqgKD8voKXAhUlE cGnrZBQgoiCL63BPhgEklQK8Ff3SnyFGoBnD8bFh0Y9QhBQ7hVIQgJ1Dr4eqUbl4o2QvCTC5N YCzUvPTKBcWoOuH0P5QIrKQa6Bn+JjKgkGG6uEWswKhnCH66LDBQFvrpnmMSJ0Pd+TC7xLCjp 8iokng6t111IGAioDgKeXOiIFtHwxeOJmjdB0D3MG0ieZ8P93iyp/g2CsYHuaM1COPvKR0gDG eBtzw0k5e1wum4gyjOgqjiCS+Z2DE5VNkSbToPuECnlvQT0fusRG6mobGjyDkUNbgyKCjpwaV 1q6GwrRG6UWvrPV0tsg7uuAlQqbmkyBK9+wEv5OzB+9XcDi6SSWXDZFVFIPB9Oeq8p/s2XI0U V0hscZqPJaWXMFlqXlkbrdOm0bnkGrctYrGWO0AYtm0cfYjknrdMyhzgtd9iabcnR2linH/GP LMf++OYD1F9pbERTSZkmUbn69tAuVbwhN+ewieFMex15FpZrRNNIUgPKgmZem+xgjWz+frOFf 6njMpBxminKx4Ks5OyMlTMbJakZrSLflZwpwche8fwsnm0thSWYCrfl2lh1stIt2CjBZsqzTT Qd/wNa0XR1ghLFxMSo4uysw2p2/q/3o2QSaRKUV4UucWabc+Lufn4sGT/Wx/ZBYSwn81dSH0e nqqwRQ3pZ0tb6ldv9avoI83x04VFX6s7RptqG0I7ghnAeuzllrb3ME5p3Iyd3ZMeDzB8twZ+h zaMzE7Ln9VZPuhjZfe/1k3dLaw/ixJ4m2SVk2rNMtiajMaO+omPq8LlwbfKBLP3w0bbfx1Zkh p7Gt7RjSwLeE2ibsZoLB8bKmjU4Z2J0qZiDY/4A9Er/BfwDAAA=
X-Env-Sender: Alexander.Vainshtein@ecitele.com
X-Msg-Ref: server-9.tower-287.messagelabs.com!1542706862!3440676!1
X-Originating-IP: [52.41.248.36]
X-SYMC-ESS-Client-Auth: mailfrom-relay-check=pass
X-StarScan-Received:
X-StarScan-Version: 9.14.24; banners=ecitele.com,-,-
X-VirusChecked: Checked
Received: (qmail 762 invoked from network); 20 Nov 2018 09:41:05 -0000
Received: from us-west-2a.mta.dlp.protect.symantec.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (52.41.248.36) by server-9.tower-287.messagelabs.com with AES256-SHA256 encrypted SMTP; 20 Nov 2018 09:41:05 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ECI365.onmicrosoft.com; s=selector1-ecitele-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/63JX2fqowz4cLx6R/4rmE8iy7fZywAyMXzunwBQ2I8=; b=RfnhmgWCAHydsw0es7R0fr1GUYIcLhUdbD8e89quTCvGke5bRb/BnqOlDWHVHntsqWk4a5uCZNqL7bto0ffd00a8FgwYGrkGANo/jVVKWe/3tzBfmbOnaKX1YFrCOCkqcNRD3zZIsDiLPfPFCcP33NXmQm/p0vQk4qZdBV4cUTM=
Received: from DB5PR0301MB1909.eurprd03.prod.outlook.com (10.167.226.155) by DB5PR0301MB1942.eurprd03.prod.outlook.com (10.167.227.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1339.26; Tue, 20 Nov 2018 09:41:00 +0000
Received: from DB5PR0301MB1909.eurprd03.prod.outlook.com ([fe80::1543:935:a712:7a0d]) by DB5PR0301MB1909.eurprd03.prod.outlook.com ([fe80::1543:935:a712:7a0d%3]) with mapi id 15.20.1339.027; Tue, 20 Nov 2018 09:41:00 +0000
From: Alexander Vainshtein <Alexander.Vainshtein@ecitele.com>
To: "rtg-ads@ietf.org" <rtg-ads@ietf.org>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>, "draft-ietf-mpls-egress-protection-framework.all@ietf.org" <draft-ietf-mpls-egress-protection-framework.all@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-mpls-egress-ptotection-framework-03
Thread-Index: AdR8MjymUP2LtqqCRvO1Anp1Nk3O/A==
Date: Tue, 20 Nov 2018 09:41:00 +0000
Message-ID: <DB5PR0301MB1909DAA9F3E05FB21A70C1509DD90@DB5PR0301MB1909.eurprd03.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [147.234.241.1]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DB5PR0301MB1942; 6:HyxUmTHatuSkJlRg4NUo6pzhktd1TRBKjGyg4BAq9vkIzqDQH0krgoqjoUXrf7M+GIgMWuHKmczanrXus8ij0azvUiqgx4FSq/sb26JBZ0biHKAPkmIDJHIGcjp3Mj4vBOv5zswfAAqgCHBx3KacoIb5SdhI6zRjxEHhjyF0qvJhCDyzsrW1MYwCFxqR1ajBJRIv72sxqVkTg4CO4CtUvEOl8Peq+8M57k9gIBqxfllGYvGz+zozOGQHc6Rn1F0DxBJdwoLyXAg4pLzAezlF3+qSpnq6JqzoXR3fC+CfocEw1L7YM5tn/VUFXNVluBecIBnC0KHCcgL8ZMUcRAOzNuUlwdObe5AdumX3x3iZTwxuRltA8QVON/zJdap4rWr0EeQFefbLLx6Iq4dJy40Y5bhVJ2mXtYbV0cqg32RqwkvpsjOs2Q4QEXAIb+budiBqVqumqUmKrAoGMNhT0cDTig==; 5:GcxqJDtm6cMEGKROK7qSb7+mXx7eRk9WmTcW7nt00kazPEM0RBGNLWjZXKkUzPeXnHVliKHcvSTVOiU/cK1Yho9kDjplYtaydAxIbLXdF/SwRopME6lIxz+HF1EfGSjcLypQkA2KiVbEHMIf+Oz/CXJOVwsnkDOUo5NyUIGMenk=; 7:XxPydGgqDha86/omKFWNnFL1QxbyqZrVHExDoppXQMHNVZtGoR+DqNDXmlC0x1ch/IjdL7ML9kLTqtg7HfefBa9JjzyfZaZ2MLhQdTzErdbu2tWL7VUtuLPt2duifnWzQiwo/9wtDNeJzWCFGGimcA==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 40ab5775-ced4-42e7-7078-08d64ecc47d2
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB5PR0301MB1942;
x-ms-traffictypediagnostic: DB5PR0301MB1942:
x-microsoft-antispam-prvs: <DB5PR0301MB1942DA32819D677941FCF67A9DD90@DB5PR0301MB1942.eurprd03.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231442)(944501410)(52105112)(10201501046)(3002001)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:DB5PR0301MB1942; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0301MB1942;
x-forefront-prvs: 08626BE3A5
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(376002)(366004)(39860400002)(396003)(136003)(51444003)(252514010)(189003)(199004)(9326002)(256004)(8936002)(2501003)(14444005)(97736004)(316002)(236005)(8676002)(4326008)(14454004)(6506007)(72206003)(9686003)(71190400001)(71200400001)(2900100001)(3846002)(6116002)(790700001)(55016002)(450100002)(81156014)(74316002)(54896002)(5660300001)(54906003)(81166006)(68736007)(25786009)(186003)(7736002)(26005)(6306002)(7696005)(86362001)(2351001)(2906002)(105586002)(478600001)(106356001)(6436002)(5640700003)(606006)(33656002)(21615005)(53936002)(99286004)(486006)(476003)(66066001)(102836004)(6916009); DIR:OUT; SFP:1102; SCL:1; SRVR:DB5PR0301MB1942; H:DB5PR0301MB1909.eurprd03.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ecitele.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: w/O9VYyO0xHcotzvyEVj3DA3MDHbGvz3+Ov7dbIA4MK/IjhhtWFsTAtHSjS3QaA9aZzk3MOLWPQfK0dvkhgEjCFPWVkp76eETyZzGIEEONKFVqmUg7eTMxBveoyc0p86eS5S4RPKly9wHk/z/Q/f3XAMDaM17tMAf8iIL/bsbTWRfIYMayu/nEFpROZX6wHNuSPXDZFHC6nTHAY0fSL2X1pfWu4NNhLXlv3Gk9UjF+9aU7xEh6VPMwE9eTJEJv9emqwGU9QgniKKfSO4K0aiuNlTbeoBuCeu2Tk1+bdXxhWabm91is9Ux/+ISsPnb/e0G9wN7B+/8KP6k2wroAocsEiR5SYSUEPv3MOLYBwEa6A=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_DB5PR0301MB1909DAA9F3E05FB21A70C1509DD90DB5PR0301MB1909_"
MIME-Version: 1.0
X-OriginatorOrg: ecitele.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40ab5775-ced4-42e7-7078-08d64ecc47d2
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2018 09:41:00.3301 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 2c514a61-08de-4519-b4c0-921fef62c42a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0301MB1942
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/AxrkREpY5WTXtZV4v2NjXRhmbEY>
Subject: [RTG-DIR] RtgDir review: draft-ietf-mpls-egress-ptotection-framework-03
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 09:41:16 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir<http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir>

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.
Document: draft-ietf-mpls-egress-protection-framework-03
Reviewer: Alexander (“Sasha”) Vainshtein
Review date: 19-Nov-18
IETF LC End Date: Not known
Intend status: Standards Track

Summary:
I have some minor concerns about this document that I think should be resolved before publication.

Comments:
The draft is well written, requires from the reader has good understanding of multiple technologies including:

·         context label spaces and context labels RFC 5331

·         local and remote LFA mechanisms (RFC 5286 and RFC 7490)

·         Segment Routing Mirror SIDs (RFC 8402) and more.
I doubt it is suitable reading for a beginner, but I also doubt any required background could be skipped.

This is a framework document, with at least one “specialization” of this framework already being published as RFC 8104<https://tools.ietf.org/html/rfc8104>;.  I assume that other “specialization” documents are on the way.

I have hold a very constructive off-list discussion with the authors before posting this review. Some of my comments have been already acknowledged. I would like to thank the authors and, especially, Yimin, for cooperation.

Caveat:
I have done an unsolicited review of the precursor individual draft<https://www.ietf.org/mail-archive/web/mpls/current/msg17033.html>;. From my POV, the document has been quite in good shape even then, so I may be considered as positively biased (the current version acknowledges my comments). I have noticed that the majority of my then comments have been successfully resolved in the current version of the draft.

Major Issues: No major issues found

Minor Issues:


1)      The document seems to be ambiguous  with regard to expected coverage of L2VPN services by the framework it defines:

a.       On one hand, the requirement for the framework in the 2nd bullet in Section 4 says that it MUST “accommodate existing and future IP/MPLS services, including layer-2 VPNs, layer-3 VPNs, hierarchical LSP, and others”

b.       On the other hand, the overview of the framework (in Section 1) says that “When a PLR does local repair, the protector is responsible for performing "context label switching" for rerouted MPLS service packets and "context IP forwarding" for rerouted IP service packets, to allow the service packets to continue to reach the service destinations”. i.e., MAC-based switching seems to be excluded from the protector responsibility.

c.       Section 3 of the draft only defines the terms “Context label switching”  and “Context IP forwarding”. This also suggests that Context Layer-2 switching is not covered by the framework

2)      I have some doubts regarding applicability of the egress protection framework defined in the draft  to VPLS-based (RFC 4761 and/or RFC 4762)  services because:

a.       With VPLS, CE multi-homing always operates in single-active mode. As a consequence:

                                                               i.      Prior to failure of the primary egress, the VSI that represents the service in the Protector PE would not learn any MAC addresses

                                                             ii.      If the PLR redirects “known unicast” traffic intended for the primary egress PE to the protector, the VSI that locally represents protected service there would flood this traffic as “unknown unicast” and, as such, probably subject it to rate limiting.

                                                           iii.      From the POV of the customer of the VPLS service,  this means that redirecting traffic to the protecting VSI, by and of itself would not fully restore the service, since substantial part of the customer traffic would be dropped until MAC learning in the protecting VSI is completed

b.       It is also worth noting that in VPLS received application labels do not only define egress VSI as the context for the MAC-based switching but also identify remote ingress VSI for MAC learning. Extending such identification to cover also application labels of the redirected traffic looks quite non-trivial to me

c.       I see these concerns as minor issues because, as explained above, it is not clear to me whether the framework is supposed to cover VPLS services. An explicit caveat (possibly defining applicability of the framework to VPLS services as “left FFS”, or to be discussed in a separate document”) would suffice to resolve them IMHO

d.       L2VPN services that use EVPN technology would neither suffer from an empty FIB in the protecting MAC-VRF nor use EVPN application labels for MAC learning. But I cannot say whether they do or do not introduce some other issues with the proposed framework – this would require serious in-depth analysis. Meanwhile such services look to me like another case when an explicit definition of “left FFS” or “to be addressed in a separate document” would be very much in place.

3)      The example of applying the egress protection framework to BGP/MPLS IP VPN (RFC 4364) in Section 8 is explicitly restricted to scenario when both the primary egress VRF and the protector VRF use per-VRF label allocation scheme.

a.       With this scheme, the usage of the proposed egress protection framework is quite straightforward.

b.       However, RFC 4364 defines several label allocation schemes and states that the label allocation scheme can be selected independently in each PE without any impact on interoperability. It is not clear to me, to which extent IP VPN services that use different label allocation schemes in different egress PEs would be covered by the proposed framework

c.       Since we are only speaking about an example in a framework document, there is no need to describe a complete solution here. Simply noting the need for elaboration with regard to other VPN application label allocation schemes  (including the possible mismatch in the primary and protector egress PEs) and sending the reader to a (future) dedicated document would suffice IMHO.

4)      Section 5.8 describes 3 possible approaches to advertisement of the Context ID IP address in IGP. But it does not define any of these approaches as “MUST to implement”. This looks to me like an opening for interoperability issues between implementations that support different approaches. On the other hand, I am not sure whether a framework document is the right place to select a MUST to implement option, especially when the expected areas of applicability are quite different:

a.       The “proxy mode” approach imposes minimal (if any) specific requirements on the routing and TE domain (i.e., no dedicated extensions in IGP,  just support of some FRR mechanism by the signaling protocol used for the tunnel setup)

b.       The “alias mode” seems to require support of at least Segment Routing extensions to the relevant IGP in the routing domain as well as support of the Mirror SID in all potential PLRs. Therefore I think that it is a native scheme to be used in the SR-MPLS environments, but problematic in the environments that do not use SR-MPLS for setup of any LSPs

c.       The definition of the “stub link mode” is accompanied by a somewhat vague caveat: “The correctness of the egress-protected tunnels and the bypass tunnels relies on the path computations for the any-cast IP  address performed by the ingress routers and PLR.  Therefore, care MUST be taken for the applicability of this approach to a given network topology”.  Some clarification here would be welcome IMHO, especially since no analog of this mode could be found in RFC 8104.

d.       I have looked up Section 4.3 in RFC 8104 that discusses two approaches (equivalents of the Proxy and Alias modes in this draft) to advertisement of Context ID, and found the following text there (the critical fragment is highlighted):
   The mechanism in this document intends to be flexible on the approach
   used by a network, as long as it satisfies the above requirements for
   the transport tunnel path and bypass tunnel path.  In theory, the
   network can use one approach for context ID X and another approach
   for context ID Y.  For a given context ID, all relevant routers,
   including primary PE, protector, and PLR, must support and agree on
   the chosen approach.  The coordination between the routers can be
   achieved by configuration.
Adding such ( or similar) text to Section 5.8 looks to me as a reasonable compromise between being excessively strict and being excessively flexible in a framework document.
Nits:

1.       RFC 2119 is mentioned in the text, but does not appear as a Normative reference (BTW, I have pointed to this fact in my unsolicited review more than a year ago, but it still remains unresolved)

2.       RFC 8174 is neither mentioned in the text (as seems to be the norm these days) nor appears as a Normative reference.


Regards,
Sasha

Office: +972-39266302
Cell:      +972-549266302
Email:   Alexander.Vainshtein@ecitele.com


___________________________________________________________________________

This e-mail message is intended for the recipient only and contains information which is 
CONFIDENTIAL and which may be proprietary to ECI Telecom. If you have received this 
transmission in error, please inform us by e-mail, phone or fax, and then delete the original 
and all copies thereof.
___________________________________________________________________________