Re: [RTG-DIR] RtgDir review: draft-ietf-pce-association-group-08

Dhruv Dhody <dhruv.ietf@gmail.com> Sat, 06 April 2019 12:34 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 04ED7120049; Sat, 6 Apr 2019 05:34:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6-EofQ9Yyuwf; Sat, 6 Apr 2019 05:33:59 -0700 (PDT)
Received: from mail-it1-x136.google.com (mail-it1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4173012001A; Sat, 6 Apr 2019 05:33:59 -0700 (PDT)
Received: by mail-it1-x136.google.com with SMTP id k64so13905983itb.5; Sat, 06 Apr 2019 05:33:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v6xP8xj4Ek9na4aaXguRURwXd0/T9XAg2F5D3j3SWP4=; b=JnIiRg7GZW7PtVHYpymUyxU/noLRf9ZfXGHZSbwYjNgTVK0euSLta5r5FRmIdqRAcd 3YJdcmtmluJkh/jY9DIZEm+Mx6mVw1hOtLvCxv6uMA79ejo/4cLfQboX2plaD/kA49G0 WT635AZMFfc5FPplrYTURVOyeCAbDc8yG/S3SPWgkWQW+sLWKxtffmAQiIsF6OrnvVHP t11lwFFdZg8ih//eEgyz66RBN5jFJKe4wwRU7UYsyljkfku6O+OM9ufvJqHe9tNY37/N 8BiHLMkMNL/o9wmZpFPQ1rQp1wKl4k48/lX7IWSuxqg2cLQNglfmUt1f9Izi9WIZSI2t ltwQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v6xP8xj4Ek9na4aaXguRURwXd0/T9XAg2F5D3j3SWP4=; b=okvxHmzXIyDCRUZv356Pgz/54C+4GgIpNKZVGXKMSHq/Qjcn1ayxcBWlye/3UdNBYl 5cREN3qkFvNtrKw/a6UFEr2exVScxkP7EBaxTExnYBbl9/yu6E4VskKh44wgQsXZBA12 9b1pwAcB0EyONGKar7GJ+MTxZHZl4iEtXWltYg0X2nW4zYRQ5QTXuKfHKS4LueeYVIva KqEjfkmBLOtL2dZJehTgharFOncf+3aY0Zxuqinrp9LvW/b8kI+gmbIrVH8nRkgfZUPA TRWod6ZFe+7uHTMuXL5yQoB580ABLm0+/W6SHpRvz79+vQpYrL4nFjKj689+ZTDb2oth /S0w==
X-Gm-Message-State: APjAAAXmM+Lp7jzTztfdS+35DeBiGpEhtUEPVteOjXFIz/SSb2gAq3vp WbqxLpq7oNJ5/xeienk4QfcWddhVZwxyqJcHdXk=
X-Google-Smtp-Source: APXvYqwpalwH/09y+pr6WBQHzdy0oDK3/ddWfuWUBo3QkrL6PEAqlrykjJYJlubMXyoHL6Ky+RuU9CLsXZKyqhefA9g=
X-Received: by 2002:a24:1789:: with SMTP id 131mr13269538ith.36.1554554038413; Sat, 06 Apr 2019 05:33:58 -0700 (PDT)
MIME-Version: 1.0
References: <CAHANBt+wJupX8fyZ=w6qhOf6R7qVu0_Khi8fo7BdhfVJSsmo5Q@mail.gmail.com>
In-Reply-To: <CAHANBt+wJupX8fyZ=w6qhOf6R7qVu0_Khi8fo7BdhfVJSsmo5Q@mail.gmail.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Sat, 06 Apr 2019 18:03:22 +0530
Message-ID: <CAB75xn65LHV9VYQiPFXKEmOhFTXeRBs85ZVxYg0RCUokWkrRWA@mail.gmail.com>
To: Stig Venaas <stig@venaas.com>
Cc: "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>, rtg-dir@ietf.org, draft-ietf-pce-association-group.all@ietf.org, pce@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/H_FS5yPZ0zm90XJ6FiQnmF386v4>
Subject: Re: [RTG-DIR] RtgDir review: draft-ietf-pce-association-group-08
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Apr 2019 12:34:01 -0000

Hi Stig,

Thank you for your review, especially for providing clear suggestions
to fix the text, much appreciated!

I have fixed them all, except -

> In 6.3.1:
>    <state-report-list> ::= <state-report>[<state-report-list>]
> Should there be a space here?                        ^^^^^
>
> In 6.3.2:
>    <request-list>::= <request>[<request-list>]
> Space here?                ^^^^^
>
> In 6.3.3
>    <response-list>::=<response>[<response-list>]
> Space here?                  ^^^^^
>

While I agree the space would have been nice, but keeping it
consistent with existing PCEP RFCs (where the space is not used, such
as RFC8231, RFC5440) is also important. Thus I am leaving this as it
is.

See diff - https://www.ietf.org/rfcdiff?url2=draft-ietf-pce-association-group-09

Regards,
Dhruv