Re: [RTG-DIR] RtgDir Early Review: draft-ietf-pce-local-protection-enforcement-07.txt

"Stone, Andrew (Nokia - CA/Ottawa)" <andrew.stone@nokia.com> Fri, 18 November 2022 15:33 UTC

Return-Path: <andrew.stone@nokia.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 08F08C14CE22; Fri, 18 Nov 2022 07:33:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.494
X-Spam-Level:
X-Spam-Status: No, score=-0.494 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_COMMENT_SAVED_URL=1.391, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_NONE=0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NiV9BxrNYDvo; Fri, 18 Nov 2022 07:32:59 -0800 (PST)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20714.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::714]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6588EC14F612; Fri, 18 Nov 2022 07:32:57 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oJIuuA8X5/6TMn3J4nHKQpiZ+Nyor37i8IPovzPeHsqUn8No/KUT6LqTnC0A9zV6WEqpGxdDVQvEtCl/ikIgwRfmPdpt6ZEc+HirEVE1O6zbse7gpSWClz2JOVfGMjHe5+XETkSYOAEK3u2FwcDUV6TuTTtP2BqM3cDZWKqMDEVVqXfvpKz5zugYV4tie9I1tq8etRaYuhp/XVjZW63MpeOSUxEiTQut4cOO4VrlL65XX/yWdD9GT9AgEx8BpDrS9/Dp/lzOMYvp4xoukBFhG+TBXRwomTwuLthsMK9xdb8weWcc6Qwigp89as3cdiHe7Qj4KSpdQmPuaOkjmXbg/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n+yxKCsyzEFoM+IkoE+/OXmRrJWyPGcAxyRgpYG6+sE=; b=Ef+X7tKe31StIIp2iK41E4SyWWLLUWO8QEcLfWgAPz9CR7JdT39TLPYOI6iVzfximyWlj525gS9r34S+egqtoph8ncartqHZWWZ8iEvt9bMqDSQBdKl767CclGTLCiHekpjzCtwqnEwMHXUnXmxVqB6IcGOX+6P6Qo2fI9Xk0xoKd6mnNrlHoywshf7fWmE/PsZx0ahVDja5aA/msxZ6kXtVMo5jJ9bhSEAbClSWaeGX1+4Awbaopk1xo95zhcAHkYiNqU2xBgJQzlap864Le0fyWwUjSY2E1s9+g4Ey33DbqrZhMXkowJ9EywgDAp5uezbLL1irGw+76yrLbQCNRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n+yxKCsyzEFoM+IkoE+/OXmRrJWyPGcAxyRgpYG6+sE=; b=S1HtoZeiJl3yLD8AhfFPszE4ntt3VlWzwPPDAccQDktj3ugElrS/PbaxzB9HN8GoX1hExo9Bf0kVtIi5qFXRVnn4QiB1asFW2J2/nesdLrZCPWmAIhL9x1H7HTuirFa+Gj7OniubtR8TJmw+SpEV+3Hyw04bRSqUCeir7H1H7Lk=
Received: from CH0PR08MB7353.namprd08.prod.outlook.com (2603:10b6:610:102::22) by DM5PR08MB3627.namprd08.prod.outlook.com (2603:10b6:4:64::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 15:32:53 +0000
Received: from CH0PR08MB7353.namprd08.prod.outlook.com ([fe80::5399:8d6c:bd11:9ee4]) by CH0PR08MB7353.namprd08.prod.outlook.com ([fe80::5399:8d6c:bd11:9ee4%6]) with mapi id 15.20.5813.017; Fri, 18 Nov 2022 15:32:53 +0000
From: "Stone, Andrew (Nokia - CA/Ottawa)" <andrew.stone@nokia.com>
To: Donald Eastlake <d3e3e3@gmail.com>
CC: "pce-chairs@ietf.org" <pce-chairs@ietf.org>, "draft-ietf-pce-local-protection-enforcement.all@ietf.org" <draft-ietf-pce-local-protection-enforcement.all@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "pce@ietf.org" <pce@ietf.org>
Thread-Topic: RtgDir Early Review: draft-ietf-pce-local-protection-enforcement-07.txt
Thread-Index: AQHY+feA6by4lfeuwkCf9K7LrdlXoa5DQbOAgAC6bQCAAIIqAA==
Date: Fri, 18 Nov 2022 15:32:52 +0000
Message-ID: <61497CE1-BE9F-4F0D-BF4D-6797125C7930@nokia.com>
References: <CAF4+nEEg=OWDEQ+G=JwZkuMG_zycig06gwRh58277VgA_B1Yxw@mail.gmail.com> <0791BA07-3EAC-4B46-BA77-5B9B2B9781EC@nokia.com> <CAF4+nEEVeQegk9tXGzpQwi=RY6_vZe7c+As_y4EWr-epgGWqxA@mail.gmail.com>
In-Reply-To: <CAF4+nEEVeQegk9tXGzpQwi=RY6_vZe7c+As_y4EWr-epgGWqxA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.43.20110804
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CH0PR08MB7353:EE_|DM5PR08MB3627:EE_
x-ms-office365-filtering-correlation-id: 9d4b5cf0-9ba7-4faf-466b-08dac97a28a3
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: c5uAEZ0W/YK5aPU+obD6WJt+JQ570vLRvKc3i/hccAEiF9OAH3274W+95Iw49H8Hb9e2uzbXKT1wX2H2leyf6PWbk0lGJyLSUD4Dj9fKmziuWWr89L0gwd2i2khBE25w5YIk75NTnV7LJPg1yUWicxN/KAHVAHST/llYPg/JWYcOz262F6VWoe2hUiz1wnJa3IWn22kk8pTxvVcn/rKyufb1abb33Df3jf0QrK8DxQQGUaksoBvqpjAiMkWAc0h10ss2pU6LznK4TK71dbMbgn+kPO5BTHei2knHnGZnUOqwJRffCAQ6M20Amx3u3M0XXtKHOx3DVhpp4BhIG8/9uY/xOtHB0qaQ9CyWu4nhugq20b97B8xR5FFgcKE5XLx9iJLE7XBSybJ+2tFm3QSJpfTt5ljrsV41QyYTAZiGzBDs7cW5UhYIBfe5nSTScJuZ6dkpTsz9AL9ga2/HdgJFZM+UrjrPo1yZ3c47xwjXRtsztZ7WMYvKZPv0onpe25Uee+ISgAdwP6zVia4dsGmjuOAnc0w2hOxRTFAvCOgDNy7WDx5jSkc7tH7EPh+YdZ0Tt1Qe0IqWnJq5vUidZ2KZCLR7EwU3pYcSuT7WUsppoym94EiwxhSYkRddUV1ROokSVulW+aR7vaC390K8FbbTPOYPNHUkjez2+4s8MgnX2bVLOv9k4mjMkmeyGvI0E4B+IlndKMmIW2wl5SnnS3nUkhWNt5XfAATOWEpClOhRRMw=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR08MB7353.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(451199015)(36756003)(40140700001)(33656002)(82960400001)(66946007)(2906002)(4326008)(8936002)(38070700005)(4001150100001)(86362001)(122000001)(99936003)(83380400001)(316002)(8676002)(54906003)(186003)(2616005)(966005)(6486002)(66574015)(478600001)(5660300002)(66446008)(66556008)(26005)(66476007)(41300700001)(64756008)(6916009)(6506007)(71200400001)(6512007)(53546011)(76116006)(38100700002)(45980500001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: RB7Uxl7L2NRhCB63YJcjSaMZ/N3AzGGeDHVVHEPJ3aXmYc7zvKJsBfqH8OvBSzp0hn1ZjjtCiZdDeuXPTx2TIWLuZeiJ/sFCPuy9EYACDy9iQ2dureCuz2Z/hxI9aOH8xnXahwDtdvV365hzw0GzPOpe/NMBPawUWO1XyzQPrYHNKTSvPeGmJ817QmPUkw93f39aJcH4/VwJbxz1J7yGvfJ5yi7+qxBMth6AbGxfjV/7N4nRsX0GPXxYkiU//BeLpm/5JAd0pd7MhPI+oQjcORQpad5itr3//zXXPDJhEZKITdq/qCNbhAzVyaO58WrDdUMHqK3ZOXI0OMvhj2jpFn/iDeDiff9csXjg0nzenNThQUJk89mkf0z1XB+fZeRB13bOJd8woAFG4Infrz9868hqP9eCpLg7Om9LbisvZIaNgNnuhRrUd2ZZi66LJ1+OWhtHpLXyeVlTxpGCb+9o1qTIVXTJ8pjuhJGvKVJ7+OMSEcKu1F6GXQ9DYsdr+alLuNnNSAoUr+R+aku4QsOkUU/wIMYYPyyOFwVfZZ+COsSTnBAW+6/11HMO6WvsrWNV8fCNfyk/0sXKxXPYFzVD4AOSFplsONqOiNlxaFP3ynI1uOJEW7QdVAzISB0T1y+XykaoWsrqMYle1GFDxkeZeXkPF8NfiaG0WaVsGDa5eLk5fffg77Unr7X2eQtTtePtcPyNO99k0j5B6m8ZF22LZCD3jwl4Rvi/KaHNOaIl7ao5d9lf4kWnfSm8kkhm5K4E/nVfYeS2YERpcFJUygHafUo0QIt/utsO8aHWd1WuS9Fw9TXHB0hMuhp/QOD+QiGTdihJkh4l7HXh+HhiieGkwxx/MXhn45Odrgj9n0aPqe/rgCkhuN1UfaYifCxFO4pLeXqykLGFHgNZztUXRWqk22bRvMDJubsjUuu3i+Dj478/C/BkovEAULe34nl7JbZHTh5gCEEBR6rUcTS7WBLGsdLtAQhd6o6XKxkWN1WpcLOA/W2Mq5cToyA0+4iLHRrQKzviT008KT9xRTZym7soN5XQoJi15jRXHsITIIMNji5Ae9XqJi14V7aW1uDYMXE7E20URThH1NsQdUhe1U2hs326UyY1soz70PXUZgJkGIpxZxLw1MgGMcsXLCDnru8PS7lr9dQ0DjqDGYa/jA44quLNxPilTfv903qJu5xGphxDqcku+ceB/Qz8EKNFoxxw+whls5HCDu933SYTRpvYOeFzPPDOUo7X+MEUqVhgrie+HZgQY2/QmNfV2v3k9ZomlTDl3yWRtz9O7c0+DHaxBwrbyeBfpro9Vbr2y5xyh8OiEEmP3gF0FrSZqPrEhKBJ8IIF32YqHm9KHSpXpHDGy3SNlKmYXVnxg9I8TgGLW67CbHF/Dz5qUWTPecqm80J32Nw/I2jRmplFyZJw1jLZvsTL3NYG4DC4/WGWRbOKSVw/WyU1ADH+H2I7Dl42yBx01SX1SK5ESBIaC6mffhxqn8YaKS33+ktVzGFOztOjAluHun5OiLo+B3q+YvNaEAgSFJkeSjiIISTztEgxRD7ZiQihaeSHKSiR0S7fjnMz9ysQXnNQUmCiH+YueP+XanVMLv07VZ4gUzYazICRQdN/IQ==
Content-Type: multipart/mixed; boundary="_002_61497CE1BE9F4F0DBF4D6797125C7930nokiacom_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR08MB7353.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d4b5cf0-9ba7-4faf-466b-08dac97a28a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 15:32:53.0859 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XBcz6iDig86kFQl8Np0qAxuclRHqAFiyYCjrfsk6jnhwqTnr2drYvlMQRIYZRuM1ia9kEw+nsNVaI/Xu3ocp6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR08MB3627
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/LPexR_0uYnFrr6eVHYBC3ARkp5U>
Subject: Re: [RTG-DIR] RtgDir Early Review: draft-ietf-pce-local-protection-enforcement-07.txt
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Nov 2022 15:33:03 -0000

Hi Donald,

Nice spotting - that is quite strange. Using author tools I uploaded the 08 xml again, same result.

I uploaded the original 07 xml file (unchanged, from my local git) to author tools and now it also now generates with the RFC publisher remarks. A diff of this new 07 generation against the published 07 shows the same "RFC publisher" remarks against a handful of the references. Attached is the diff of the newly generated 07 against the live url 07. 

So indeed, perhaps either an intended change to the tooling or a xml2rfc bug? 

Thanks
Andrew


On 2022-11-17, 9:49 PM, "Donald Eastlake" <d3e3e3@gmail.com> wrote:

    Hi Andrew,

    On Thu, Nov 17, 2022 at 3:39 PM Stone, Andrew (Nokia - CA/Ottawa)
    <andrew.stone@nokia.com> wrote:
    >
    > Hi Donald,
    >
    > Thank you very much for the review. Version -08 is submitted with the suggestions and additional changes:
    >
    > Section 5:  "this i-d" -> "this document" (to mirror section 8 suggestion)
    > Section 8:  definitive language, added editor note (to mirror section 5 suggestion)

    Thanks. The incorporation of my suggestions looks great.

    However, I noticed something unrelated which seems quite odd. In the
    References sections "RFC Publisher" appears to have been added as an
    author for many but not all of the RFCs referenced. I've never seen
    this before and it is so bizarre it might be a temporary glitch so I
    have attached the Diff2 I see between -07 and -08...

    Thanks,
    Donald
    ===============================
     Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
     2386 Panoramic Circle, Apopka, FL 32703 USA
     d3e3e3@gmail.com

    > Thanks again
    >
    > Andrew
    >
    >
    > On 2022-11-16, 3:10 PM, "Donald Eastlake" <d3e3e3@gmail.com> wrote:
    >
    >     Hello,
    >
    >     I have been selected to do a routing directorate "early" review of
    >     this draft. For more information about the Routing Directorate, please
    >     see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
    >
    >     Document: draft-ietf-pce-local-protection-enforcement-07
    >     Reviewer: Donald Eastlake 3rd
    >     Review Date: 16 November 2022
    >     Intended Status: Standards Track
    >
    >     Summary:
    >     Has Nits.
    >
    >     Comments:
    >     This is a straightforward document specifying an "Enforcement" bit in
    >     the PCEP LSP Attributes Object. This bit operates in conjunction with
    >     the previously specified L (Local Protection Desired) bit to clarify
    >     the extent to which local protection is required / desired / undesired
    >     / prohibited in the path being determined. Appropriate backwards
    >     compatibility considerations are included.
    >
    >     Major Issues:
    >     No Major issues.
    >
    >     Minor Issues:
    >     No Minor technical issues but has nits.
    >
    >
    >     Nits:
    >
    >     Section 2: Need to be updated as per RFC 8174.
    >
    >     Section 5, Page 6: Drafts should be written as definite
    >     specifications, not as proposals. It will not be useful to say this
    >     has an "early allocation" when this is published as an RFC.
    >     OLD
    >        A new flag is
    >        proposed in this document in the LSP Attributes Object which extends
    >        the L flag to identify the protection enforcement.
    >
    >        Bit 6 has been early allocated by IANA as the Protection Enforcement flag.
    >     NEW
    >         A Protection Enforcement flag "E" is specified below, extending the L flag.
    >         RFC Editor Note: The text below assumes the E bit remains the
    >     early allocation value 6. Please adjust if this changes and remove
    >     this note before publication.
    >
    >
    >     Trivia / Editorial Suggestions:
    >
    >     Section 1, Page 3: re "so therefore" I suggest you pick one of these
    >     two words and drop the other.
    >     Add comma: "router processing the SID such as" -> "router processing
    >     the SID, such as"
    >
    >     Section 3: Suggest adding entries for the following: LSPA
    >
    >     Section 4.1, Page 4, 2nd line: "PCEP is with the" -> "PCEP is the"
    >
    >     Section 4.2, Page 5, 1st paragraph:
    >     "The boolean bit flag" -> "The boolean bit L flag"
    >     "The selection for" -> "Selecting"
    >
    >     Section 4.2, Page 5, 2nd paragraph:
    >     "if there is anywhere along the path that traffic will be fast
    >     re-routed at the point of failure" -> "if there is a failure anywhere
    >     along the path that traffic will be fast re-routed at that point"
    >
    >     Section 4.2, Page 5, 3rd paragraph:
    >     "rather local failures to cause" -> "rather local failures cause"
    >     "(ex: insufficient bandwidth)" -> "(e.g., insufficient bandwidth)"
    >     "resulting for the LSP to be torn down" -> "resulting in the LSP being
    >     torn down"
    >
    >     Section 4.2, Page 6: "to instruct the PCE a preference" -> "to give
    >     the PCE a preference"
    >
    >     Section 5, Page 7: "criteria however the" -> "criteria; however, the"
    >     "should interpret and behave when" -> "should behave when"
    >
    >     Section 5, Page 8: (twice) "It is RECOMMENDED for a PCE to assume" ->
    >     "It is RECOMMENDED that a PCE assume"
    >     "ignore the E flag thus it" -> "ignore the E flag. Thus, it"
    >
    >     Section 8: Since there is only one subsection of Section 8, the
    >     "Section 8.1" subheading should be deleted.
    >     When published, this will no longer be an "I-D" so the Reference
    >     should be changed from "I-D" to "[this document]".
    >
    >     Thanks,
    >     Donald
    >     ===============================
    >      Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
    >      2386 Panoramic Circle, Apopka, FL 32703 USA
    >      d3e3e3@gmail.com,
    >