Re: [RTG-DIR] [babel] Rtgdir early review of draft-ietf-babel-source-specific-01

"Joel M. Halpern" <jmh@joelhalpern.com> Thu, 09 November 2017 13:54 UTC

Return-Path: <jmh@joelhalpern.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EDE7F120046; Thu, 9 Nov 2017 05:54:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=joelhalpern.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rv-lpA_KlNcu; Thu, 9 Nov 2017 05:54:14 -0800 (PST)
Received: from maila2.tigertech.net (maila2.tigertech.net [208.80.4.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9A489126BFD; Thu, 9 Nov 2017 05:54:14 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by maila2.tigertech.net (Postfix) with ESMTP id 7CA74245B71; Thu, 9 Nov 2017 05:54:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelhalpern.com; s=1.tigertech; t=1510235654; bh=vbukJqV+FOdoPoMCeqXBzhvbwi8aQNWnJWNRJTLAd6g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TCwlAO4sFHGRP2F/wocXyPZF4gf7dr7Cn93UV1fSfgK7xzvdMi6mnoqxPfCrnUJog Ke4LH9ZnSQ6KDobYJU6UlFNUO0YnKNJmQKIMNhZbWFf4sTtgSWzC3NJWzkkeS/Zu2O R59yULyXqm9qiX+RJQmgva6hsjB56ETRhCmW/b2w=
X-Virus-Scanned: Debian amavisd-new at maila2.tigertech.net
Received: from Joels-MacBook-Pro.local (unknown [50.225.209.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by maila2.tigertech.net (Postfix) with ESMTPSA id E0C56240E4E; Thu, 9 Nov 2017 05:54:12 -0800 (PST)
To: Matthieu Boutier <boutier@irif.fr>, David Schinazi <dschinazi@apple.com>
Cc: rtg-dir@ietf.org, draft-ietf-babel-source-specific.all@ietf.org, Toke Høiland-Jørgensen <toke@toke.dk>, babel@ietf.org, Joel Halpern <jmh@joelhalpern.com>
References: <150983039829.26601.3109842491855567125@ietfa.amsl.com> <5FA8E8AC-6BBB-45D0-BDF6-2241179A5477@irif.fr> <87po8sqp74.fsf@toke.dk> <804D8548-4A08-4A6E-84B8-6512DF29D402@apple.com> <59C08DBA-7C1E-4325-A0CC-82D7C89B28BC@irif.fr>
From: "Joel M. Halpern" <jmh@joelhalpern.com>
Message-ID: <f3d88f74-57c4-9a66-f30e-67a1eebd35bc@joelhalpern.com>
Date: Thu, 09 Nov 2017 08:54:12 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <59C08DBA-7C1E-4325-A0CC-82D7C89B28BC@irif.fr>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/M8JOiuhuAgxko6y1QTV79VeFgls>
Subject: Re: [RTG-DIR] [babel] Rtgdir early review of draft-ietf-babel-source-specific-01
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Nov 2017 13:54:16 -0000

Being a little bit picky here:

Could you also add a sentence in section 7.1 stating explicitly that 
only one source specific prefix is permitted in a TLV?  I realize this 
is implied by the use of "a source prefix" in section 5.1.  I think it 
would help to be explicit.

If the sending side restriction is made explicit, then the text you 
propose for the receiving side is acceptable, although I would 
personally prefer that it used an upper case SHOULD for ignoring the 
whole TLV.  This preference is driven by a desire for robustness and 
predictability in interoperation.

Yours,
Joel

On 11/9/17 8:48 AM, Matthieu Boutier wrote:
>> maybe I summon the wrath of the Gods of the Internet.
> 
> Hey! What's the protocol for that? :p
> 
>> If you don't expect this to ever be useful, no need to specify it.
> 
> Looks good for me, does something like the following make sense?  Should we
> recommend something?
> 
>      A node does not expect to receive any TLV with two Source Prefix sub-TLVs or
>      more.  Whenever that occurs, the behaviour is undefined: an implementation
>      may drop the whole packet, the whole TLV or consider only just one of the
>      sub-TLVs (this can be the case if the implementation does not check if
>      multiple sub-TLVs are sent).
> 
> Toke, would you like to see: "It is recommended to ignore the whole packet".
> (lower case "recommended")
> 
> Matthieu
> 
> _______________________________________________
> babel mailing list
> babel@ietf.org
> https://www.ietf.org/mailman/listinfo/babel
>