IETF Logo Mail Archive

Re: [RTG-DIR] Rtgdir early review of draft-ietf-babel-hmac

Michael McBride <Michael.McBride@huawei.com> Thu, 20 September 2018 01:53 UTC

Return-Path: <Michael.McBride@huawei.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6A44512D7EA; Wed, 19 Sep 2018 18:53:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eprzhUi0ykaT; Wed, 19 Sep 2018 18:53:07 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 63B41128C65; Wed, 19 Sep 2018 18:53:07 -0700 (PDT)
Received: from lhreml704-cah.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 8F65DB1518F14; Thu, 20 Sep 2018 02:53:04 +0100 (IST)
Received: from SJCEML703-CHM.china.huawei.com (10.208.112.39) by lhreml704-cah.china.huawei.com (10.201.108.45) with Microsoft SMTP Server (TLS) id 14.3.399.0; Thu, 20 Sep 2018 02:53:05 +0100
Received: from SJCEML521-MBS.china.huawei.com ([169.254.2.77]) by SJCEML703-CHM.china.huawei.com ([169.254.5.77]) with mapi id 14.03.0415.000; Wed, 19 Sep 2018 18:53:00 -0700
From: Michael McBride <Michael.McBride@huawei.com>
To: "d3e3e3@gmail.com" <d3e3e3@gmail.com>
CC: "draft-ietf-babel-hmac@ietf.org" <draft-ietf-babel-hmac@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "babel-chairs@ietf.org" <babel-chairs@ietf.org>
Thread-Topic: Rtgdir early review of draft-ietf-babel-hmac
Thread-Index: AQHUUISofsufRp5cLEG/f3lyc47CwA==
Date: Thu, 20 Sep 2018 01:52:59 +0000
Message-ID: <etPan.5ba2fd7b.2d5238c3.1805@Mikes-iPhone>
References: <8CCB28152EA2E14A96BBEDC15823481A1CD5B548@sjceml521-mbs.china.huawei.com>, <CAF4+nEHJqT0oN8_weSi_a9-U=gR_BKEHaxbYygcVdHOkx80QLw@mail.gmail.com>
In-Reply-To: <CAF4+nEHJqT0oN8_weSi_a9-U=gR_BKEHaxbYygcVdHOkx80QLw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Content-Type: multipart/alternative; boundary="_000_etPan5ba2fd7b2d5238c31805MikesiPhone_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/XChcDxUZoPQYPILisBaBYkGvyRk>
Subject: Re: [RTG-DIR] Rtgdir early review of draft-ietf-babel-hmac
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Sep 2018 01:53:10 -0000

Yes, sorry I forgot to include the wg. Thanks.

Mike
Sent from HUAWEI AnyOffice
From: Donald Eastlake
To: Michael McBride;
Cc: draft-ietf-babel-hmac@ietf.org; rtg-dir@ietf.org; babel-chairs;
Subject: Re: Rtgdir early review of draft-ietf-babel-hmac
Time: 2018-09-19 17:17:24


Hi Mike,

Thanks for the review. OK if I forward to the babel WG mailing list?

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 1424 Pro Shop Court, Davenport, FL 33896 USA
 d3e3e3@gmail.com<mailto:d3e3e3@gmail.com>


On Wed, Sep 19, 2018 at 7:46 PM Michael McBride <Michael.McBride@huawei.com<mailto:Michael.McBride@huawei.com>> wrote:
I have been selected to do a routing directorate “early” review of draft-ietf-babel-hmac.

Document: draft-ietf-babel-hmac-00
Reviewer: Mike McBride
Review Date: 19-09-2018

Intended Status: Standards Track

Comments:

I only found a few nits. Great job with the draft, especially being a 00. The nits that should be considered:


1.      Add a Terminology section to include HMAC, Babel, PC, etc

2.      1.1 Applicability Section: “The protocol defined in this document assumes that all interfaces on a given link are equally trusted and share a small set of symmetric keys (usually just one, two during key rotation).” Consider changing it to: “…(Typically one key. Two keys during a key rotation).” Otherwise it can read as “just one or two during key rotation”.

3.      4.2 Packet Transmission Section: “A Babel node may delay actually sending TLVs by a small amount…”. Consider giving an example of a small amount.

Sound reasonable?

mike

v2.23.0 | Report a Bug | By Email