[RTG-DIR] Rtgdir last call review of draft-ietf-rtgwg-yang-rib-extend-16

Zhaohui Zhang via Datatracker <noreply@ietf.org> Mon, 01 May 2023 18:43 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Zhaohui Zhang via Datatracker <noreply@ietf.org>
To: rtg-dir@ietf.org
Cc: draft-ietf-rtgwg-yang-rib-extend.all@ietf.org, last-call@ietf.org, rtgwg@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <168296662458.49135.11152971610183102502@ietfa.amsl.com>
Reply-To: Zhaohui Zhang <zzhang@juniper.net>
Date: Mon, 01 May 2023 11:43:44 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/Y-D0SJlg0i42ImkP5J9RqVROhG4>
Subject: [RTG-DIR] Rtgdir last call review of draft-ietf-rtgwg-yang-rib-extend-16

Reviewer: Zhaohui Zhang
Review result: Has Issues

I have the following one nit comment and one question:

  augment "/rt:routing/rt:ribs/rt:rib/"
    + "rt:routes/rt:route/rt:next-hop/rt:next-hop-options/"
    + "rt:next-hop-list/rt:next-hop-list/rt:next-hop"
  {
    description
      "Augment the multiple next hops with repair path.";
    uses repair-path;
  }

The description is slightly misleading. It is to agument a single next-hop in
the next-hop-list, not "multiple next hops".

Shouldn't the repair path be applicable to static routes as well?

[RTG-DIR] Rtgdir last call review of draft-ietf-r… Zhaohui Zhang via Datatracker
Re: [RTG-DIR] Rtgdir last call review of draft-ie… Yingzhen Qu
Re: [RTG-DIR] Rtgdir last call review of draft-ie… Jeffrey (Zhaohui) Zhang
Re: [RTG-DIR] Rtgdir last call review of draft-ie… Yingzhen Qu
Re: [RTG-DIR] Rtgdir last call review of draft-ie… Jeffrey (Zhaohui) Zhang
Re: [RTG-DIR] Rtgdir last call review of draft-ie… Yingzhen Qu
Re: [RTG-DIR] Rtgdir last call review of draft-ie… Acee Lindem
Re: [RTG-DIR] Rtgdir last call review of draft-ie… Jeffrey (Zhaohui) Zhang
Re: [RTG-DIR] Rtgdir last call review of draft-ie… Acee Lindem