Re: [RTG-DIR] Rtgdir last call review of draft-ietf-isis-sr-yang-17

"Pengshuping (Peng Shuping)" <pengshuping@huawei.com> Mon, 04 December 2023 01:40 UTC

Return-Path: <pengshuping@huawei.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4F823C14CE24; Sun, 3 Dec 2023 17:40:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.204
X-Spam-Level:
X-Spam-Status: No, score=-4.204 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SIa2rw3OpBLu; Sun, 3 Dec 2023 17:40:04 -0800 (PST)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3EFAAC14CE22; Sun, 3 Dec 2023 17:40:04 -0800 (PST)
Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Sk5nr3GK8z67N4y; Mon, 4 Dec 2023 09:35:12 +0800 (CST)
Received: from lhrpeml500001.china.huawei.com (unknown [7.191.163.213]) by mail.maildlp.com (Postfix) with ESMTPS id 3AC1F140A70; Mon, 4 Dec 2023 09:40:01 +0800 (CST)
Received: from canpemm500007.china.huawei.com (7.192.104.62) by lhrpeml500001.china.huawei.com (7.191.163.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Dec 2023 01:40:00 +0000
Received: from canpemm500008.china.huawei.com (7.192.105.151) by canpemm500007.china.huawei.com (7.192.104.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Dec 2023 09:39:58 +0800
Received: from canpemm500008.china.huawei.com ([7.192.105.151]) by canpemm500008.china.huawei.com ([7.192.105.151]) with mapi id 15.01.2507.035; Mon, 4 Dec 2023 09:39:58 +0800
From: "Pengshuping (Peng Shuping)" <pengshuping@huawei.com>
To: Yingzhen Qu <yingzhen.ietf@gmail.com>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-isis-sr-yang.all@ietf.org" <draft-ietf-isis-sr-yang.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: Rtgdir last call review of draft-ietf-isis-sr-yang-17
Thread-Index: AQHaIeBBmRKTlvbJ1kWSNFge1AjS/rCYYV7w
Date: Mon, 04 Dec 2023 01:39:58 +0000
Message-ID: <555a23433d7c416c8bb97a5caa262da2@huawei.com>
References: <170081504148.43244.1820947622791098734@ietfa.amsl.com> <CABY-gOO-660bnpCCqpmo+t2Qc7Af2pODAbXQmKQ1v9rs1OqrQA@mail.gmail.com>
In-Reply-To: <CABY-gOO-660bnpCCqpmo+t2Qc7Af2pODAbXQmKQ1v9rs1OqrQA@mail.gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.112.41.150]
Content-Type: multipart/alternative; boundary="_000_555a23433d7c416c8bb97a5caa262da2huaweicom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/b2lC55RUJxyNMZiNKcC16BzZJPw>
Subject: Re: [RTG-DIR] Rtgdir last call review of draft-ietf-isis-sr-yang-17
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Dec 2023 01:40:08 -0000

Hi Yingzhen,

Your responses are good to me. Thank you!

Best regards,
Shuping



From: Yingzhen Qu [mailto:yingzhen.ietf@gmail.com]
Sent: Tuesday, November 28, 2023 5:49 PM
To: Pengshuping (Peng Shuping) <pengshuping@huawei.com>
Cc: rtg-dir@ietf.org; draft-ietf-isis-sr-yang.all@ietf.org; last-call@ietf.org; lsr@ietf.org
Subject: Re: Rtgdir last call review of draft-ietf-isis-sr-yang-17

Hi Shuping,

Thanks for the review. Please see my response below inline.

Thanks,
Yingzhen

On Fri, Nov 24, 2023 at 12:37 AM Shuping Peng via Datatracker <noreply@ietf.org<mailto:noreply@ietf.org>> wrote:
Reviewer: Shuping Peng
Review result: Has Issues

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The
Routing Directorate seeks to review all routing or routing-related drafts as
they pass through IETF last call and IESG review, and sometimes on special
request. The purpose of the review is to provide assistance to the Routing ADs.
For more information about the Routing Directorate, please see
http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would
be helpful if you could consider them along with any other IETF Last Call
comments that you receive, and strive to resolve them through discussion or by
updating the draft.

Document: draft-ietf-isis-sr-yang
Reviewer: Shuping Peng
Review Date: 2023-11-24
IETF LC End Date: 2023-11-30
Intended Status: Standards

Summary:
I have some minor concerns about this document that I think should be resolved
before publication.

Major Issues:
 "No major issues found."

Minor Issues:
1. Page 3, when configure adjacency-sid, do we need to indicate the neighbor's
systemid or IP in order to differentiate the different neighbors in the case of
having multiple neighbors?

augment /rt:routing/rt:control-plane-protocols
          /rt:control-plane-protocol/isis:isis/isis:interfaces
          /isis:interface:
    +--rw segment-routing
       +--rw adjacency-sid
          +--rw adj-sids* [value]
          |  +--rw value-type?   enumeration
          |  +--rw value         uint32
          |  +--rw protected?    boolean

[Yingzhen]:  thanks for catching this. We didn't consider LAN interfaces, will fix this in the next version.

2. Page 4, since LFA, RLFA and TI-LFA are the three algorithm for computing
backup paths, why they are not in sibling relationship?

  augment /rt:routing/rt:control-plane-protocols
          /rt:control-plane-protocol/isis:isis/isis:interfaces
          /isis:interface/isis:fast-reroute:
    +--rw ti-lfa {ti-lfa}?
       +--rw enable?   boolean
  augment /rt:routing/rt:control-plane-protocols
          /rt:control-plane-protocol/isis:isis/isis:interfaces
          /isis:interface/isis:fast-reroute/isis:lfa/isis:remote-lfa:
    +--rw use-segment-routing-path?   boolean {remote-lfa-sr}?
[Yingzhen]: the assumption here is that LFA is preferred when available.  Although in the ti-lfa draft, it says that LFA may not be preferred over ti-lfa, however if there is LFA route available, the chance of it also being post-convergence path is very high. I'll check with the ti-lfa authors and some implementations.

3. Page 4, the keys of the global-block and local-block are not clear.

  augment /rt:routing/rt:control-plane-protocols
          /rt:control-plane-protocol/isis:isis/isis:database
          /isis:levels/isis:lsp/isis:router-capabilities:
    +--ro sr-capability
    |  +--ro sr-capability
    |  |  +--ro sr-capability-bits*   identityref
    |  +--ro global-blocks
    |     +--ro global-block* []
    |        +--ro range-size?    uint32
    |        +--ro sid-sub-tlv
    |           +--ro sid?   uint32
    +--ro sr-algorithms
    |  +--ro sr-algorithm*   uint8
    +--ro local-blocks
    |  +--ro local-block* []
    |     +--ro range-size?    uint32
    |     +--ro sid-sub-tlv
    |        +--ro sid?   uint32
    +--ro srms-preference
       +--ro preference?   uint8

[Yingzhen]: these are read-only data, so key is not a must.

4. Currently there is no configuration node for the micro loop avoidance
(https://datatracker.ietf.org/doc/draft-bashandy-rtgwg-segment-routing-uloop/),
any thoughts or plan on it?
[Yingzhen]: we can do an augmentation when the mentioned draft is ready to progress.