[RTG-DIR] RtgDir review: draft-ietf-isis-segment-routing-extensions-20

<7riw77@gmail.com> Sat, 10 November 2018 15:50 UTC

Return-Path: <7riw77@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E759B124408; Sat, 10 Nov 2018 07:50:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.749
X-Spam-Level:
X-Spam-Status: No, score=-1.749 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ucpoue9r-ULy; Sat, 10 Nov 2018 07:50:40 -0800 (PST)
Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A929212426A; Sat, 10 Nov 2018 07:50:37 -0800 (PST)
Received: by mail-oi1-x235.google.com with SMTP id u130-v6so3943084oie.7; Sat, 10 Nov 2018 07:50:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:thread-index:content-language; bh=GBE/lWbaVj0Lw3a2RegW1QpiZ2GKxteGLDGLhA8ZQX8=; b=Wv5qNW9KAExjf6rX4oApU4vl6eFiwfp84mTSOqn9bENXX6l8FxgqrxOInUryq3rb3Z XvRjxldvkWvXo3RzWKtWtOwZso9JUUWWoWDE4JN2r9IOZaOslteKRrsdPgZnJE3uSEen nqv6xIOjrHmdUbh4I00/ST5TUsEC2Hen9KESpPBNoBfmGKEMgwoIuwMETWzk9RjlqyNA a9GtI/MiiRAM627OhrzpEqT8dUcWyKbcGo8HYOk4hcSJ2D6CuitLkUtGr310J1Ffl//F EEEsmlXUSji/aeTXJ091+VTCnLnAqm/EiV/qs7ut8pnL/1Jwv11d9QBcgASI1O7OcnYO hcgQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:thread-index:content-language; bh=GBE/lWbaVj0Lw3a2RegW1QpiZ2GKxteGLDGLhA8ZQX8=; b=R8UXtpDcTTwLdEBT3nNpFb2R5SEOIvjEYiRmjJP0zmMeCgcm/LPPJwgUK9A3/onnM7 LBqeOmRJKt8Bp56eAw4PLL/ysA5McMJOdhztKkB/ZCJpoa1ldn2bYZNqLTdU3rtPIvdu xyLQ2QOEMiIDE9LdipIa5ga3phMmTEhaaHfy+vR0hFm900RkcDNO9P7yTnGC1MKVABIY Xho9pfEdD64ZdqC2oeMosJwGsFaqgWfTJwWBut3nSYa83wwcflxcePKG66rk1hJ4+TqF K9bgdVpE00Wx6OORI00Qq6fY1NwKZvydtgLu4lmFs6sFYKIPDgGzqQ2ZWMVTBuTqem/X 5OSQ==
X-Gm-Message-State: AGRZ1gLHzDnjsYKiA1R5lTnQgJhA2WR2kO1Y8cjKxKCbo3t9EVQfa2sR tU5fNPYytjDvTEj1g5neL59M1cQW
X-Google-Smtp-Source: AJdET5d1Gdimb/fxVXAf/ECBJOm/JcWvHEaqFHZZqwkSnNqVyJH+53NVv5fIBxf6CdWkwdYnZl/UbA==
X-Received: by 2002:aca:e607:: with SMTP id d7-v6mr7024011oih.68.1541865036628; Sat, 10 Nov 2018 07:50:36 -0800 (PST)
Received: from Russ ([2600:1700:720:1050:1453:2926:a4d6:568c]) by smtp.gmail.com with ESMTPSA id n129-v6sm4012310oif.23.2018.11.10.07.50.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Nov 2018 07:50:36 -0800 (PST)
From: <7riw77@gmail.com>
To: <rtg-ads@ietf.org>
Cc: <rtg-dir@ietf.org>, <draft-ietf-isis-segment-routing-extensions.all@ietf.org>, <lsr@ietf.org>
Date: Sat, 10 Nov 2018 10:50:34 -0500
Message-ID: <051f01d4790d$1edfdbb0$5c9f9310$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AdR5DQEetHFILxLVQJuDw/lQFwBnKQ==
Content-Language: en-us
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/dPRCzitAXPBeRPpflAxmYVp5Z7c>
Subject: [RTG-DIR] RtgDir review: draft-ietf-isis-segment-routing-extensions-20
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Nov 2018 15:50:42 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-isis-segment-routing-extensions-20
Reviewer: Russ White
Review Date: 10 November 2018
IETF LC End Date: 12 December 2018
Intended Status: Standards Track

Summary: 

This document is basically ready for publication, but has nits that should be considered prior to publication.

Overall, this document is well written, and the mechanisms described are well thought out. 

Major Issues:

No major issues found.

Minor Issues:

No minor issues found.

Nits:

Section 2.1

Algorithms identifiers are defined in Section 3.2.

"Algorithm" rather than "Algorithms."

Sections 2.1 and 2.2

"Length" is listed as "variable," but not further definition is provided. From the text it seems like valid values here would be 3 or 20, in octets, as this is explicit in section 2.3, but it might be good to clarify (ie, just copy the text for "Length" in section 2.3 to these sections as well).

😊 /r