IETF Logo Mail Archive

Re: [RTG-DIR] RtgDir review: draft-ietf-ospf-yang-23.txt

Ravi Singh <ravis@juniper.net> Fri, 19 July 2019 02:44 UTC

Return-Path: <ravis@juniper.net>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B72DF120116; Thu, 18 Jul 2019 19:44:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5XI6ao3vRx7U; Thu, 18 Jul 2019 19:44:10 -0700 (PDT)
Received: from mx0a-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8DE1C120142; Thu, 18 Jul 2019 19:44:10 -0700 (PDT)
Received: from pps.filterd (m0108156.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6J2dXwd003576; Thu, 18 Jul 2019 19:44:10 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=PPS1017; bh=TQU385cO0AjqyKPUjRGTKQISDbHIvFaGjGzLSS7UeCY=; b=TYuAnbGGqR063co/KYYeknFy1UmqoutWATP3N80fsTBH7FjUI5AWcSwSDHIAZmYfYPHu 8ByYu9v9lA5sxpgAh5LgPjAKstt8jKi79xrf5CyM2Rt87YRp7UGSgvZnS0Bd8xPh548K Erf71D1NkHloFonlBjL2csAB6DK9S7VuuuQy0NjCl39lk4GpafUq6yGcpMwzfzJxCppc eX75wsr4ZCGf035tKLlWF9KWthxyAMlkJ8a4gb2UoOA7TAJlpl7lmmmwLGEERDJx+QQY bjokEqgyMXK3KvLycpkR4KPswcldGMmYYMoqO+N/1rtz3xGAqlO2eSWMLoBGpgLTqU7R Kw==
Received: from nam02-cy1-obe.outbound.protection.outlook.com (mail-cys01nam02lp2053.outbound.protection.outlook.com [104.47.37.53]) by mx0a-00273201.pphosted.com with ESMTP id 2ttytk8f5b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2019 19:44:10 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PX95g/686BzRmHhEC9LuvTUxhitBYADdqUccjX2OQYmbJ7iAV1IykyM+t0uHVePhyCqD7FRLKbC81HhdLIRfePt1KTg+RhSDYC/sYefHEYnROgEbnEFHfyd4C57/3n9OdL8+SQnsQ7w8D/nf6T2stS7u/nWbwI3CpHnwDxEQxp2WgiOXLZCQ2jfVMsxxvcTZ5oqW9y0RdCU5ffm9dPZNG3w+Jap0Jbfq0c2JAZI0puDALqNTY3C4QGMLqwZmd3X2gKxDnY7OtC2pXAhDjZsSAHsx/oE9OKHHbnwhVZcvdEFazd9g5qMC9QOEx/O5TIeIZnTGRivMucdfUwc3kZ178Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TQU385cO0AjqyKPUjRGTKQISDbHIvFaGjGzLSS7UeCY=; b=oDBjedIdjmMYt4sWHooHKyenUpavla/EL5qiifWu2uAsMTc0OcGfDcz6iGgkoVMAc52XwTvJ0jKtJNy19yu987tGr1jEEtlvF6Man6t1WkBZkR9yUjR5n4TwCGxc+RWfGyocJ7Q2Eu5Img6Hl3G41eC1kTHTGS7ojZGCQt/C/K5yo7ZBPxj+aoahnVTK9FtARkMzBQF4QlXgyFILY9K1QsRaUHJ6IfaJLWtm1wr5PZ9EF9raPsBUcq63c45tVQV3k1KvYcyzmAifn+1wH2xIlfURTluOb+edMG232/f995t6o7UDYE8aU/FQPWMYGjGx62ersJ3Skk0gKAnSc6Toow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=juniper.net;dmarc=pass action=none header.from=juniper.net;dkim=pass header.d=juniper.net;arc=none
Received: from BYAPR05MB6470.namprd05.prod.outlook.com (20.178.233.83) by BYAPR05MB6135.namprd05.prod.outlook.com (20.178.55.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.8; Fri, 19 Jul 2019 02:44:07 +0000
Received: from BYAPR05MB6470.namprd05.prod.outlook.com ([fe80::29fb:c356:de9a:ed56]) by BYAPR05MB6470.namprd05.prod.outlook.com ([fe80::29fb:c356:de9a:ed56%7]) with mapi id 15.20.2115.005; Fri, 19 Jul 2019 02:44:07 +0000
From: Ravi Singh <ravis@juniper.net>
To: Routing ADs <rtg-ads@tools.ietf.org>
CC: Routing Directorate <rtg-dir@ietf.org>, "draft-ietf-ospf-yang@ietf.org" <draft-ietf-ospf-yang@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-ospf-yang-23.txt
Thread-Index: AdU920QESuA90qdgQTa38PuKoaYVVgAAHxeg
Date: Fri, 19 Jul 2019 02:44:07 +0000
Message-ID: <BYAPR05MB647024C782C69AEEA55D1B4AABCB0@BYAPR05MB6470.namprd05.prod.outlook.com>
References: <BYAPR05MB64709E8C4755E255DD723E94ABCB0@BYAPR05MB6470.namprd05.prod.outlook.com>
In-Reply-To: <BYAPR05MB64709E8C4755E255DD723E94ABCB0@BYAPR05MB6470.namprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [66.129.239.11]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 28b22b75-7880-4daf-0949-08d70bf2f8a1
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:BYAPR05MB6135;
x-ms-traffictypediagnostic: BYAPR05MB6135:
x-ms-exchange-purlcount: 3
x-microsoft-antispam-prvs: <BYAPR05MB6135962E84D0A4CC4EEEE6DAABCB0@BYAPR05MB6135.namprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-forefront-prvs: 01039C93E4
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(366004)(346002)(376002)(396003)(136003)(39860400002)(199004)(189003)(6116002)(2940100002)(26005)(790700001)(102836004)(53936002)(606006)(68736007)(6246003)(54906003)(9686003)(186003)(6306002)(486006)(55016002)(6436002)(316002)(236005)(6506007)(14444005)(478600001)(71190400001)(229853002)(53546011)(25786009)(99286004)(256004)(8676002)(71200400001)(81166006)(81156014)(7696005)(4326008)(3846002)(14454004)(54896002)(7736002)(66066001)(74316002)(76176011)(6916009)(446003)(5660300002)(8936002)(86362001)(52536014)(476003)(66476007)(66446008)(66556008)(2906002)(66946007)(64756008)(11346002)(76116006)(33656002); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR05MB6135; H:BYAPR05MB6470.namprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: r3diuG8uqPyotUWuIei+9tUQEXPU/JEp3whUZh/8cndtWSbRVs8YwYqUlOU3uNWY/jx9puMx3aQI9KxOGybRt3uu1hclZY0+N0epXggIgu6ihxfFENUrKTzAoCD4zCBOYGR3WhXGouOOe2zU9284MWqy8shfsFgI0a3QPJv2EOB/2Ibe0+fcvdFMCBSUz3BcWepf3vryyKTWCmqNXqh7V+sEPlt8ojv8xPwSKrizvZCcGSmyo/F4FZmK/ELeU/h8hGQd31EXelBttw1n1052L2vXrbiYzwBncW/RsHSSriWIjk7DBWgt2ZzXrUvKIT0ZZjcDIGrVt9o7WMTIZmzddCyibNU0AJ5QrthPdv4ThPnrmHoqZwbNy7djqtfa4A35B+PSAKUEhLEi6iz/Ri6r4z93TU1tcbDvjEuaZpPvQ3s=
Content-Type: multipart/alternative; boundary="_000_BYAPR05MB647024C782C69AEEA55D1B4AABCB0BYAPR05MB6470namp_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 28b22b75-7880-4daf-0949-08d70bf2f8a1
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2019 02:44:07.4470 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ravis@juniper.net
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB6135
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-19_02:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907190029
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/m09fhMiwaBLt7Utj-eQsIf9NHus>
Subject: Re: [RTG-DIR] RtgDir review: draft-ietf-ospf-yang-23.txt
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Jul 2019 02:44:13 -0000

+ lsr@ietf.org

From: Ravi Singh
Sent: Thursday, July 18, 2019 7:43 PM
To: Routing ADs <rtg-ads@tools.ietf.org>
Cc: Routing Directorate <rtg-dir@ietf.org>; draft-ietf-ospf-yang@ietf.org; ospf@ietf.org
Subject: RtgDir review: draft-ietf-ospf-yang-23.txt

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-ospf-yang-23.txt
Reviewer: Ravi Singh
Review Date: 7/18/2019
Intended Status: Standards Track

Summary:
This document is basically ready for publication, but has nits that should be considered prior to publication.

This is a very comprehensively written document.
However, reading through it is a bit laborious due to the really large # of config and operational items described.
So, my review was primarily aimed at readability rather than correctness of the YANG syntax.

Specific comments/queries:
1.       What is the reasoning for sticking the multi-topology sub-container(s) at the same levels as area instead of at the level of sub-containers under area(s)?
2.       Pg 23: why both (prefix "rt-types";) and (prefix "iana-rt-types";) ?
3.       Pg 25-28: "feature two-part-metric {" and "feature key-chain {" might be readjusted in order of listing to make it the same as that in section 2.4 for a bit of enhanced readability.

Regards
Ravi

v2.23.0 | Report a Bug | By Email