[RTG-DIR]Re: Rtgdir last call review of draft-ietf-rtgwg-segment-routing-ti-lfa-13

Ahmed Bashandy <abashandy.ietf@gmail.com> Tue, 02 July 2024 04:55 UTC

Return-Path: <abashandy.ietf@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 92414C180B44; Mon, 1 Jul 2024 21:55:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3g10tXzn-2co; Mon, 1 Jul 2024 21:55:10 -0700 (PDT)
Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B992EC17C8B3; Mon, 1 Jul 2024 21:55:10 -0700 (PDT)
Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2c95ca60719so135196a91.3; Mon, 01 Jul 2024 21:55:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719896110; x=1720500910; darn=ietf.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dyvUY7UAs0LnR8t3GyxbrDLd0ySgaeRQDnac0Eq3yBo=; b=PzIXgQvJPLElytkXilAwVv3pdQtqMzIsEWs1JfrUpf+t0cELpWZfLzE4TX0cnA7XCe 3qccQVNLPJtjuXxN2nNCaztH8ulaH/Ux+JWqbc4OzMU29/aYlxs3IXs3PobNFVCzLIly aEt9KgC2gnYjcP4rX6iIpewg+EHGaRo4Unf2f/+29UCUSQBQAFffpbZR8eDH/k83iv1I VL0Z4tNL5fg4rGOqVaImlhZYYXAC3tUHOHJYtwF19RTbD2ftIOX7zBdzkzYYu3MMbqM/ HWAnPR1mEz4+gp033VTUxceXJfMg7xzLfRqrtBbWcrLO1c51namsQwUs1vzovdRN25UP pzEw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719896110; x=1720500910; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dyvUY7UAs0LnR8t3GyxbrDLd0ySgaeRQDnac0Eq3yBo=; b=vDPst9KGPI1ibx1EmlAcfRAQjF8UMmk8RGGSf0mmwfTutIBzkYyThV8k67RfOqHWkM WF0oLN/R4FS/eXT2gP7o7z88CqeQVsYIM7Es0IbKWeQV28DgaBzwuAjOeWwFV/hVrpIm AcuNZt4zx7a9kiHj6alWfu8aua8o/Nyr9/mp3qt30AIBovUHAjC/PG6bZ7XoYbvKFTzQ CYMdwiYCjXvIh1HSZ2i9xHcfJSE/0YjS0BqbDs8ZVhbU7YpodmZd1HC2XtR9SFTXEtv3 4UWg6+oZuFdlsuigoW30oBDef5RD6/56beaCWc3AakFvSdGLBN2pUsTXSCJugigvypQY xBhA==
X-Forwarded-Encrypted: i=1; AJvYcCUCmSHKbPq6V0FkoXQzSSCoaMyE1Miv9zYkrg9+W3PTOyGzHmCiYXAuqHVWOw9CN2Cqr0Qr4eaXfWSYZSyUdX68jV2nQEkU3qQyom5OeA9wkrzfI7VzmzXZjE/rLgLI4okRKA8I
X-Gm-Message-State: AOJu0Yw5+5ol0R3abSCgrEHRMdhqWdu/Z++ZLA3pbv2OYe0vUg+HbbCb ZZp4AspzBdZHQhx3VhNJXgy4iygZdmKI9CHVT6HxqpykdNKXY8LI64s+Jw==
X-Google-Smtp-Source: AGHT+IHGxoD1Lx+fH2UG/C6XRtrMZe9gQR0WBR4mSgWvh2m6xnnHdLsrhn1S2zAW+qnCVdtDvmpfqw==
X-Received: by 2002:a17:90a:d106:b0:2c8:da73:af82 with SMTP id 98e67ed59e1d1-2c93d729fd2mr4074997a91.10.1719896109260; Mon, 01 Jul 2024 21:55:09 -0700 (PDT)
Received: from ?IPV6:2607:fb91:79af:8424:819d:2ca6:760b:10b3? ([2607:fb91:79af:8424:819d:2ca6:760b:10b3]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c91ce740c2sm7736801a91.33.2024.07.01.21.55.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jul 2024 21:55:08 -0700 (PDT)
Message-ID: <d452651c-2ef4-4cd3-a8dd-852df7178231@gmail.com>
Date: Mon, 01 Jul 2024 21:55:04 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Ben Niven-Jenkins <ben@niven-jenkins.co.uk>, rtg-dir@ietf.org
References: <170913456881.24344.13631363012229060407@ietfa.amsl.com>
Content-Language: en-US
From: Ahmed Bashandy <abashandy.ietf@gmail.com>
In-Reply-To: <170913456881.24344.13631363012229060407@ietfa.amsl.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Message-ID-Hash: DNY2YBILZFRIMX7PLANNVYEJZTPDRO54
X-Message-ID-Hash: DNY2YBILZFRIMX7PLANNVYEJZTPDRO54
X-MailFrom: abashandy.ietf@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-rtg-dir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-rtgwg-segment-routing-ti-lfa.all@ietf.org, last-call@ietf.org, rtgwg@ietf.org
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [RTG-DIR]Re: Rtgdir last call review of draft-ietf-rtgwg-segment-routing-ti-lfa-13
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/hpZ2_joc8LX5ThV7E0Tb5BvYrl4>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Owner: <mailto:rtg-dir-owner@ietf.org>
List-Post: <mailto:rtg-dir@ietf.org>
List-Subscribe: <mailto:rtg-dir-join@ietf.org>
List-Unsubscribe: <mailto:rtg-dir-leave@ietf.org>

Sorry for the garbled subject. I am re-sending the reply with subject 
intact for easy tracking

Thanks a lot for the comments

Version 16 addresses the comments

See #Ahmed


On 2/28/24 7:36 AM, Ben Niven-Jenkins via Datatracker wrote:
> Reviewer: Ben Niven-Jenkins
> Review result: Has Nits
>
> Hello,
>
> I have been selected as the Routing Directorate reviewer for this draft. The
> Routing Directorate seeks to review all routing or routing-related drafts as
> they pass through IETF last call and IESG review, and sometimes on special
> request. The purpose of the review is to provide assistance to the Routing ADs.
> For more information about the Routing Directorate, please see
> https://wiki.ietf.org/en/group/rtg/RtgDir
>
> Although these comments are primarily for the use of the Routing ADs, it would
> be helpful if you could consider them along with any other IETF Last Call
> comments that you receive, and strive to resolve them through discussion or by
> updating the draft.
>
> Document: draft-ietf-rtgwg-segment-routing-ti-lfa-13
> Reviewer: Ben Niven-Jenkins
> Review Date: 28th February 2024
> IETF LC End Date: Not known
> Intended Status: Proposed Standard
>
> Summary:
> This document is basically ready for publication but has nits that should be
> considered prior to publication.
>
> Comments:
> The draft is well written and the scenarios and solutions described in the
> draft are understandable and easy to follow.
>
> Major Issues:
> No major issues found.
>
> Minor Issues:
> The paragraphs at the bottom of the introduction section provide good summary
> of each section but skips over (does not provide a summary for) sections 8, 9 &
> 10. Was this intentional?
#Ahmed Version 16 provides a summary for sections 8, 9, and 10
>
> Nits:
> Section 1 - Acronyms lists TLDP as "TLDP: Target Label Distribution Protocol."
> s/Target/Targeted/
##Ahmed: We no longer need to use this acronym and we use "Targeted 
Label Distribution Protocol" only once . So it is removed from the 
acronyms section.
>
> Thanks
> Ben
>
>
>