Re: [RTG-DIR] Routing directorate review of draft-ietf-lisp-rfc6833bis-13

Dino Farinacci <farinacci@gmail.com> Fri, 07 September 2018 18:42 UTC

Return-Path: <farinacci@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 250301252B7; Fri, 7 Sep 2018 11:42:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1qpoQ0FoA3di; Fri, 7 Sep 2018 11:41:57 -0700 (PDT)
Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C80BC12008A; Fri, 7 Sep 2018 11:41:57 -0700 (PDT)
Received: by mail-pf1-x442.google.com with SMTP id h79-v6so7409992pfk.8; Fri, 07 Sep 2018 11:41:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=/NnpapEtcuJUGwZYnai3dQz74De11RiAgdSQpnr4HgE=; b=JNYuYyIvRMK/Tm0r9EiGD0hAACGsBxEnj87WrfGLt8+lfvaRVdb+UGG6BdE7c3DYuv S+Yqqf52FKGTrG2BeHCFuAzXkJA0haPehZSWaRQAheUinjnelrIA5LGrO9CsctdBsHxf AM/Ycg8pX3w4aMwVRlt0Vd0j7NvNyzQOLuK67A588pmA0ce5nkYma0Jy7UXO28FA50Ld b8FKUXGpTI8/icTRjOYLDhTUl037+PQCoruND4QIoQsorivCADyVPu1mXkEfxD4z1mr9 pYSQPV6sWXMjp/POX4HYPvClbqNcmOOgExnXbDCbFJQawg0sSBj3w3ugUVFYZAtcF6HJ 0+hw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=/NnpapEtcuJUGwZYnai3dQz74De11RiAgdSQpnr4HgE=; b=aMFBFn7+mhGFjSA/Tr9A/HFTpleve/KEyRcSgDfEjOPtXbMussVDusL2EDx+oE2ZQB Vp73PYbxgPTztGs1tRnHWD8joEL0EsZ0YdNGUp8gXIaREgh0Px9t68yJAzbq5vy6PQm6 7M6FJQ4dANwo+5MVgz1eAwnd5/HcPuYYkMrIk+QscHsEzQgprJC6PTirev3bCcfrJqAD v1RuYzfPAN9MU3WWWuSOUpe+0VZrAitab+pv9Nwm2+V9skESRfVy50qhP6T5B7QWrawf E0XFX9hZF81ZyXUCcZKrLQmiS9YWLUNxEdHNQJ5VpxDOriTuDSF6mWlM0enmrmb1Bzsy +99g==
X-Gm-Message-State: APzg51A34bUS0BPtwgPWISbzpxMwyucbGvHCaTWjCCs4XudY5NllAB5d 7L/FqqvkWEnb3DQKNpE2lWoyr3f2
X-Google-Smtp-Source: ANB0VdbvbsX9JKaOdFrLErNSS0oM4NrBKbYjN05iPE0z5AK5iaSHfAM81+5HqrnVzGGSmMCfmk12Wg==
X-Received: by 2002:a62:4bc6:: with SMTP id d67-v6mr10042053pfj.175.1536345717370; Fri, 07 Sep 2018 11:41:57 -0700 (PDT)
Received: from [10.31.79.156] ([96.72.181.209]) by smtp.gmail.com with ESMTPSA id 74-v6sm12604911pfv.33.2018.09.07.11.41.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Sep 2018 11:41:56 -0700 (PDT)
From: Dino Farinacci <farinacci@gmail.com>
Message-Id: <56A10EEF-3CF5-4325-A7CB-337D4F22E106@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_0D86D51E-72F2-4BED-813A-F468D5360D2A"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Fri, 7 Sep 2018 11:41:55 -0700
In-Reply-To: <CY1PR0201MB143680B8D8B3602EED7441A384000@CY1PR0201MB1436.namprd02.prod.outlook.com>
Cc: "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "draft-ietf-lisp-rfc6833bis.all@ietf.org" <draft-ietf-lisp-rfc6833bis.all@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "lisp@ietf.org" <lisp@ietf.org>
To: Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>
References: <CY1PR0201MB143680B8D8B3602EED7441A384000@CY1PR0201MB1436.namprd02.prod.outlook.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/kMM2cL7X8ODEBRHESPeKteunk7I>
Subject: Re: [RTG-DIR] Routing directorate review of draft-ietf-lisp-rfc6833bis-13
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Sep 2018 18:42:00 -0000

> Hi there
>  
> I have done a routing directorate review of this draft.
> https://datatracker.ietf.org/doc/draft-ietf-lisp-rfc6833bis/?include_text=1
>  
> The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
>  
> Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.
>  
> Document: draft-ietf-lisp-rfc6833bis-13 
> Reviewer: Jon Hardwick 
> Review Date: 7 Sep 2018 
> IETF LC End Date: 31 Aug 2018 
> Intended Status: Proposed Standard

Thanks for your comments Jon.

> Comments
> This was my first foray into LISP, so I also read draft-ietf-lisp-rfc6830bis and draft-ietf-lisp-introduction as ramp-up.  I found all three documents to be very readable and useful.

That is good to hear. Kudos to the working group for this.

> I think this document is ready to be published.  I noted a few minor comments and questions as I read through it, below.
>  
> sec3: Map-Register contains “one or more RLOCs to reach ETR(s)”.  How do you deregister all RLOCs for an EID?

You set the Record TTL in the EID-record to 0. It is stated here:



> sec5: (Diagrams) It seems a bit redundant to specify the IPv4/6 and UDP header formats here.  Just refer to the RFCs.

We want to be crystal clear and don’t want readers to have to shuffle documents. Those header formats are pretty etched in stone, so we don’t think we’ll have a document maintenance problem keeping it up to date.

> sec5: “When a UDP Map-Reply Map-Notify”  <- insert comma

Fixed.

> sec5.1: What about code point 7?  Not assigned?  Reserved?

It is assigned to a non-working group draft. NAT-traversal has not gone through working group process so far.

> sec6.1: “from those sites to which” should be “to those sites to which”

Fixed.

> sec6.1: “for the last minute” is arbitrary and should be left to the implementation / deployment to decide IMO.

Its kind of an architecture constant.

> sec7.1: Have you considered using multi-hop BFD instead of RLOC probing?

Yes. But there are too many LISP features we need that would not be appropriate in a more generalized BFD mechanism. We use RLOC-probing, not only for reachability testing, but to convey new RLOC changes, LISP-crypto keys, as well as differnet RLOC types.

> Best regards
> Jon

I will publish a new version of rfc6830bis and rfc6833bis on Monday with accumilated changes from various comments.

Thanks again,
Dino