[RTG-DIR] RtgDir review: draft-ietf-spring-segment-routing-central-epe-07.txt

"Andrew G. Malis" <agmalis@gmail.com> Fri, 08 December 2017 00:06 UTC

Return-Path: <agmalis@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 382B8128B93; Thu, 7 Dec 2017 16:06:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A_1-39umF0zF; Thu, 7 Dec 2017 16:06:18 -0800 (PST)
Received: from mail-oi0-x22f.google.com (mail-oi0-x22f.google.com [IPv6:2607:f8b0:4003:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9156C128BBB; Thu, 7 Dec 2017 16:06:08 -0800 (PST)
Received: by mail-oi0-x22f.google.com with SMTP id s9so6153102oie.5; Thu, 07 Dec 2017 16:06:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=r+yEFRMGgUPRxZhvvnP26Sv8dC3kTSQJCF2Z4SjLdKI=; b=IY3BgocdyIU14g4dYysqGpoKXNuFvjoeBPgTrQ6Dhb6V8xHAsp+3m/9/WaoutTMMf6 ihK0YplZIOQYy37Qraw6GEWW+a4OYVpz1IpYzMVy51KqzfBC3lMo/dvg/VkJ0K6GHfms +YSvd0iNIhgIdnUM6fYf4gW6x37C17NbSVNrgXy298f25Wj96RziOKZO8byTFu856gxm VjX2GTzYH6to3RXsSR8xLWV4xeqejaj8eVtpQpezha/cUQRrRAIloZUvfhR3TPPsc6uJ DYOs3cZx54E2hA2H22ucOqnFPGCbRGdD4rZMAd0wA2Jv+SransELIv2lXlVM5kzpJXRJ /eKw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=r+yEFRMGgUPRxZhvvnP26Sv8dC3kTSQJCF2Z4SjLdKI=; b=NA4N2XEhyBXeFxflrklsmT3XK5DaLroiWWLrPPqA10Ly6gi0Rq/VSZ4zu2NF7S4y7E Ac3qzgYkFWo+kEDT7oAYv6fYRRqTGOLCH/Ps+0Jg3MeWnsCcF5IJlV9kbtzxONVXOwr8 q3VxPrm+yEpilbWqW9V6A3J3ij/JAu0sI5sl1wC+V9q1wtl0rdMAEa5t1A5VwCLQZ9pQ fBA0IQZAqIfkl+qARDAdWC6sA1Y1dJTwJmazbPfx7hN6Hi5gz1FG3krY6pCitM6d70ok MN/6DASMiYKzrLUD05z1SW04yvhJH8PcljNA1oUwQY/LV3L5Tj4yXY72ICAZj4v3BaUp frQA==
X-Gm-Message-State: AJaThX6Px+zySgmu07k29fqacbfJ8x3+6EhitGfV5GTqzrXHUVRaykx1 uOINbF/cD9/EWgWnxBRVAgdOP6YXjd5TVVp1CBo0gw==
X-Google-Smtp-Source: AGs4zMalUhrSdKWHIowztooOTI/8co71xTi4D3KNY8vK8x42wfdYYYOclfzoFUO/uoWfoelzvojSNjsM2NJpaK6KXug=
X-Received: by 10.202.206.78 with SMTP id e75mr23612826oig.126.1512691567686; Thu, 07 Dec 2017 16:06:07 -0800 (PST)
MIME-Version: 1.0
Received: by 10.202.83.141 with HTTP; Thu, 7 Dec 2017 16:05:47 -0800 (PST)
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Thu, 07 Dec 2017 19:05:47 -0500
Message-ID: <CAA=duU0zvExH7=0J=qRbr8-U3-t55uDRa29zbBkdyoVg2tfHhQ@mail.gmail.com>
To: "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, draft-ietf-spring-segment-routing-central-epe.all@ietf.org, "spring@ietf.org" <spring@ietf.org>
Content-Type: multipart/alternative; boundary="001a113d30fc8bf9aa055fc8f3bd"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/l4i8CpemVpWzMb9cLJBCHlvHpzM>
Subject: [RTG-DIR] RtgDir review: draft-ietf-spring-segment-routing-central-epe-07.txt
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Dec 2017 00:06:20 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft.
The Routing Directorate seeks to review all routing or routing-related
drafts as they pass through IETF last call and IESG review. The purpose of
the review is to provide assistance to the Routing ADs. For more
information about the Routing Directorate, please see ​
http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it
would be helpful if you could consider them along with any other IETF Last
Call comments that you receive, and strive to resolve them through
discussion or by updating the draft.

Document: draft-ietf-spring-segment-routing-central-epe-07.txt
Reviewer: Andy Malis
Review Date: 7 December 2017
IETF LC End Date: 30 November 2017
Intended Status: Informational

Summary:
I have some minor concerns about this document that I think should be
resolved before publication.

Comments:
This document very usefully demonstrates how Segment Routing can be used to
provide BGP Egress Peer Engineering through the use of a centralized
controller.

It has been through a number of reviews, so it is overall in good shape for
publication.

Major Issues:

No major issues found.

Minor Issues:

1. This document is Informational, as it doesn't define any new protocol
elements or contain any new actions for IANA. However, it does make use of
RFC 2119 language. Alvaro Retana has already commented on this usage, and I
would like to add that especially in an Informational document, the use of
RFC 2119 language should be minimal and strictly used only to ensure
interoperability (see section 6 of RFC 2119).

In particular, I don't agree with the use of the uppercase MUST in the
second paragraph of section 9, which is imposing a requirement on an
operator. This paragraph is simply a rephrasing of section 9 in
draft-ietf-idr-bgpls-segment-routing-epe. I would much prefer a simple
reference to that section in draft-ietf-idr-bgpls-segment-routing-epe
rather than a restatement of that text in this document. That will also
ensure that if the text in draft-ietf-idr-bgpls-segment-routing-epe should
change (as that draft is still in progress), it would not require an update
of this document to match.

2. I think that it would be useful to move section 7 higher in the
document, perhaps as section 1.2.

3. I also note that the comments made by Alvaro in his email of November 3
have not yet been addressed. I agree with his comments, and request that
they be addressed prior to publication.

Nits:

None.