Re: [RTG-DIR] Review of draft-ietf-idr-bgpls-segment-routing-epe

"Stefano Previdi (sprevidi)" <sprevidi@cisco.com> Thu, 20 April 2017 11:48 UTC

Return-Path: <sprevidi@cisco.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4092B1294C3; Thu, 20 Apr 2017 04:48:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.523
X-Spam-Level:
X-Spam-Status: No, score=-14.523 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RdieI02K3aVn; Thu, 20 Apr 2017 04:48:14 -0700 (PDT)
Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A0C1129B06; Thu, 20 Apr 2017 04:48:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=6324; q=dns/txt; s=iport; t=1492688894; x=1493898494; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=2ffTjLxO5PavAJohKUR/dC7o983PZzcRbAvl9raOKxo=; b=ZxAQg+PY2lw/JFpkKOXH/i3Kgr6L7qKRyM3jjoYnhuO5QiWJztDzlT/+ DDnlhrS1i5BtcGnVzD2OuYt20xWEJf7g5ApmEmut1tN6dUHUTLM+EgHrj 3W8HbULwjQw+rffNCRDe8Ntl5z63yuGzRpe6lWCDhcOkk6L3Ce0nzTLwC s=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AkAQAFn/hY/4sNJK1cGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1SBbAeDYIoVkWOVY4IPhiQCGoNfPxgBAgEBAQEBAQFrKIUVAQE?= =?us-ascii?q?BAQIBIwQNRQULAgEIGAICJgICAjAVEAIEDgWKFAiqU4FsOosgAQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBHYELhUiBXSuCboRXgwaCXwEEnTQBkwKCAIUziiKUEwEfOIE?= =?us-ascii?q?FYxUaOwGEVByBYgF1iCGBDQEBAQ?=
X-IronPort-AV: E=Sophos;i="5.37,225,1488844800"; d="scan'208";a="415068414"
Received: from alln-core-6.cisco.com ([173.36.13.139]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 20 Apr 2017 11:48:13 +0000
Received: from XCH-RTP-007.cisco.com (xch-rtp-007.cisco.com [64.101.220.147]) by alln-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id v3KBmDr7006924 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 20 Apr 2017 11:48:13 GMT
Received: from xch-rtp-010.cisco.com (64.101.220.150) by XCH-RTP-007.cisco.com (64.101.220.147) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 20 Apr 2017 07:48:12 -0400
Received: from xch-rtp-010.cisco.com ([64.101.220.150]) by XCH-RTP-010.cisco.com ([64.101.220.150]) with mapi id 15.00.1210.000; Thu, 20 Apr 2017 07:48:12 -0400
From: "Stefano Previdi (sprevidi)" <sprevidi@cisco.com>
To: Ravi Singh <ravis@juniper.net>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-idr-bgpls-segment-routing-epe@ietf.org" <draft-ietf-idr-bgpls-segment-routing-epe@ietf.org>, "idr@ietf.org" <idr@ietf.org>
Thread-Topic: Review of draft-ietf-idr-bgpls-segment-routing-epe
Thread-Index: AQHSucv9/27qJl6LRUK3n1+Z9ElHYA==
Date: Thu, 20 Apr 2017 11:48:12 +0000
Message-ID: <4AE5E64E-4D7F-4AE7-9CEF-814623828956@cisco.com>
References: <CY1PR05MB25215A10F4E4372407A31F13AB050@CY1PR05MB2521.namprd05.prod.outlook.com>
In-Reply-To: <CY1PR05MB25215A10F4E4372407A31F13AB050@CY1PR05MB2521.namprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.61.217.160]
Content-Type: text/plain; charset="utf-8"
Content-ID: <E9446841F0AA144EB68415DD5393464D@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/mnLkvLUa2Uv4CkRyu5gpz6jtxAk>
Subject: Re: [RTG-DIR] Review of draft-ietf-idr-bgpls-segment-routing-epe
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Apr 2017 11:48:16 -0000

Hi Ravi,

thanks for the review. I have integrated most of your comments and will submit a new version asap. Some more comments inline.


> On Apr 14, 2017, at 8:02 AM, Ravi Singh <ravis@juniper.net>; wrote:
> 
> Hi
> I had been designated as the RTG-DIR reviewer for this draft.
>  
> Overall the draft is clear. 
> However, it could be use some editorial revision for improved readability.
>  
> Specific comments listed below:
>  
> 1.       Document title could be less heavy on consecutive adjectives: some suggestions:
> a.       BGP-LS extensions for Segment Routing BGP Egress Peer Engineering
> b.      BGP-LS extensions for "BGP-EPE using SR"
> c.       Segment Routing BGP Egress Peer Engineering extensions for BGP-LS
> …
> 2.       Section 1:
> "   This document defines new types of segments: a Peer Node segment
>    describing the BGP session between two nodes; a Peer Adjacency
>    Segment describing the link (one or more) that is used by the BGP
>    session; the Peer Set Segment describing an arbitrary set of sessions
>    or links between the local BGP node and its peers."
> Above has an unintended meaning. This should instead have stated that this doc defines BGP-LS extensions to communicate the above listed SIDs that are defined in "draft-ietf-spring-segment-routing"
>  
> 3.       Section 3: 
> "
>    This document defines the BGP-EPE Peering Segments:
>  
>    o  Peer Node Segment (Peer-Node-SID)
>  
>    o  Peer Adjacency Segment (Peer-Adj-SID)
>  
>   o  Peer Set Segment (Peer-Set-SID)"
>  
> Same issue as listed above for section 1 above.
> Section 5 has the same issue.


indeed there’s a bit of confusion between “segment” and “SID” terminology. While the segment has been defined in draft-ietf-spring-segment-routing-central-epe, this draft defines the SID and how they are advertised in BGP-LS. I updated the text.


> 4.       Section 4.2: I'd suggest that this be broken into 2 separate sub-sections: each listing the mandatory/optional sub-TLVs for the local and remote node descriptors respectively. That will make for improved readability.
>  
> 5.       Section 4.2: please clarify in text as to Why no "BGP-LS ID" in link NLRI in the remote node descriptor.


Well, this is not related to EPE but to BGP-LS base spec where the BGP-LS identifier is locally assigned.

Therefore, a node running EPE and describing [i|e]BGP topology, doesn’t know the BGP-LS identifier of its peers.


> 6.       Section 4.3: 
> a.       values of the flags are specified only for the Per-Adj-SID. Explicit text should be listed for per-node-SID and per-set-SID.
> b.      "
>    The Peer-Node-SID MUST be present when BGP-LS is used for the use
>    case described in [I-D.ietf-spring-segment-routing-central-epe] and
>    MAY be omitted for other use cases."
> Is there really a need to state what other use-cases might do, considering that this doc is specific to BGP-LS for SR-EPE? Perhaps can be reworded. Similarly for "Peer-Adj-SID and Peer-Set-SID SubTLVs MAY" in next paragraph.


Well, we don’t want to shut the doors to other use cases that could leverage the same encodings so we just state what EPE requires but certainly, other options are available.

 
> 7.       There is some repetition of info between sections 4 & 5. eg. What local and remote node descriptors contain. Please reword these sections to avoid the repetition while still presenting the info.
>  
> 8.       Sections 5.1 & 5.2: have lots of repetitive text. Tabular presentation of the text in these sections would allow describing per-node-sid and per-adj-sid without the repetition.


Well, these sections are the core of the draft:
. section 4 describes the encoding of the TLVs/attributes
. section 5 describe how a SID is constructed.

I know it’s quite a bit of information but since w’re supposed to be exhaustive in the way encoding is done, I believe these details are wroth to be mentioned.


> 9.       Section 9: typo in language in first sentence.
>  
> 10.   Section 10: please explicitly call out any additional (beyond rfc7752) security considerations or include text stating that none exist.
>  
> 11.   Typos
> a.        Section 3:
>                                        i.            "an BGP-EPE" -> "a BGP-EPE"
> b.      Section 4:
>                                        i.            "Link-type" NLRI -> "link-state" NLRI?


RFC7752 section 3.2.  defines the “Link NLRI” type which is one possible type for the Link-State NLRI.

s.



>  
> Regards
> Ravi