[RTG-DIR] RtgDir Last Call Review: draft-ietf-idr-bgp-ls-flex-algo-09

Donald Eastlake <d3e3e3@gmail.com> Wed, 17 August 2022 19:10 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6CB9EC1524B8; Wed, 17 Aug 2022 12:10:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.853
X-Spam-Level:
X-Spam-Status: No, score=-1.853 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MCQ_UudQDXVd; Wed, 17 Aug 2022 12:10:11 -0700 (PDT)
Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6A7B3C1524B1; Wed, 17 Aug 2022 12:10:11 -0700 (PDT)
Received: by mail-lf1-x12d.google.com with SMTP id u9so869672lfg.11; Wed, 17 Aug 2022 12:10:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc; bh=VqKJVp/pE9lSArUyqxjFhvhsxbhVZQoWP+HxhmDZSyg=; b=GaeGgKWiUudfnIqoSsKmVFIRhWUxWIi+qEAAYbXPh3DSeArebaAgTuCZvoDegufMLR x85uVbm7eKa5F12+NnwgkqDvzpdBEOlf+wM7uBg68rO7h/UG3GVLYZnLiBtrH7FzT0ct /4hn67ZskTgq3guUJRnrIN9dDxH5V0uJgvO+/iAkBU7l9OGNikHhWV1pcFNp4qfji+zm /P9qHcVJW2mYFHAL5ecDLGw9lOF3IiYdQaCxKnGCtMuy+nuh5lCIYiOC0qHk2zR/RGJ6 q0iGhoM0yIFflNoyr/x1lFzNB2vDrIHDFuSisnkKBD+b9h9THV88UtV+Kvq4DJT7yLWP 0hlg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc; bh=VqKJVp/pE9lSArUyqxjFhvhsxbhVZQoWP+HxhmDZSyg=; b=hdgwMll3U+dosMdn/apmRDLKxvkN/lSGTicv2tD7V6k5mF1DiVopFJYWvszKN3VviU EFT63LwbDqPC3PqmN9GJxPr0q5jiRo2mkPpSc7R7gWoULtjntnxzh3bx6qSrhha6kRSy WHiNyXulQPf3XQwv7xLIOGa+fvSmtMuwTpzOOO7IIHS3Nc4TXntD9OkjW4IQM46XXW1B zdSsI+SbobGkParJdiURyr5MjCThlDQsDyAZt5P9rsyE3tAnjrQiGPuoEbtUTEgcGEiI 9ecDNSMgkSkdrNaTAuwMGjBb1AB6YWun0iX2sm3LbFzhQ5YJ5q9N/7i+ZCwSSOHm6XXt /H2w==
X-Gm-Message-State: ACgBeo3lKFBT0R2XVOdKhyxcvYyOaxllFsoOAluw+bQi8jmjckrlG3oF seTSlhAaA9ahcL5L1ugHLa6kDuIdnMURLw9tOINYXCbB0vI=
X-Google-Smtp-Source: AA6agR5xPqqk+QTMBvsrWyy5TDVDWcQvNVoDVdMC/bA3lyKQtoEQuycRsDNd2zenvj8XRpCMXNl5Psrkv73NQ20maOc=
X-Received: by 2002:a05:6512:3d1e:b0:48b:3f76:eff with SMTP id d30-20020a0565123d1e00b0048b3f760effmr9826081lfv.312.1660763408707; Wed, 17 Aug 2022 12:10:08 -0700 (PDT)
MIME-Version: 1.0
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 17 Aug 2022 15:09:57 -0400
Message-ID: <CAF4+nEGk0EDcNEQJ3p4YeZG9QCu91na18GJ2G96cKv=fhcto3A@mail.gmail.com>
To: "<rtg-ads@ietf.org> (rtg-ads@ietf.org)" <rtg-ads@ietf.org>
Cc: rtg-dir@ietf.org, draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org, "idr@ietf. org" <idr@ietf.org>, Last Call <last-call@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000008363305e6749dd5"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/qkXjVjjZJkAHzLCf17Ti4t4N5H8>
Subject: [RTG-DIR] RtgDir Last Call Review: draft-ietf-idr-bgp-ls-flex-algo-09
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Aug 2022 19:10:15 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft.
The Routing Directorate seeks to review all routing or routing-related
drafts as they pass through IETF last call and IESG review, and sometimes
on special request. The purpose of the review is to provide assistance to
the Routing ADs. For more information about the Routing Directorate, please
see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it
would be helpful if you could consider them along with any other IETF Last
Call comments that you receive, and strive to resolve them through
discussion or by updating the draft.

Document: draft-ietf-idr-bgp-ls-flex-algo-09
Reviewer: Donald E. Eastlake III
Review Date: 2022-08-16
IETF LC End Date: 2022-08-17
Intended Status: Proposed Standard

*Summary:*

This document is basically ready for publication but has nits that should
be considered prior to publication.

*Comments:*

This is a straightforward and relatively easy to read document. The
inclusion of the Flexible Algorithm Unknown sub-TLV is an interesting and
useful detail. I found a number of nits.

*Major Issues:*

No major issues found.

*Minor Issues:*

No minor issues found.

*Nits:*

In Flexible Algorithm D/definition, the capitalization of "definition"
should be consistent. I suggest it be capitalized.

In abstract, suggest "propagated (viz. OSPF and IS-IS flooding) through the
network" -> "propagated through the network by OSPF and IS-IS flooding"

Section 1, top of page 3: "Flexible Algorithm is called so as" -> "Flexible
Algorithm is so called because"

Maybe it's just me but "leverage" seems to be an overly complicated word
with a faint whiff of marketing about it. Suggest, in Section 1,
"leverated" -> "used", "leveraging" -> "using"

Section 2: Expand SRLG on first use.

Reference to draft-ietf-spring-segment-routing-policy should be to RFC 9256.

Global: "e.g. " -> "e.g.," (replace space after "e.g." with a comma) In
some cases it might read better to replace "e.g. " with "for example,"

Global: "ISIS" -> "IS-IS"

Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 2386 Panoramic Circle, Apopka, FL 32703 USA
 d3e3e3@gmail.com