[RTG-DIR] RtgDir review: draft-ietf-6man-spring-srv6-oam-09.txt

Stig Venaas <stig@venaas.com> Fri, 26 March 2021 19:27 UTC

Return-Path: <stig@venaas.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 53A4B3A0B92 for <rtg-dir@ietfa.amsl.com>; Fri, 26 Mar 2021 12:27:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=venaas-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id easaO923k7c6 for <rtg-dir@ietfa.amsl.com>; Fri, 26 Mar 2021 12:27:39 -0700 (PDT)
Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 674E73A0BA0 for <rtg-dir@ietf.org>; Fri, 26 Mar 2021 12:27:37 -0700 (PDT)
Received: by mail-io1-xd31.google.com with SMTP id z3so6505799ioc.8 for <rtg-dir@ietf.org>; Fri, 26 Mar 2021 12:27:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=venaas-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to:cc; bh=hxC+PmAGI0G56uJAhpLLWL3RuHWU0Z6Ypbck0Q579v8=; b=jURtNg5FM4EZ2vm6UB2AgvHd58vufxaEFENJ+ztbaBxnGQjUIYpV+33XXyJ2ea2ziz AgW/sJOCcE/7DP3SRH7poudbMOYYYnuIb2RwspzfOjxIvrCxKYsFlPdaHyndcSPBwypu 1MmyXwSMIe84FqWnq7FhN0yLbL364xdkNBDqhif4I4LvjHJY6yjzn0m+UhE6jVCF31l5 NrCzSoG6qnAjvTE4vvqkswxYeehIJ7blm7BKiYdDZpK2X0X9mbdp1MD5mO6vQVET0IdY n4w9VAs/itYzfknTyUtAg63IP/A3Szr6GU6bqVLUt66gCMljwu/bvt80CFuEt5dyq/F6 tD1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=hxC+PmAGI0G56uJAhpLLWL3RuHWU0Z6Ypbck0Q579v8=; b=CHnl5F54yNtmDQV29aJWmiG2Wx9+f6fUBCqy78R+CfunjOAzBu1lIo3KZVQ6DPS7XE kDr4W4INeDcgZ5bl3uYuSU8VPG4NZ3DFQhvcNNtPZQUo9j0cPcgSbp0HZXiZIghaEIcn n5nd7kdlqjUwfe+RnUBcJJG31lK3k5C1xh/0y5imIRIHk/UcHDnCERQH/hqJelpi9UJR VYjmklpWGzjaBj51uNLNrEgObC+hSbvdI6lH/AQt0Gu4lOPAgGWPZUXRXdJR2/1FbK6J 98ld3I1qEz7IdI0yG6YmszVf6ff7jWx5GGObwOtjaRiAhT48VkFEdAP2nEB/9Qo8u2Gl X7Uw==
X-Gm-Message-State: AOAM532/LivsRPlrrV5Wn+bBBVaCqN19CxkyiDq7J4YsCM6F7nwGSAvi 2wm/CDsbWAzA9WaMmmIObg8/9ElvVh9kRUPU2/UgcQ==
X-Google-Smtp-Source: ABdhPJyHbJD3W+3I4315Hu9Yeu9xJHEakuudx6Edp78uVhK3hHQ505ELQDEXoJP6+99m1O/c8Usr0YlBGAuCLmjcUqQ=
X-Received: by 2002:a6b:500c:: with SMTP id e12mr10921395iob.190.1616786855433; Fri, 26 Mar 2021 12:27:35 -0700 (PDT)
MIME-Version: 1.0
From: Stig Venaas <stig@venaas.com>
Date: Fri, 26 Mar 2021 12:27:24 -0700
Message-ID: <CAHANBtLSsXN4q1XunUHA3at93kWEi-z0_ny3BWQqrh9CmwRXLA@mail.gmail.com>
To: "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>
Cc: rtg-dir@ietf.org, 6man WG <ipv6@ietf.org>, draft-ietf-6man-spring-srv6-oam.all@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/r1z5jAkfoknPl1TtEK9HSBp_O-c>
Subject: [RTG-DIR] RtgDir review: draft-ietf-6man-spring-srv6-oam-09.txt
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Mar 2021 19:27:49 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this
draft. The Routing Directorate seeks to review all routing or
routing-related drafts as they pass through IETF last call and IESG
review, and sometimes on special request. The purpose of the review is
to provide assistance to the Routing ADs. For more information about
the Routing Directorate, please see
http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs,
it would be helpful if you could consider them along with any other
IETF Last Call comments that you receive, and strive to resolve them
through discussion or by updating the draft.

Document: draft-ietf-6man-spring-srv6-oam-09.txt
Reviewer: Stig Venaas
Review Date: 2021-03-26
IETF LC End Date: 2021-03-22
Intended Status: Proposed Standard

Summary:

I have some minor concerns about this document that I think should be
resolved before publication.

Comments:

The document is quite good and easy to read. There are a couple of
minor language issues that I'm sure the RFC editor will take care of.
My only concern is the security considerations.

Major Issues:

No major issues found.

Minor Issues:

The Security considerations need more details.

Aren't there any concerns about attackers sending packets with the
O-flag set? Could packets be sent to the OAM process at a high rate?
As mentioned, packet punting should be rate limited. Could an attacker
cause legitimate probes to be dropped by sending too many illegitimate
probes?

Rate-limiting is a SHOULD. There should be some discussion on the
importance of rate-limiting. Why is it important, and what may be the
reasons for not rate-limiting? Since it isn't a MUST, it appears there
may be cases where it makes sense not to rate-limit.

Nits:
A few minor language issues, but these are very minor and will be
addressed by the RFC editor.
Some references are not up to date.

Regards,
Stig