Re: [RTG-DIR] RtgDir Last Call Review: draft-ietf-idr-bgp-ls-flex-algo-09
Ketan Talaulikar <ketant.ietf@gmail.com> Fri, 19 August 2022 01:45 UTC
Return-Path: <ketant.ietf@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F53DC14CE3D; Thu, 18 Aug 2022 18:45:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.105
X-Spam-Level:
X-Spam-Status: No, score=-1.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EbM34fR54JYk; Thu, 18 Aug 2022 18:45:47 -0700 (PDT)
Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 95AFDC14F72F; Thu, 18 Aug 2022 18:45:47 -0700 (PDT)
Received: by mail-ej1-x62b.google.com with SMTP id i14so6319480ejg.6; Thu, 18 Aug 2022 18:45:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=69Gg3OznkgWNKngT82BmqGvajOxUEUJPYdO8O3gqJZ0=; b=LP86AGqJheFnGunIbD/pw1oLr785U91XRfxJsa3Fl40TPR3TREafYxJHHmzoSfAT6E D38hgYb9sd1rCbWOo/sdosH5RT6aWBQYw4mVRO7lNyW6Vx2yauHv05QRW6/JdUuvJs/i 7jLOtojbm/vFDegXx6SPeTBfdOFBZIiFEgHWPvAklGJsGbNnLR+Ep5oDgyAGFkV2HE2L TXGHy0pgpJv2UQQKPXLPldL+gqkjI65t1+v3vFLVh2t/P9tFwEyJc9lrsL1YHMKliozl ixJDWuKflliR9JqNHp1/aRZG4Sh4h7a7UEzLBY7QMtxm7ng/eRryodGIFAOXIYY6ydmG 2GEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=69Gg3OznkgWNKngT82BmqGvajOxUEUJPYdO8O3gqJZ0=; b=p27i+s24UazdIwcTvg2aeZqSHL1ejeqx38GhCun6TlNGfw0foapRmfoI9eDfUzNvlY XTIu/7wD8HCd8sefTIdIHT4g4y+haG9EKi0rPxI2ugiLauVYrxWniWiuRbl7KPe7oJf7 oc/4/tAOpj0fIyLF9q2MHVT9T4whrZG0Ntx4446z/cJ8k+hbP9YKiEr/2bJ7g5gFDZlu ApK/LUX6B2C8C0KSTNUE9Qygef6CpQfqaMW0PqbiiWcu4D02ui6WoF+GS0W6xD5wJEkg hxrH2gkbAynbRfToDS8sT9Tr+9xLATYzERdmr3cK0GvbNjT04BAnem8ic5MfZk42lKH4 8p2A==
X-Gm-Message-State: ACgBeo3G8367cme4h/0Pgd8Sn/pE9jpfy89Qg1RabjvzR3xU7uL1o4JS m+cNXG0g+gjnkWuLO0lisMMkeSI+b60tLLJ3bwNSNZiAN+g=
X-Google-Smtp-Source: AA6agR5e/0b13insw4b5XYXu7V2rMuJBFrsnHCHU/ghVXlOmzKUxC3qFlpgmZIYJ/pTvT5zeEUcwHBeGDQCwQ+F6aso=
X-Received: by 2002:a17:907:7355:b0:738:5087:9a64 with SMTP id dq21-20020a170907735500b0073850879a64mr3427562ejc.295.1660873545892; Thu, 18 Aug 2022 18:45:45 -0700 (PDT)
MIME-Version: 1.0
References: <CAF4+nEGk0EDcNEQJ3p4YeZG9QCu91na18GJ2G96cKv=fhcto3A@mail.gmail.com> <CAH6gdPxNwBAuNMzC7+x4c_CsN67iEHTCDmK70vwQZGdmpSiABQ@mail.gmail.com>
In-Reply-To: <CAH6gdPxNwBAuNMzC7+x4c_CsN67iEHTCDmK70vwQZGdmpSiABQ@mail.gmail.com>
From: Ketan Talaulikar <ketant.ietf@gmail.com>
Date: Fri, 19 Aug 2022 07:15:34 +0530
Message-ID: <CAH6gdPy9zy0G9J6xiGKi3qP=Mbi7Jq6M50ANFsnotO7BbqqCew@mail.gmail.com>
To: Donald Eastlake <d3e3e3@gmail.com>
Cc: "<rtg-ads@ietf.org> (rtg-ads@ietf.org)" <rtg-ads@ietf.org>, rtg-dir@ietf.org, draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org, "idr@ietf. org" <idr@ietf.org>, Last Call <last-call@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000b846c205e68e41d8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/rf0G7u_e0SQ76HOHF_781TExYZ0>
Subject: Re: [RTG-DIR] RtgDir Last Call Review: draft-ietf-idr-bgp-ls-flex-algo-09
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Aug 2022 01:45:48 -0000
Hi Donald, The recent update below includes changes to address your comments. https://datatracker.ietf.org/doc/html/draft-ietf-idr-bgp-ls-flex-algo-10 Thanks, Ketan On Thu, Aug 18, 2022 at 11:02 AM Ketan Talaulikar <ketant.ietf@gmail.com> wrote: > Hi Donald, > > Thanks for your review and agree with all your suggested edits for the > nits. > > These changes will reflect in the upcoming update of the draft. > > Thanks, > Ketan > > > On Thu, Aug 18, 2022 at 12:40 AM Donald Eastlake <d3e3e3@gmail.com> wrote: > >> Hello, >> >> I have been selected as the Routing Directorate reviewer for this draft. >> The Routing Directorate seeks to review all routing or routing-related >> drafts as they pass through IETF last call and IESG review, and sometimes >> on special request. The purpose of the review is to provide assistance to >> the Routing ADs. For more information about the Routing Directorate, please >> see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir >> >> Although these comments are primarily for the use of the Routing ADs, it >> would be helpful if you could consider them along with any other IETF Last >> Call comments that you receive, and strive to resolve them through >> discussion or by updating the draft. >> >> Document: draft-ietf-idr-bgp-ls-flex-algo-09 >> Reviewer: Donald E. Eastlake III >> Review Date: 2022-08-16 >> IETF LC End Date: 2022-08-17 >> Intended Status: Proposed Standard >> >> *Summary:* >> >> This document is basically ready for publication but has nits that should >> be considered prior to publication. >> >> *Comments:* >> >> This is a straightforward and relatively easy to read document. The >> inclusion of the Flexible Algorithm Unknown sub-TLV is an interesting and >> useful detail. I found a number of nits. >> >> *Major Issues:* >> >> No major issues found. >> >> *Minor Issues:* >> >> No minor issues found. >> >> *Nits:* >> >> In Flexible Algorithm D/definition, the capitalization of "definition" >> should be consistent. I suggest it be capitalized. >> >> In abstract, suggest "propagated (viz. OSPF and IS-IS flooding) through >> the network" -> "propagated through the network by OSPF and IS-IS >> flooding" >> >> Section 1, top of page 3: "Flexible Algorithm is called so as" -> >> "Flexible Algorithm is so called because" >> >> Maybe it's just me but "leverage" seems to be an overly complicated word >> with a faint whiff of marketing about it. Suggest, in Section 1, >> "leverated" -> "used", "leveraging" -> "using" >> >> Section 2: Expand SRLG on first use. >> >> Reference to draft-ietf-spring-segment-routing-policy should be to RFC >> 9256. >> >> Global: "e.g. " -> "e.g.," (replace space after "e.g." with a comma) In >> some cases it might read better to replace "e.g. " with "for example," >> >> Global: "ISIS" -> "IS-IS" >> >> Donald >> =============================== >> Donald E. Eastlake 3rd +1-508-333-2270 (cell) >> 2386 Panoramic Circle, Apopka, FL 32703 USA >> d3e3e3@gmail.com >> >
- [RTG-DIR] RtgDir Last Call Review: draft-ietf-idr… Donald Eastlake
- Re: [RTG-DIR] RtgDir Last Call Review: draft-ietf… Ketan Talaulikar
- Re: [RTG-DIR] RtgDir Last Call Review: draft-ietf… Ketan Talaulikar