[RTG-DIR] Rtgdir last call review of draft-ietf-ospf-xaf-te-02
Ben Niven-Jenkins <ben@niven-jenkins.co.uk> Thu, 03 May 2018 17:19 UTC
Return-Path: <ben@niven-jenkins.co.uk>
X-Original-To: rtg-dir@ietf.org
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 9D81212EA76; Thu, 3 May 2018 10:19:54 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Ben Niven-Jenkins <ben@niven-jenkins.co.uk>
To: rtg-dir@ietf.org
Cc: lsr@ietf.org, draft-ietf-ospf-xaf-te.all@ietf.org, rtg-ads@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.79.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <152536799456.4442.2733959917314042989@ietfa.amsl.com>
Date: Thu, 03 May 2018 10:19:54 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/rwCn96NwFWHOK2Q2UUXKCY0xgi4>
Subject: [RTG-DIR] Rtgdir last call review of draft-ietf-ospf-xaf-te-02
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 May 2018 17:19:55 -0000
Reviewer: Ben Niven-Jenkins Review result: Has Nits Hello, I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft. Document: draft-ietf-ospf-xaf-te-02.txt Reviewer: Ben Niven-Jenkins Review Date: 3 May 2018 Intended Status: Standards Track Summary: This document is basically ready for publication, but has nits that should be considered prior to publication. Comments: The document is readable and succinctly addresses the use case outlined. Minor issues: Section 3, paragraph 4 states: If the Node Attribute TLV carries both the Node IPv4 Local Address sub-TLV and the Node IPv6 Local Address sub-TLV, then the X-AF component must be considered for the consolidated calculation of MPLS TE LSPs. Is the lowercase must supposed to be an uppercase MUST? Nits: Section 4, paragraph 1 states: Way of using these TLVs as specified in this document is fully backward compatible with previous standard documents. This does not read quite right to me. Maybe you should consider rewording it to something like the text I suggest below. Also when you say “standard documents” do you mean RFCs? Is it worth citing an example for completeness? The way these TLVs are used, as specified in this document, is fully backward compatible with earlier RFCs. Regards Ben
- [RTG-DIR] Rtgdir last call review of draft-ietf-o… Ben Niven-Jenkins
- Re: [RTG-DIR] Rtgdir last call review of draft-ie… Alvaro Retana