[RTG-DIR] RtgDir review: draft-ietf-idr-bgp-ls-segment-routing-msd-05.txt

Mach Chen <mach.chen@huawei.com> Sun, 15 September 2019 12:13 UTC

Return-Path: <mach.chen@huawei.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E6C70120090; Sun, 15 Sep 2019 05:13:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.8
X-Spam-Level:
X-Spam-Status: No, score=0.8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, GB_SUMOF=5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CnOJi5BVj9Vr; Sun, 15 Sep 2019 05:13:26 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C115312000F; Sun, 15 Sep 2019 05:13:25 -0700 (PDT)
Received: from lhreml705-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id B2508E9242D77A682FAA; Sun, 15 Sep 2019 13:13:23 +0100 (IST)
Received: from lhreml725-chm.china.huawei.com (10.201.108.76) by lhreml705-cah.china.huawei.com (10.201.108.46) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 15 Sep 2019 13:13:23 +0100
Received: from lhreml725-chm.china.huawei.com (10.201.108.76) by lhreml725-chm.china.huawei.com (10.201.108.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 15 Sep 2019 13:13:23 +0100
Received: from DGGEML403-HUB.china.huawei.com (10.3.17.33) by lhreml725-chm.china.huawei.com (10.201.108.76) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.1.1713.5 via Frontend Transport; Sun, 15 Sep 2019 13:13:23 +0100
Received: from DGGEML510-MBX.china.huawei.com ([169.254.2.221]) by DGGEML403-HUB.china.huawei.com ([fe80::74d9:c659:fbec:21fa%31]) with mapi id 14.03.0439.000; Sun, 15 Sep 2019 20:13:20 +0800
From: Mach Chen <mach.chen@huawei.com>
To: Routing ADs <rtg-ads@tools.ietf.org>
CC: Routing Directorate <rtg-dir@ietf.org>, "idr@ietf.org" <idr@ietf.org>, "draft-ietf-idr-bgp-ls-segment-routing-msd@ietf.org" <draft-ietf-idr-bgp-ls-segment-routing-msd@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-idr-bgp-ls-segment-routing-msd-05.txt
Thread-Index: AdVjAto+gGFNjTjzT2S3OHztFyKdOg==
Date: Sun, 15 Sep 2019 12:13:20 +0000
Message-ID: <F73A3CB31E8BE34FA1BBE3C8F0CB2AE292C6A807@dggeml510-mbx.china.huawei.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.45.213.58]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/vFlP0cWthq10w5cPYikMyHu-eZM>
Subject: [RTG-DIR] RtgDir review: draft-ietf-idr-bgp-ls-segment-routing-msd-05.txt
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Sep 2019 12:13:28 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-idr-bgp-ls-segment-routing-msd-05.txt
Reviewer: Mach Chen
Review Date: 10 September 2019 
Intended Status: Standards Track

Summary: 
I have some minor concerns about this document that I think should be resolved before publication.


Comments:

Generally, I found the draft quite readable, with a clear explanation of the problem statements and solutions. However, I have one minor comment and a nit.

Major Issues:

No major issues found.


Minor Issues:

This draft is an extension to BGP-LS (RFC 7752) that is under a re-spin, I have a question whether this draft should reference to RFC 7752 or the new bis document.


Nits:
1.1.1.  Terminology

Part of the last bullet should be separated into a dedicated paragraph, it looks like an copy and pastes nit. 

"The number of labels imposed is then the sum of the number of labels that are
      replaced and the number of labels that are pushed.  See [RFC3031]"

Best regards,
Mach