[RTG-DIR]Re: Rtgdir last call review of draft-ietf-mpls-sr-epe-oam-15

Shraddha Hegde <shraddha@juniper.net> Thu, 13 June 2024 09:24 UTC

Return-Path: <shraddha@juniper.net>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F276EC151064; Thu, 13 Jun 2024 02:24:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.106
X-Spam-Level:
X-Spam-Status: No, score=-7.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b="QCnCCRDK"; dkim=neutral reason="invalid (public key: not available)" header.d=juniper.net header.b="dtwagHwA"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fUMMzpctEInr; Thu, 13 Jun 2024 02:24:36 -0700 (PDT)
Received: from mx0a-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 96C97C14F70C; Thu, 13 Jun 2024 02:24:36 -0700 (PDT)
Received: from pps.filterd (m0108159.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45CMNKNn010435; Thu, 13 Jun 2024 02:24:36 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=PPS1017; bh=qt v/rsYIK0vwIGvye3xZr0NrEtt449N53pgOeQYlHvw=; b=QCnCCRDKRqHmYLk3n2 +ty2iTpM/axDkfLogBTFVtwSxclQyLu3DJm61cuHh/Cqdp51v+MV0gg4+oy68su3 9EtBELyLEJJU+c1JwjY7CRlM992lF+0UO87oY1eqdeH5XY1inGZMI5PTF8iPxhkT 8jlYaQVj4+nz9xwKILUeUzI2EPXXW7H10cTbqoOy1gOosaTB0dlT19Vvj52LDy56 60NK5OSYuSYulg9NrjSGWzAFFI6NGDqse9QI0ONsENd8igfah8N9TpQ9oEu/nz+U 6sTVgNoVO1r0p/yhtrGftwwj8YSN6YYD3qiNgr9KJYicLIkipcqN/qvLeQyowikk Vz1A==
Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by mx0a-00273201.pphosted.com (PPS) with ESMTPS id 3ymn8wt80y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jun 2024 02:24:36 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NmwBezOUSDaCDqH89ku8iCyrIqfU2glDb7aqf02EForNtcprEgNG1zrY2S1f3/0TfzWWa5Az92pz1nGOj2/ZWsIpT36RDdYngSC1PUnD2lGl4WnFEOEBCzUm80HWMKnF0TQqBZQj1CBrEXfNhUx0Kgrxx00MhEoSVboxupjjQup665sY6mob8mcxgJ1H5iBJuWl48In9m2XZ654nq86qp/jEi/cb+nZIcoeHiiRvelIzOEadP4Fo4jJt0B9FKK9QTgyg0cUCRhplX9552xksV16S8AGQ2vsrhxdxUYgEX13IJztzsIX1ylkPk80W1oV1aZ1Pj2LYCzJAE4PwRkzE0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qtv/rsYIK0vwIGvye3xZr0NrEtt449N53pgOeQYlHvw=; b=XgpWRPH1UMh975CTlL2ESH4qBtPP1G2r2lSkNyjdnBDxYxyOqfiAtSrI4GlAyxWPjpk8USeQ759y73+yONBMKgyUOO62OAPnjD/hpdhe5Yu12dSaFekreymsozDv83YNF2fXWQVzLLnPyyefVlZnJgCIky2YuIaRMw+ew6opj7XXWoRohaQUM8noCDpT9+LRSYn3S7T0BXC16sNwhI/UUCmxjXMUMj+V58vhteCKmXnKK1nyFiZE5Qj638ZLH1PTBsJW8MUI7J8Op9Ga8H5Pq9mlvZJau8k7h8KunjIg+MlfwPZmIoWoXMj4ubnCGFqcQ+sF2eUjgJOsUjRYo77rNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qtv/rsYIK0vwIGvye3xZr0NrEtt449N53pgOeQYlHvw=; b=dtwagHwA52DTk6SyIzGG+xbBSWoye3S8EUblnjJRu1QnZlymlQ4CikLu5pEmbE4/xBVkDqx5vf4OkO44nEFbB8x+adrU8/JZ2U8kA6EweQXz0ui/W/5kommk5hgFM+6R5wOKlw9HXq/8v9ShTpmxxNvwR6Z8s/+BkDIbF5coWsM=
Received: from CO1PR05MB8314.namprd05.prod.outlook.com (2603:10b6:303:fd::13) by SJ0PR05MB7248.namprd05.prod.outlook.com (2603:10b6:a03:28c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.24; Thu, 13 Jun 2024 09:24:19 +0000
Received: from CO1PR05MB8314.namprd05.prod.outlook.com ([fe80::9a48:3f33:3abc:59b0]) by CO1PR05MB8314.namprd05.prod.outlook.com ([fe80::9a48:3f33:3abc:59b0%4]) with mapi id 15.20.7677.024; Thu, 13 Jun 2024 09:24:19 +0000
From: Shraddha Hegde <shraddha@juniper.net>
To: Joel Halpern <jmh@joelhalpern.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>
Thread-Topic: Rtgdir last call review of draft-ietf-mpls-sr-epe-oam-15
Thread-Index: AQHaoKDsHzEIUCa4bkugVFLMX2H9CbGNCAiAgAJMtICANlCD8A==
Date: Thu, 13 Jun 2024 09:24:19 +0000
Message-ID: <CO1PR05MB83144A6EAB0A463D622E372ED5C12@CO1PR05MB8314.namprd05.prod.outlook.com>
References: <171510159186.29535.18251469067423385129@ietfa.amsl.com> <CO1PR05MB83147CDA79376C32E27EC80CD5E52@CO1PR05MB8314.namprd05.prod.outlook.com> <d10a5274-dc8d-47c3-88e5-bd0b33bf9af2@joelhalpern.com>
In-Reply-To: <d10a5274-dc8d-47c3-88e5-bd0b33bf9af2@joelhalpern.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ActionId=8aa59435-07e7-40cb-8297-9458944f1c22;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Name=0633b888-ae0d-4341-a75f-06e04137d755;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2024-06-13T09:22:46Z;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CO1PR05MB8314:EE_|SJ0PR05MB7248:EE_
x-ms-office365-filtering-correlation-id: 0e980f2b-f9d1-4a98-8977-08dc8b8a9aa0
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230034|366010|376008|1800799018|38070700012;
x-microsoft-antispam-message-info: zV1QYAvaa9CCkx0ealEOE/EuWNlb0aoN26V5q6iJkB+IbPCwzMHSpW7VKEeO08vRsXFxrLG6CdfndGFwcUBYr1ldiDlrbSSynUncxfZudp927KJG4mdnA615RNgj0mKwbwXSKod/zH9I9pwAvkNpaBELbHL61A4+IZvRNdQt8qXSQZpPV+mPYelTemZNIGOs81OkJIhHNiLyqhviVRzaFImChcn+6A0pIzu2TabmYMPIFBc5dC97eH4Q9JSP15fDuFi5ULWl0DxMdYT3MSzEF0p2OtF7mTMYsYDdc4yUPV/Q+K1eW3TX6HYiV7qoJ8tv6snDF6YSSZpnwA//gJi4i1lci0/m/9oDREpVGcmLZ6VcuuyOFBgSZC6fNtMqOg++Lk8pi2CdVDv7526GyVBYwWZIo2JOnVgVxf9T0Kpz9Jt2CxCGAORGyyR/bfNvACNpFVGq/nz+i27A2p+1fKgOnMYo1G0bs9fnnB3E60qQx9NGuKQkasG2YceBjMDpj4FEheEZhS5aO7fB4SeQpoum8fOnfMypkQ97PoLxGLN010bfeHIzLY/3256/d195d/cZ65nW05iu1stVTw93VkSK3x21VdVC7Vkz3wfiEw6a3hlqf0Miy2vDgvqXtfGK6yRj9XeN9tb+EVlB7IyAXUIBwWf2ykE6MKZm1uRuZLQL1sQVGz4yCZbf6dYN2B36U+Zn180JwL+qNO4JO+Bh3zEZd7619S66Gtt4t2/PVUeXUE6U27OQgQDdMfz7Yexa2yWpI+fSIhZffw7qpK6s9J04ZpFOAW9cvSkDcS8rJh6bP+hWhxgd2euHCXM6o93ihZfbjDfvh/KT6845z1Juke9OJSWoRL7oo4oCgvznL3PCHjxE529+h1kYQOEd+Vjl6iV2cZqW9C6Yp5ep2xeKo6zMV32QIYzD+qqRJOfOXzDRwnfY3bK5Sgkh7HE6rXEft2eCSFbMfwtfsF/7HiKEqyLuQEpY4OvuJDRJddLIFUAdcX4ivymQnT9rRj4BbV18clqzov53I8Pi1w7doUF4v6MD4PuZlv97UPrpENuw79R3Fi5UHQbNUmR71+ooYipLVXbEJ9RZYfoN3oHGAYD3/XGZMUBYaNYRabUkPXFKFSNWOY9VP4J4Lhj0CoQHRQmfTLe97qOKfzRBSGLWKxPXqAg5xXHkAfN8dmdUrUvLDZeqePowuhneueSmWfqUWTc3+P6HwcDIG8FdpRFQkz+dO/B0P5faQQ97b6Vc/+r7xSAueLGF5x3vxal6vVg4dAhVwmNKDdLFh289KZqlUG8cWz5qWKnMhM4y0IeIe+UQgSL0nIJJAUVC1s+RohR5s0Xp0bcB
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR05MB8314.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230034)(366010)(376008)(1800799018)(38070700012);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: btSpt6yfx3W4yWHKbdbCwo3JOthFEke+Xjor7kBed6r3M5ySI390Ia0voeGTYVJC1h1YXR/vwx4QeSGHz4QSi+cDxKQktHWriEvS+6sHMjlM6+AIwOzn/ZjNe77OChV/y4xrpCQSi/nIHDyEcoL5TeoKAFUXCHYAkacKGjMXpBhy5S4j5FRfrpgct5C1GEoyacmlVvt3fCAc8vDur0AXE0H7dau/k6076jHNrieSPX/s5j3B8jbuyaX2jx5Yh7XC9zL7knwhDNmZwkVAStlAm/RymIhR7EVchlALt5vA+LWwVKGFCT6/S6xdU+CPlAOkf5ghJsFn20zvsgPaZxQSt4XzLmAZZq0PB5ToQqCMom51tpcAUY11Vwysn98YtrA/heTqG/3y/jHBHN46+hcsHFVotjPfG6MRuR0nFMCMH8S6LFTyrUsAwznmYYm4b/dakdOXX2+kqVUclDDOLb3RNgPfcCluYs2jQrv3irgacY8VxGaXCJuQVPUorgRN/nkgo3J38ykA4psMTnqiPEyvhk4TW5EvU33yq0HK+Oe0GtseeFi7EXQpj8bR5ZhfLCK5ySWNHBiM/tZdmHglZyN4xyBVvn8ZQ+KcYKb+FUI7PahM5pKVYHCBOmgFoMb+mBGToYT/ynm6+HvMkBVoPyeX1/3bW0qj8T1TwLkLcKyu0IeIGXxKlK4nClj+QKn37hOaAV3g3QqnZnOO7x1F4kRpydFhAB8ucKMC4irUpMcH2pUoJ6ub49aTAzpUSPDZRgYXJ5mvhcyQBbc1ejz+l0m4PZG0/Orq8jqdIZyROjHIjk2nkuYqO94sXEqAKUR1re94cU3mlcKg6gapYHlJvuNS5bNJdJrAi0vIAkqRVCV0NiuCAhkDhnmmCuxsLpZZTbEHqHV8uUyIU6MnBWDNogRj4VJhnCfyxWIQkKS0Ep9oMi82MCqMqBX7IxEd5f6c1IvhzAAS756shnEsREJagUMHyAFkvjrudI0mjWT0o3t/g6a1TO5X5DwaVC1Q8jxy06lXbtMSTR9RKWDB4IN46aehEypuehD1SaFsNYzMyo0NzV2nfSAhZKrsi97TKjmv0IgZPmtRcm1ycnlje06mK253bMfj8hIFKCn14sBMT5KUmWOhXMyXj0+5qnUvp4m5+66e+g4oXR9e8P0WYEG49Z05IwnGbMyNYzwNZNMQ6RNlnY2O2QM/rK5bBqTWfhLjlPR+DY8SOhcfeqg3jNUrzeyT+H86FoQ6vnKtIJmyBilwxgGh6/ZS1Qu5o6fnSM0lYuhhS7A9wJb83HDoF3jouKUlpPscPHEkCfaEjFZaQwjW61sNEe9BtpIMh/hmYT9VVRN3EahwfOzjr/cnW1IxCEuzPKaH2hHQFr6Sd/4MLlZoc4EDOzg+7ii7tk4Kx3aQUm8A6frLrPPjOidiBCUxQlQQ1VuLhacRG8YPbJ/6nthO301KWqjnv2a8qh6I8YTKVw4yA0rrEYOA63eU6A+JqGb93M+iT87fyse9J7XkmJx17GUd5rP/DwK0o7YFIyw/KCSL0f3WesJheGYEp6VNLGrfKiNxBSauKvJ01BvQ3RUqRU2sIIHwUQcuRYcq3bT8X5Lh
Content-Type: text/plain; charset="utf-7"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR05MB8314.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e980f2b-f9d1-4a98-8977-08dc8b8a9aa0
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2024 09:24:19.5420 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eGnE8S1khS9rd0LnBShUcMjG3+7aY7fyse77qSJEV49C5nqHLJMUr/8KWTFzTvxdMdgA7xtP58+oA23ZiK05CA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR05MB7248
X-Proofpoint-ORIG-GUID: LYWQ4GV1bZLD3Ds0aOZv4qd6kQb2XFND
X-Proofpoint-GUID: LYWQ4GV1bZLD3Ds0aOZv4qd6kQb2XFND
X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_01,2024-06-13_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0 clxscore=1011 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406130065
Message-ID-Hash: 44BPED6OL3D6F5EO52ZUQORGRKSVHQ4G
X-Message-ID-Hash: 44BPED6OL3D6F5EO52ZUQORGRKSVHQ4G
X-MailFrom: shraddha@juniper.net
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-rtg-dir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "draft-ietf-mpls-sr-epe-oam.all@ietf.org" <draft-ietf-mpls-sr-epe-oam.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [RTG-DIR]Re: Rtgdir last call review of draft-ietf-mpls-sr-epe-oam-15
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/vSqC7MvzV9MjvxS4LF90rltd-dU>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Owner: <mailto:rtg-dir-owner@ietf.org>
List-Post: <mailto:rtg-dir@ietf.org>
List-Subscribe: <mailto:rtg-dir-join@ietf.org>
List-Unsubscribe: <mailto:rtg-dir-leave@ietf.org>

Hi Joel,

I have updated ver -17 and added adj-type field to the peerAdjSID FEC.
Pls review ver -17.

Rgds
Shraddha


Juniper Business Use Only
-----Original Message-----
From: Joel Halpern <jmh@joelhalpern.com>
Sent: Friday, May 10, 2024 1:27 AM
To: Shraddha Hegde <shraddha@juniper.net>; rtg-dir@ietf.org
Cc: draft-ietf-mpls-sr-epe-oam.all@ietf.org; last-call@ietf.org; mpls@ietf.org
Subject: Re: Rtgdir last call review of draft-ietf-mpls-sr-epe-oam-15

[External Email. Be cautious of content]


[Resending in case this got lost in the email problems.]

Thank you Shraddha.  In line, marked <jmh></jmh>


Yours,

Joel

On 5/8/2024 4:54 AM, Shraddha Hegde wrote:
> Hi Joel,
>
> Thank you for the careful review and comments.
> Pls see inline <SH> for responses.
>
>
> Rgds
> Shraddha
>
>
> Juniper Business Use Only
> -----Original Message-----
> From: Joel Halpern via Datatracker <noreply@ietf.org>
> Sent: Tuesday, May 7, 2024 10:37 PM
> To: rtg-dir@ietf.org
> Cc: draft-ietf-mpls-sr-epe-oam.all@ietf.org; last-call@ietf.org;
> mpls@ietf.org
> Subject: Rtgdir last call review of draft-ietf-mpls-sr-epe-oam-15
>
> [External Email. Be cautious of content]
>
>
> Reviewer: Joel Halpern
> Review result: Not Ready
>
> Hello,
>
> I have been selected as the Routing Directorate reviewer for this
> draft. The Routing Directorate seeks to review all routing or
> routing-related drafts as they pass through IETF last call and IESG
> review, and sometimes on special request. The purpose of the review is
> to provide assistance to the Routing ADs.
> For more information about the Routing Directorate, please see
> https://urldefense.com/v3/__https://wiki.ietf.org/en/group/rtg/RtgDir_
> _;!!NEt6yMaO-gk!AhctNGPPaKLQ_H79A9RESTF3a29btJzh4iO8NHGpWZzqq9EuPQTv9j
> m2O_41fO-qR1mCgCzII3RUBXYp$
>
> Although these comments are primarily for the use of the Routing ADs,
> it would be helpful if you could consider them along with any other
> IETF Last Call comments that you receive, and strive to resolve them
> through discussion or by updating the draft.
>
> Document: draft-name-version
> Reviewer: your-name
> Review Date: date
> IETF LC End Date: date-if-known
> Intended Status: copy-from-I-D
>
> Summary:
> I have significant concerns about this document and recommend that the
> Routing ADs discuss these issues further with the authors.
>
> Comments:
>
> I was very pleased with the clarity and readability of the document.
> It lays out the space it is working in, and explains what it does and
> how very well.
>
> Major Issues:
> I have significant concern with the structure of the TLVs in two regards.
> First, the PeerAdj SID Sub-TLV (assigned tbd1 in section 4, defined in
> section 4.1) uses a single code point for IPv4 and IPv6 and
> differentiates by length. Other sub-TLVs for MPLS ping and traceroute
> use different code points for IPv4 and IPv6. Second, all of the
> sub-TLVs defined in section 4 have length codes. Looking at RFC 8029,
> sub-TLVs are defined with fixed lengths and do not have length codes
> embedded in them. While one can argue that this is a bad practice, it
> is the practice, and RFC 8287 follows that practice. It would seem this document should do so as well.
> <SH> The definition of PeerAdjSID was referenced from IGP Adj SID FEC
> definition from Sec 5.3 of RFC 8287. This uses sigle code point for
> IPv4/IPv6 addresses. Similar approach is Used in PeerAdjSID definition
> to keep it consistent. Let me know what you think.

<jmh>From where I sit, given that these sub-TLVs are part of the MPLS PING and Traceroute protocol, alignment with that protocol is more important than aligning with the wire encoding BGP uses. After all, the comparison process inside the router can easily convert between the two representations.  In the end whether to leave this as is or align with the rest of the MPLS traceroute and ping protocol is up to the MPLS WG chairs and the responsible AD.

If the WG already discussed this, pointers to that discussion would seem helpful to those responsible for deciding.

</jmh>

>
> Minor Issues:
> It would be helpful if the document directly referenced RFC 8029 and
> said that 8029 is where the TLVs that can carry these sub-TLVs is
> defined. That should be a normative reference.
> <SH> RFC 8029 is already under normative reference. I'll add text
> explaining RFC 8029 defines main TLVs where these sub-TLVs are
> carried. Thanks for pointing out.
<jmh>Thank you.</jmh>
>
>
>