IETF Logo Mail Archive

Re: [RTG-DIR] Rtgdir early review of draft-ietf-idr-bfd-subcode-03

Keyur Patel <keyur@arrcus.com> Wed, 05 October 2022 17:28 UTC

Return-Path: <keyur@arrcus.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 28C4DC14CE2C; Wed, 5 Oct 2022 10:28:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.907
X-Spam-Level:
X-Spam-Status: No, score=-1.907 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=netorgft1331857.onmicrosoft.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5_V0EOC9No3Y; Wed, 5 Oct 2022 10:28:52 -0700 (PDT)
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2068.outbound.protection.outlook.com [40.107.92.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EB47BC14CE28; Wed, 5 Oct 2022 10:28:48 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I5jHLIKJe6btRfQhzKI7QCZoWb6C83t1P3q4+4McLEr5N0YcSax2IGsnoN8cVswhutikGrPaj58zeMoPCcyzGXUyrwx8NlHCE8H/d2ZNs9jCkvLQIZ2L0aM2t4FvxVa+iYWYmSsdZ14xPjjU1V35awZnd6l4vdH1S1XFiPQadzSY7BZJ6CxrRzIz/9NegkHJwylEE4UMEX9LUCKI4GeBtqgKKyfCSRH/zobJBVH7IfK4fnERGVCimu6BdmkgpZQApi9K3S0xY43izzHUrgMkKB+/+t5YSn/H/eSMs1wSFoEauzyxrauGn9uONbkolobVB0tVWcJdCu6m8puPQEhBBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wTKzPJCz0vFEiZNriCjcHQpc5q+hOxyu3i04D5POo+o=; b=V7o/iM79OAOLL/V8LrnW8ANRFzb5M5wz9aU6+c4xLF9lKNZdp7AjQZwAtu6Magdak0OnS/eUkLKcJ0SGskWuC0O+fhvrMhTRpIpl4aXugPYaUmWJPqCotUWgVgaQklk/fzZ7q0Ybn52L5VjUzTzjYA4lKNhHllkqb2R1lh2X5xXNjrgfzrEbzlsX6thhuRgsKf+LupF05J1Z9hgCyBEhnjGnS+SVynBM9HsOOePjF0oPNECkqdL6OkQkPWH/D25dPGaM9QF/Glmn48sQeRTK2sWcNX0t4xAKSzKC5t/bS+9FAhwcJ/BrhAWvlmoDVvwNT2GKcVoi4zUGZvNtgP9h+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arrcus.com; dmarc=pass action=none header.from=arrcus.com; dkim=pass header.d=arrcus.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NETORGFT1331857.onmicrosoft.com; s=selector2-NETORGFT1331857-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wTKzPJCz0vFEiZNriCjcHQpc5q+hOxyu3i04D5POo+o=; b=ha5wA7GJ2J9+al19YsugxIr3yxbXJUC3ggSxOgLrOuY5twcoSgRDQU13VHAZCtNNbH0MzFuEeoTGeDNILY7yQdW6DYoDfGWzEcAJ5rdphq1jSOxCHjlXRsJdpHZ0CwYkSoE2svIISYu+A9PavVekCBk39775sBxEvV7X7c6vUQA=
Received: from BYAPR18MB2696.namprd18.prod.outlook.com (2603:10b6:a03:109::28) by SJ0PR18MB4089.namprd18.prod.outlook.com (2603:10b6:a03:2c9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Wed, 5 Oct 2022 17:28:44 +0000
Received: from BYAPR18MB2696.namprd18.prod.outlook.com ([fe80::6c41:c5af:2582:8725]) by BYAPR18MB2696.namprd18.prod.outlook.com ([fe80::6c41:c5af:2582:8725%3]) with mapi id 15.20.5676.032; Wed, 5 Oct 2022 17:28:44 +0000
From: Keyur Patel <keyur@arrcus.com>
To: Mohamed Boucadair <mohamed.boucadair@orange.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>
CC: "draft-ietf-idr-bfd-subcode.all@ietf.org" <draft-ietf-idr-bfd-subcode.all@ietf.org>, "idr@ietf.org" <idr@ietf.org>
Thread-Topic: Rtgdir early review of draft-ietf-idr-bfd-subcode-03
Thread-Index: AQHY2IvEH6qmX9QG70WYpnlnSqw1fa4ADlif
Date: Wed, 05 Oct 2022 17:28:44 +0000
Message-ID: <BYAPR18MB2696B33C995334172608567CC15D9@BYAPR18MB2696.namprd18.prod.outlook.com>
References: <166495467162.47232.7188267218682354200@ietfa.amsl.com>
In-Reply-To: <166495467162.47232.7188267218682354200@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arrcus.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR18MB2696:EE_|SJ0PR18MB4089:EE_
x-ms-office365-filtering-correlation-id: d419b55f-6522-43c9-e484-08daa6f70df4
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: loGz1S5FqXpxbCEva3PE/pzIj1rDugKYyJu/WO23eSOIH5pA5Ob6vHQFSA7y7gc5Qw68fPs4lfzeEALOh02suLAGe5tfyRYRFNMNa63rmRrVrnAaxwCH0oDrEzSCGBnFlEFkCQrzkygmcLWTF4jrCjrQkXacWH+teewGBXep2LBQcoBBdYSOI6tTzL0Wy6KYCq3r51JCLaF/iSNC9/f0eI3hrGWevT+L2Fr8R4/x+XDnjY7iDR1HXc4tIzrvuI2GeJLGLk6GBJFtvyqMQRtSSVWbWATWX2cprsoBcgUKG32E/HBk1Rjw4mOOpJAML727RKsmx/zIA27Ns0qTj3QwurnIfOBsBUG3kTYy4UTiBb9ULAFZ73Tth9qlbKYiv+wg3o3+sRWxS/HDC+0K91islAYH5VzJZJgOespNw41DhkFYmCpG3jVbRZC5NLdMZ9l+P36yn7NmdQVTCPQtipvjc0bugHGJBOuPuQvFLPS2UUFZWVJ8RYQvD59TK0S5RqSVXRLOYnvzlwEvRa2dHFiF1kb2unJ/tW2UwzLeLA13Acsy7Lm12Md7Hh7iRui18LyIdp5b8UcsuPR+ssh3BoenXPMKHXwZSjlLTnPzJDYlTMzqIkbrC2+mJrgt6mIv+2Q512dt88+t8+DRze7eBt9kXfCN4EhnIP751JGYDCGl7bF+vu22fPvs2hUqdcnPOZqzSaTPUbs0YvBh9Y2SYWeyNGRE/caMxb0ORWD6kODI8RvZAXIXC5MvBCV4LUA66iFE1dynjFqiEy/FVrKtbk1lFRfWpr+xUtCbQzVKqIwXE+M=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2696.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39840400004)(376002)(396003)(366004)(136003)(346002)(451199015)(186003)(2906002)(316002)(9326002)(66476007)(53546011)(76116006)(4326008)(122000001)(71200400001)(9686003)(54906003)(66446008)(7696005)(64756008)(66556008)(6506007)(8676002)(26005)(33656002)(66946007)(41300700001)(52536014)(8936002)(166002)(86362001)(110136005)(55016003)(83380400001)(38100700002)(966005)(38070700005)(478600001)(5660300002); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: VgPy4v8dhRsNOUlt0rjUtyJh59T0mh1j70iLhAWZd69H4f/xcY/HwDJVC1iCNREgzDQzmaMDsRppbm3xAIl0nhZufXpT9bHr99s5gn8bqB/hfDLcv8TexRBpgm0pz5xN5rmlAtVc47Pgjtk8z6to0bybhMZqjIDu6+uf8olwGJBMM7/RGZiRoAxjEZBo8edPMJaXh9rjg3NuD3HJ/qbqrRNXR0lcI2T0m8ba+ZS/p0X/l8nMCsdedjUa3Q0ZAulhNCU0GXU830dfMGmgsgG53rUpHC6VGvThGU6ZNF3gJV/iTIpJPOQvSDYL+0Yd+ehbI7FcfnFl31Yo/HePN+KUgM22WkSsv0tZRChwExEh/jcuUndUs95IJI6td3yT+QZoF5ur2M9OmVmf3rO6h7m2kopm+nMNmb2+Cziu93IDOUELhJktvO2RJYXnItggZVgIVIxgj9oUb+Un8b4m/rlkRsnI14CEeZ0gu+QUjzfuFun0KduPkohkXXph7TrNeJDL6ytMc71wPOFY7ipJVoUakP7igq6CS+9VzfIobGd4OZib+FnBFko+hYGtI+LEN65Z6FD6YqGcjuLMde96J1agWrYz5KM3ikCiFZlGeI0ABkBpyZaXLF+eWxriJ0oKA813xilU6BCPKQSYgArAzFVul1xIeP1JnBzL6qSfmdK8vAP7PpUiVz8JwSSoSPepCKrVk/JmOWIi9p0enTZlI/CpqVx4PZ7VpkROCllZWZ3YdiC2T4SHeRBcsThNhQf5Ucj2nKnCo+9hYltizX4QGpuR1+YvIo20vcpj50SpOf3IyFueL+8wGG6qem9HRI5CzFoZuu/4pN6PGkoU4/ad0VrI9euHmKCTWQ2lQwK8t/KcT7UMGyMgFUO7lP8ZPX301z/SwP3HKRnJ/IYA+QS8tPTGcqqyoHQ35nAuUAzXZGO0kD8Dejrsi5FQ3lTLz+auiY/O0EJIWwqfPJgPIGrjyIs7HHED2Q2K9wJ6GiZDrSsnVl/MOe8zCfnF8Tl05MLWqnNa1MAn8E0yK+IVfO/vH0+F0soZy+R7UnFm2JwMRgDLnwm847oF54tLAPtE6Q/XrRCunW5OZ/sWeI6SZFoRUnR8Agoc88dLTO4tQnCpbA43YWPHQpQaSMgrpnRJUSvQyeEAgXzts5R5Y1CdO6CLPxQDiLgmJXa6AcwWxA2M+vIAz6n3kTMbtmkfIkgA6DD5h1vM47emL7kKy1IUfM5opJoAKcxtUhkGmMU/R1OJNgxVZXdZqM9pCRaOtziYZDxMkcpSSa24N1J1omxERiAIO8BtgVWC9sjJWW5VQxcRarPX8VP06bmfaNDbyF8Iz3rnBrFTx9nmdRAj08Y9cuHoq1MaqcwqkQG6huB0VrMMIJxHyjn39kQeX+xpovtEfywUGo2G9pxFBMfqZQKTU1e0T+zRzbQSjE/MPzy93JAHoPydSvBeEmLGdCvYFYAIlGkRmgbIjdZMs3PtzWyCs/ThfppfVDyuzmIYAUN+TSdwAZHYKl8aW4E+ZChxbmkcdLnXF71zmoD1afNxLvNRVGh0tvbjqiHMCLP1ZJXAig3m69RGrFAGDvJTKU1QXXa6Twp3JuZKBiNLHhakxTS67mpF1O3WQA==
Content-Type: multipart/alternative; boundary="_000_BYAPR18MB2696B33C995334172608567CC15D9BYAPR18MB2696namp_"
MIME-Version: 1.0
X-OriginatorOrg: arrcus.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2696.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d419b55f-6522-43c9-e484-08daa6f70df4
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2022 17:28:44.7320 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 697b3529-5c2b-40cf-a019-193eb78f6820
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0A5OZ4ieC2IKAdEOByGkqxh7gNpxGI7N1Ghlk7XdPDOwI6u5p1cPvxGRdICKWJkqz8Z0cWJ+P6hSdSARYDrrSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4089
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/vVX60x8oReo6AEYwtLWByqqdeLw>
Subject: Re: [RTG-DIR] Rtgdir early review of draft-ietf-idr-bfd-subcode-03
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Oct 2022 17:28:56 -0000

Hi Mohammed,

Thank you for the detail draft review. Jeff Haas (author) should get back to you soon with his comments. 😊

Best Regards,
Keyur

From: Mohamed Boucadair via Datatracker <noreply@ietf.org>
Date: Wednesday, October 5, 2022 at 12:26 AM
To: rtg-dir@ietf.org <rtg-dir@ietf.org>
Cc: draft-ietf-idr-bfd-subcode.all@ietf.org <draft-ietf-idr-bfd-subcode.all@ietf.org>, idr@ietf.org <idr@ietf.org>
Subject: Rtgdir early review of draft-ietf-idr-bfd-subcode-03
Reviewer: Mohamed Boucadair
Review result: Has Issues

Document: draft-ietf-idr-bfd-subcode-03
Reviewer: Mohamed Boucadair
Review Date: 05/10/2022
IETF LC End Date: N/A
Intended Status: Standards Track

I have been selected to do a routing directorate “early” review of this draft.

# General

The specification is on good track and its core contribution is ready. However,
there are some very few points that I suggest to fix:

## Use consistent terminology (see more in the detailed review provided below)

## Consider adding a pointer to the BGP YANG module as an example to tweak the
associated BFD timers. Likewise, consider listing last-error (YANG) data node
in addition to the MIB mention.

## The Security Considerations Section should ACK at least the dependency on
the BFD to take actions. Manipulating the BFD session will thus have
implications on the BGP connection.

## IANA Considerations: The assignment is currently temporary (as per
https://www.iana.org/assignments/bgp-parameters/bgp-parameters.xhtml#bgp-parameters-4).
IANA should be requested to make that assignment permanent. I would update the
text accordingly.

## Consider moving at least RFC8538 to be listed as normative.

# Detailed Review:

FWIW, my detailed review can be found at:

* pdf:
https://github.com/boucadair/IETF-Drafts-Reviews/raw/master/draft-ietf-idr-bfd-subcode-03-rev%20Med.pdf
* doc:
https://github.com/boucadair/IETF-Drafts-Reviews/raw/master/draft-ietf-idr-bfd-subcode-03-rev%20Med.doc

v2.23.0 | Report a Bug | By Email