[RTG-DIR] Rtgdir review of draft-ietf-sfc-ioam-nsh-10

Mach Chen <mach.chen@huawei.com> Sat, 27 August 2022 09:16 UTC

Return-Path: <mach.chen@huawei.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C584C14CF17; Sat, 27 Aug 2022 02:16:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.908
X-Spam-Level:
X-Spam-Status: No, score=-6.908 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nwnOuCrQneZN; Sat, 27 Aug 2022 02:16:32 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B96BC157B3B; Sat, 27 Aug 2022 02:16:19 -0700 (PDT)
Received: from fraeml742-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4MF9vt6HQMz67dBN; Sat, 27 Aug 2022 17:12:42 +0800 (CST)
Received: from dggpemm100004.china.huawei.com (7.185.36.189) by fraeml742-chm.china.huawei.com (10.206.15.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 27 Aug 2022 11:16:15 +0200
Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggpemm100004.china.huawei.com (7.185.36.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 27 Aug 2022 17:16:13 +0800
Received: from dggpemm500002.china.huawei.com ([7.185.36.229]) by dggpemm500002.china.huawei.com ([7.185.36.229]) with mapi id 15.01.2375.024; Sat, 27 Aug 2022 17:16:13 +0800
From: Mach Chen <mach.chen@huawei.com>
To: "rtg-dir@ietf.org" <rtg-dir@ietf.org>
CC: "draft-ietf-sfc-ioam-nsh@ietf.org" <draft-ietf-sfc-ioam-nsh@ietf.org>, "sfc@ietf.org" <sfc@ietf.org>
Thread-Topic: Rtgdir review of draft-ietf-sfc-ioam-nsh-10
Thread-Index: Adi59WFneqmIS2emRuOwpfEK579eQA==
Date: Sat, 27 Aug 2022 09:16:13 +0000
Message-ID: <3fd64dab563e4658ade4c0fcf8d7bb66@huawei.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.110.46.250]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/vaT9-zaQYO6D28ahbQg8MWVoVQ8>
Subject: [RTG-DIR] Rtgdir review of draft-ietf-sfc-ioam-nsh-10
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Aug 2022 09:16:37 -0000

Hello,
I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-sfc-ioam-nsh-10
Reviewer: Mach Chen
Review Date: 2022-08-22
IETF LC End Date: 
Intended Status: Standards Track

Summary:
I have some minor concerns about this document that I think should be resolved before publication. 

Comments:
The draft is well written and easy to read.

Section 3,
"The O-bit MUST be handled following the rules in [I-D.ietf-sfc-oam-packet]." 

According to [I-D.ietf-sfc-oam-packet], a NSH-encapsulated packet with IOAM will not be considered as OAM packet. Thus, it's better to state that "the O-bit MUST NOT be set" for packet with IOAM header in this document. 

Major Issues:
No major issues found.

Minor Issues:
Quoted from Section 2.2, last paragraph of RFC 8300, it says:
"...Packets with Next Protocol values not supported SHOULD be silently dropped
      by default, although an implementation MAY provide a configuration
      parameter to forward them."

With above requirement, when insert an IOAM header to a NSH-encapsulated packet, the encapsulating node MUST make sure that every nodes (e.g., SFF, SF) along the service path supports IOAM, otherwise, the packet will be silently dropped. IMHO, this should be discussed in the document to make this more explicit. 

Nits:
None.

Best regards,
Mach