[RTG-DIR] Routing Directorate QA Review of draft-ietf-rtgwg-yang-rip
Julien Meuric <julien.meuric@orange.com> Fri, 13 January 2017 16:39 UTC
Return-Path: <julien.meuric@orange.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 82EB21294A1; Fri, 13 Jan 2017 08:39:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.733
X-Spam-Level:
X-Spam-Status: No, score=-6.733 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-3.199, SPF_SOFTFAIL=0.665] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T0Gtxa5eIzko; Fri, 13 Jan 2017 08:39:43 -0800 (PST)
Received: from r-mail1.rd.orange.com (r-mail1.rd.orange.com [217.108.152.41]) by ietfa.amsl.com (Postfix) with ESMTP id 49D3B129C63; Fri, 13 Jan 2017 08:39:38 -0800 (PST)
Received: from r-mail1.rd.orange.com (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id C9DAADE4003; Fri, 13 Jan 2017 17:39:36 +0100 (CET)
Received: from FTRDCH01.rd.francetelecom.fr (unknown [10.194.32.11]) by r-mail1.rd.orange.com (Postfix) with ESMTP id A297EDE4002; Fri, 13 Jan 2017 17:39:36 +0100 (CET)
Received: from [10.193.71.173] (10.193.71.173) by FTRDCH01.rd.francetelecom.fr (10.194.32.11) with Microsoft SMTP Server id 14.3.319.2; Fri, 13 Jan 2017 17:39:36 +0100
From: Julien Meuric <julien.meuric@orange.com>
Organization: Orange
To: rtgwg@ietf.org, draft-ietf-rtgwg-yang-rip.all@ietf.org
Message-ID: <adbb1acc-8bf3-39cb-66a8-241f9de8063c@orange.com>
Date: Fri, 13 Jan 2017 17:39:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/xgVPFy96qM5GAY0tP8g6QY7lI_0>
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>
Subject: [RTG-DIR] Routing Directorate QA Review of draft-ietf-rtgwg-yang-rip
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2017 16:39:45 -0000
Hello, I have been selected as the Routing Directorate QA reviewer for this draft. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir At this stage, the intend of the following is not to discuss the WG's decision about the I-D, but rather to help improving its content. Please not that I am not deep Yang expert, but RFC 6087 has provided me with valuable guidelines. _Summary_ The Yang module specified in the I-D may be almost complete to move forward. The carrying document however deserves an update before going to the next step. I do not repeat every comment raised by Yang doctors in last December, but those need to be addressed as well. _Comments_ - Add "import ietf-isis" and "import ietf-bgp" (page 9) - According to RFC 6087, section 3.1, "the module description statement MUST contain a reference to the latest approved IETF Trust Copyright statement" (p 10). - Both "prefix-set-ref" and "route-policy-ref" are defined as new types (p 11): is there a reason not to consider them as generic types specified elsewhere (e.g., among routing types). - Yangvalidator raises errors on the 6 "must" expressions (cf. Yang doctors' review). - The security section does not say anything about the read/write fields nor the "clear route" RPC: it really requires some work, please see the template in RFC 6087, section 6.1. - Normative references needs to be updated, at least with the following: * RFC 6991 * RFC 7223 * RFC 7277 * draft-ietf-rtgwg-routing-types * draft-ietf-rtgwg-yang-key-chain * draft-ietf-ospf-yang * draft-ietf-isis-yang-isis-cfg * draft-ietf-idr-bgp-model * draft-ietf-bfd-yang - Reading RFC 1724 (RIPv2 MIB) is clearly unnecessary to understand the document, the reference must thus be moved to the informative list. _Nits_ - In the "bfd-protocol-parms" string (page 10), the abbreviation for "parameters" is unusual; was "params" intended? - In "originate-default-route-container" (p 12), to be consistent: s/RIP or RIPng instance/RIP routing instance/ - In "redistribute-container" (p 12): s/BFP autonomous system/BGP autonomous system/ - In "list isis" (p 12-13): s/ISIS/IS-IS/ [5 times] - In "list ospfv2" (p 14-15): s/OSPF routing instance into the RIP routing instance/OSPFv2 routing instance into the RIPv2 routing instance/ [twice] - In "route-type" of "list ospfv2" (p 15): s/OSPF routes matching the specified route type into the RIP routing instance/OSPFv2 routes matching the specified route type into the RIPv2 routing instance/ - In "list ospfv3" (p 15): s/OSPF routing instance into the RIP routing instance/OSPFv3 routing instance into the RIPng routing instance/ [twice] - In "route-type" of "list ospfv3" (p 16): s/OSPF routes matching the specified route type into the RIP routing instance/OSPFv3 routes matching the specified route type into the RIPng routing instance/ - In "ripv2" (p 16): s/RIP routing instance into the current RIP routing instance/RIPv2 routing instance into the current RIPv2 routing instance/ [twice] - In "leaf listen" of "list interface" (p 29): s/RIP or RIPng/RIPv2 or RIPng/ - In "container ipv4" (p 31): s/A RIPv2 RIP neighbor/A RIPv2 neighbor/ - In "container ipv6" (p 33): s/A RIPv2 RIP neighbor/A RIPng neighbor/ - In "leaf ipv6-prefix" of "container routes" (p 34): s/in RFC5952)and/in RFC5952) and/ Regards, Julien
- [RTG-DIR] Routing Directorate QA Review of draft-… Julien Meuric
- Re: [RTG-DIR] Routing Directorate QA Review of dr… Xufeng Liu
- Re: [RTG-DIR] Routing Directorate QA Review of dr… Julien Meuric