[RTG-DIR] RtgDir Last Call review: draft-ietf-pim-null-register-packing

Tal Mizrahi <tal.mizrahi.phd@gmail.com> Tue, 28 February 2023 06:54 UTC

Return-Path: <tal.mizrahi.phd@gmail.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D4FEAC14CE4B; Mon, 27 Feb 2023 22:54:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.094
X-Spam-Level:
X-Spam-Status: No, score=-2.094 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jva7s8fFbi7t; Mon, 27 Feb 2023 22:54:39 -0800 (PST)
Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 54E72C14CE44; Mon, 27 Feb 2023 22:54:39 -0800 (PST)
Received: by mail-io1-xd36.google.com with SMTP id d12so3645946ioe.10; Mon, 27 Feb 2023 22:54:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=oArqgxWZhjZCrKNtKk4H0xIUif28qWwjg+rPHouWo+M=; b=YCR53+fKeiKAFvNjxAKS8nU/d08kdKvjtuAao+DnIMDp9CKz4pj9IhGuojdQm8qSXn L752tOZWsSlcc8Apc2VrmJjRACcMW5k1x4AsoYimNvmoLmsEP0uLrEg8dYqtCah45Rbs k5Wiy2UisjcH+uFsdPMdCNHjOu5mU52UMyJfh7IPTESGWTP0ks37D7HAgqc16xiT638s cGj/OXKUOyCN74yEzVkasUPnA0Buqq5ojsvnbivrUAno0JFoAXsvJP5ucZRV3sLFRZrS B7h4sOHfQ9C5+34FRfYQOl8163jSMZOOfvn166bJPRxSbjUEPmisGJrfb1GuuPQxhm4p FAtQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oArqgxWZhjZCrKNtKk4H0xIUif28qWwjg+rPHouWo+M=; b=CBXXJ6wPayPLnVSDOPhoNBE0nmmy8TqJWlt379qYCBgTzP37/Ocy6FcOYwheekUDcx s7ttpuQtwTR0x6/RONpg0xLQkZo31OvbYn5axzSmCg7NlsoMLi+KTAphyAb1lXlojZ6W y7ABJDUOl2QXww/wyIm3IJQTB+7XY3zfa6F1u4nfzwcfZg804tZQCulPLmCrusK3eK+o Gc1FxSVW5U0+yZhW6x6AHTt8hfa1+C/kCEekqLy6Dc1Hjq5HFYi3gzNUJAZUH76NZCZ9 QlG7z07dENe3I7Nj/jWylBo3MIKGXJnvgQkyZhRHd7NsKNNXVUu+gATQAztl54P3+6sr FgKg==
X-Gm-Message-State: AO0yUKX5z1aeYPtsLLZn6woBTPxtG7tTRZuDg7Ansb0D8cHQb77CgOB+ iZhOE4UZfewa5803Lj34a8GH1rfNAhDGaNAV2tzz08U2DbL9TQ==
X-Google-Smtp-Source: AK7set9Rd1Y9ZzqKRiG3/cvBx1QHPbPdmDraX/0VwMyV+okWYsUr7MHIk8k9QtIoCdvzCLOgmgvAHh3PPf1S4AdyHWY=
X-Received: by 2002:a6b:912:0:b0:71b:8c6:6123 with SMTP id t18-20020a6b0912000000b0071b08c66123mr865101ioi.3.1677567278140; Mon, 27 Feb 2023 22:54:38 -0800 (PST)
MIME-Version: 1.0
From: Tal Mizrahi <tal.mizrahi.phd@gmail.com>
Date: Tue, 28 Feb 2023 08:54:26 +0200
Message-ID: <CABUE3XmFphcX4K2i42QdzrEzbf-R=bmTsr9u-530RvPg=rDsjQ@mail.gmail.com>
To: rtg-ads@ietf.org
Cc: rtg-dir@ietf.org, draft-ietf-pim-null-register-packing@ietf.org, pim@ietf.org, Last Call <last-call@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/yWcRnj7vsspe9dkvfqNzfr_imWQ>
Subject: [RTG-DIR] RtgDir Last Call review: draft-ietf-pim-null-register-packing
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Feb 2023 06:54:39 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this
draft. The Routing Directorate seeks to review all routing or
routing-related drafts as they pass through IETF last call and IESG
review, and sometimes on special request. The purpose of the review is
to provide assistance to the Routing ADs. For more information about
the Routing Directorate, please see
http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs,
it would be helpful if you could consider them along with any other
IETF Last Call comments that you receive, and strive to resolve them
through discussion or by updating the draft.

Document: draft-ietf-pim-null-register-packing
Reviewer: Tal Mizrahi
Review Date: February 28th, 2023
Intended Status: Standards Track

Summary:
This document is basically ready for publication but has nits that
should be considered prior to publication.

Comments:
This document is clear and straightforward, and is almost ready for publication.

Nits:
- "This draft" => "This document"
- "The draft" => "The document"
- Section 2 - please mention that you are referring to the 'P' bit in Figure 1.
- Section 3 and Section 4: please describe explicitly what happens
with the Subtype. It looks like you are not asking for an allocation,
so is this field going to have a constant value? Please describe this
in the document.
- Section 9: it would help if this section was more explicit in
defining the rows that you would like to add to the table in the PIM
Message Types registry. In addition, it looks like for each of the two
types you want to allocate a 'P' flag, right? Please describe this
explicitly.

Cheers,
Tal.