[Rtg-yang-coord] draft-ietf-isis-yang-isis-cfg-07

Radha Danda <rdanda@Brocade.com> Wed, 25 November 2015 09:27 UTC

Return-Path: <rdanda@Brocade.com>
X-Original-To: rtg-yang-coord@ietfa.amsl.com
Delivered-To: rtg-yang-coord@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF0BC1A0358 for <rtg-yang-coord@ietfa.amsl.com>; Wed, 25 Nov 2015 01:27:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.103
X-Spam-Level: *
X-Spam-Status: No, score=1.103 tagged_above=-999 required=5 tests=[BAYES_05=-0.5, J_CHICKENPOX_74=0.6, KHOP_DYNAMIC=1.004, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dXPN86N-enak for <rtg-yang-coord@ietfa.amsl.com>; Wed, 25 Nov 2015 01:27:24 -0800 (PST)
Received: from mx0b-000f0801.pphosted.com (mx0b-000f0801.pphosted.com [IPv6:2620:100:9005:71::1]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1E0C91A032D for <rtg-yang-coord@ietf.org>; Wed, 25 Nov 2015 01:27:23 -0800 (PST)
Received: from pps.filterd (m0048192.ppops.net [127.0.0.1]) by mx0b-000f0801.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id tAP8plAw019310 for <rtg-yang-coord@ietf.org>; Wed, 25 Nov 2015 01:27:23 -0800
Received: from brmwp-exmb11.corp.brocade.com ([208.47.132.227]) by mx0b-000f0801.pphosted.com with ESMTP id 1ycwyd9mds-1 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT) for <rtg-yang-coord@ietf.org>; Wed, 25 Nov 2015 01:27:23 -0800
Received: from BRMWP-EXMB11.corp.brocade.com (172.16.59.77) by BRMWP-EXMB11.corp.brocade.com (172.16.59.77) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Wed, 25 Nov 2015 02:27:21 -0700
Received: from BRMWP-EXMB11.corp.brocade.com ([fe80::39a0:e6f2:6a5c:18a9]) by BRMWP-EXMB11.corp.brocade.com ([fe80::39a0:e6f2:6a5c:18a9%23]) with mapi id 15.00.1104.000; Wed, 25 Nov 2015 02:27:21 -0700
From: Radha Danda <rdanda@Brocade.com>
To: "rtg-yang-coord@ietf.org" <rtg-yang-coord@ietf.org>
Thread-Topic: draft-ietf-isis-yang-isis-cfg-07
Thread-Index: AdEnXlNlFwRr22YfQTqx+4BMOFFAcQ==
Date: Wed, 25 Nov 2015 09:27:20 +0000
Message-ID: <a491d22e72e84a3b8af77a21a1728d2b@BRMWP-EXMB11.corp.brocade.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [172.22.17.13]
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-Proofpoint-SPF-Result: neutral
X-Proofpoint-SPF-Record: v=spf1 include:spf-000f0801.pphosted.com include:salesforce.com include:Spf.protection.outlook.com include:mktomail.com include:bmsend.com ip4:208.74.204.0/22 ip4:46.19.168.0/23 mx ?all
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.15.21, 1.0.33, 0.0.0000 definitions=2015-11-25_06:2015-11-24,2015-11-25,1970-01-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1508030000 definitions=main-1511250163
Archived-At: <http://mailarchive.ietf.org/arch/msg/rtg-yang-coord/HN_d7m4jhoty9QdLH0Orw_ATmQ4>
Subject: [Rtg-yang-coord] draft-ietf-isis-yang-isis-cfg-07
X-BeenThere: rtg-yang-coord@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "\"List to discuss coordination between the Routing related YANG models\"" <rtg-yang-coord.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-yang-coord>, <mailto:rtg-yang-coord-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-yang-coord/>
List-Post: <mailto:rtg-yang-coord@ietf.org>
List-Help: <mailto:rtg-yang-coord-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-yang-coord>, <mailto:rtg-yang-coord-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Nov 2015 09:27:25 -0000

Hi,
I was going through draft-ietf-isis-yang-isis-cfg-07 and I have below comments.

1. system-id definition should not contain selector. As per NSAP definition, system-ID is 6 bytes and it has below mentioned format and it is only of length 6 bytes.
  
typedef system-id {
    type string {
      pattern
       '[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}';
    }
    description
     "This type defines ISIS system id using pattern,
      system id looks like : 0143.0438.AeF0";
  }

2. Also we need support to configure net-address as shown below.
       typedef net-address {
                type string {
                        pattern
                                '[0-9A-Fa-f]{2}\.([0-9A-Fa-f]{4}\.){0,3}[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}\.00';
                        configd:pattern-help "XX.XXXX. ... .XXXX.XX";
                        configd:help "Network entity title (NET)";
                }
        }

Please let me know if you need more details. This is my first post, so please excuse me in case if I miss to provide some details. 

Best Regards,
Radha